Re: [PATCH 2/2] drm/vc4: Correct POS1_SCL for hvs5
From: Lucas Nussbaum
Subject: Re: [PATCH 2/2] drm/vc4: Correct POS1_SCL for hvs5
Date: Sat, 23 Jan 2021 09:05:48 +0100
> On 21/01/21 at 11:57 +0100, Maxime Ripard wrote:
>> From: Dom Cobley
>>
>> Fixes failure with 4096x1080 resolutions
>>
>> [ 284.315379] WARNING: CPU: 1 PID: 901 at
>> drivers/gpu/drm/vc4/vc4_plane.c:981 vc4_plane_mode_set+0x1374/0x13c4
>> [ 284.315385] Modules linked in: ir_rc5_decoder rpivid_hevc(C)
>> bcm2835_codec(C) bcm2835_isp(C) bcm2835_mmal_vchiq(C) bcm2835_gpiomem
>> v4l2_mem2mem videobuf2_dma_contig videobuf2_memops videobuf2_v4l2
>> videobuf2_common videodev mc cdc_acm xpad ir_rc6_decoder rc_rc6_mce
>> gpio_ir_recv fuse
>> [ 284.315509] CPU: 1 PID: 901 Comm: kodi.bin Tainted: G C
>> 5.10.7 #1
>> [ 284.315514] Hardware name: BCM2711
>> [ 284.315518] Backtrace:
>> [ 284.315533] [] (dump_backtrace) from []
>> (show_stack+0x20/0x24)
>> [ 284.315540] r7: r6: r5:6813 r4:c18ecf1c
>> [ 284.315549] [] (show_stack) from []
>> (dump_stack+0xc4/0xf0)
>> [ 284.315558] [] (dump_stack) from []
>> (__warn+0xfc/0x158)
>> [ 284.315564] r9: r8:0009 r7:03d5 r6:0009 r5:c08cc7dc
>> r4:c0fd09b8
>> [ 284.315572] [] (__warn) from []
>> (warn_slowpath_fmt+0x74/0xe4)
>> [ 284.315577] r7:c08cc7dc r6:03d5 r5:c0fd09b8 r4:
>> [ 284.315584] [] (warn_slowpath_fmt) from []
>> (vc4_plane_mode_set+0x1374/0x13c4)
>> [ 284.315589] r8: r7: r6:1000 r5:c404c600 r4:c2e34600
>> [ 284.315596] [] (vc4_plane_mode_set) from []
>> (vc4_plane_atomic_check+0x40/0x1c0)
>> [ 284.315601] r10:0001 r9:c2e34600 r8:c0e67068 r7:c0fc44e0 r6:c2ce3640
>> r5:c3d636c0
>> [ 284.315605] r4:c2e34600
>> [ 284.315614] [] (vc4_plane_atomic_check) from []
>> (drm_atomic_helper_check_planes+0xec/0x1ec)
>> [ 284.315620] r9:c2e34600 r8:c0e67068 r7:c0fc44e0 r6:c2ce3640 r5:c3d636c0
>> r4:0006
>> [ 284.315627] [] (drm_atomic_helper_check_planes) from
>> [] (drm_atomic_helper_check+0x54/0x9c)
>> [ 284.315633] r9:c2e35400 r8:0006 r7: r6:c2ba7800 r5:c3d636c0
>> r4:
>> [ 284.315641] [] (drm_atomic_helper_check) from []
>> (vc4_atomic_check+0x25c/0x454)
>> [ 284.315645] r7: r6:c2ba7800 r5:0001 r4:c3d636c0
>> [ 284.315652] [] (vc4_atomic_check) from []
>> (drm_atomic_check_only+0x5cc/0x7e0)
>> [ 284.315658] r10:c404c6c8 r9: r8:c472c480 r7:0003 r6:c3d636c0
>> r5:
>> [ 284.315662] r4:003c r3:c08b7a4c
>> [ 284.315670] [] (drm_atomic_check_only) from []
>> (drm_mode_atomic_ioctl+0x758/0xa7c)
>> [ 284.315675] r10:c3d46000 r9:c3d636c0 r8:c2ce8a70 r7:027e3a54 r6:0043
>> r5:c1fbb800
>> [ 284.315679] r4:0281a858
>> [ 284.315688] [] (drm_mode_atomic_ioctl) from []
>> (drm_ioctl_kernel+0xc4/0x108)
>> [ 284.315693] r10:c03864bc r9:c1fbb800 r8:c3d47e64 r7:c089b308 r6:0002
>> r5:c2ba7800
>> [ 284.315697] r4:
>> [ 284.315705] [] (drm_ioctl_kernel) from []
>> (drm_ioctl+0x1e8/0x3a0)
>> [ 284.315711] r9:c1fbb800 r8:00bc r7:c3d47e64 r6:0038 r5:c0e59570
>> r4:0038
>> [ 284.315719] [] (drm_ioctl) from []
>> (sys_ioctl+0x35c/0x914)
>> [ 284.315724] r10:c2d08200 r9: r8:c36fa300 r7:befdd870 r6:c03864bc
>> r5:c36fa301
>> [ 284.315728] r4:c03864bc
>> [ 284.315735] [] (sys_ioctl) from []
>> (ret_fast_syscall+0x0/0x28)
>> [ 284.315739] Exception stack(0xc3d47fa8 to 0xc3d47ff0)
>> [ 284.315745] 7fa0: 027eb750 befdd870 c03864bc
>> befdd870
>> [ 284.315750] 7fc0: 027eb750 befdd870 c03864bc 0036 027e3948 0281a640
>> 0281a850 027e3a50
>> [ 284.315756] 7fe0: b4b64100 befdd844 b4b5ba2c b49c994c
>> [ 284.315762] r10:0036 r9:c3d46000 r8:c0200204 r7:0036 r6:c03864bc
>> r5:befdd870
>> [ 284.315765] r4:027eb750
>>
>> Fixes: c54619b0bfb3 ("drm/vc4: Add support for the BCM2711 HVS5")
>> Signed-off-by: Dom Cobley
>> Signed-off-by: Maxime Ripard
>
> Tested-By: Lucas Nussbaum
Tested-By: Ryutaroh Matsumoto
Thank you very much for all of your work!
Ryutaroh
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/2] drm/vc4: Correct lbm size and calculation
Hi Maxime, >> This one should fix your issue >> Feel free to test it and let me know if it's not the case > I confirm that the patches fix the issue I was seeing. I also applied the sent patches [PATCH 1/2] drm/vc4: Correct lbm size and calculation [PATCH 2/2] drm/vc4: Correct POS1_SCL for hvs5 to the 5.10.9 kernel, and the symptom disappeared on my Raspberry Pi 4B 8GB. Thank you very much! Ryutaroh ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH RFT 0/2] drm/vc4: Clear the display list on startup
Hi Lucas, > week-end, so I cannot test before early next week. However I'm Ccing > Ryutaroh Matsumoto who could also reproduce it. Maybe he is in a better > position to test this (@Ryutaroh: I bounced the patches to you). Should I apply PATCH RFT 0--2/2 to https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-5.10.7.tar.xz or some branch of someone's git repo? On my Raspberry Pi 4B 8GB model, all versioins up to upstream 5.10.6 fail to boot on USB MSD due to changes to the USB handling by raspi introduced in 5.10 series, and failed to boot from an SD card up to 5.10.3 or so. No working WiFi connections neither on my raspi 4b. I am unsure if I can test the patch reliably. But I will try it within a few days. Best regards, Ryutaroh ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
