[PATCH] arm/komeda: Remove all CONFIG_DEBUG_FS conditional compilations

2024-06-06 Thread pengfuyuan
Since the debugfs functions have no-op stubs for CONFIG_DEBUG_FS=n,
the compiler will optimize the rest away since they are no longer referenced.

The benefit of removing the conditional compilation is that the build
is actually tested for both CONFIG_DEBUG_FS configuration values.
Assuming most developers have it enabled, CONFIG_DEBUG_FS=n is not tested
much and may fail the build due to the conditional compilation.

Reported-by: k2ci 
Signed-off-by: pengfuyuan 
---
 drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 8 
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c 
b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
index 14ee79becacb..5ba62e637a61 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
@@ -12,10 +12,8 @@
 #include 
 #include 
 #include 
-#ifdef CONFIG_DEBUG_FS
 #include 
 #include 
-#endif
 
 #include 
 
@@ -43,7 +41,6 @@ static int komeda_register_show(struct seq_file *sf, void *x)
 
 DEFINE_SHOW_ATTRIBUTE(komeda_register);
 
-#ifdef CONFIG_DEBUG_FS
 static void komeda_debugfs_init(struct komeda_dev *mdev)
 {
if (!debugfs_initialized())
@@ -55,7 +52,6 @@ static void komeda_debugfs_init(struct komeda_dev *mdev)
debugfs_create_x16("err_verbosity", 0664, mdev->debugfs_root,
   >err_verbosity);
 }
-#endif
 
 static ssize_t
 core_id_show(struct device *dev, struct device_attribute *attr, char *buf)
@@ -265,9 +261,7 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
 
mdev->err_verbosity = KOMEDA_DEV_PRINT_ERR_EVENTS;
 
-#ifdef CONFIG_DEBUG_FS
komeda_debugfs_init(mdev);
-#endif
 
return mdev;
 
@@ -286,9 +280,7 @@ void komeda_dev_destroy(struct komeda_dev *mdev)
 
sysfs_remove_group(>kobj, _sysfs_attr_group);
 
-#ifdef CONFIG_DEBUG_FS
debugfs_remove_recursive(mdev->debugfs_root);
-#endif
 
if (mdev->aclk)
clk_prepare_enable(mdev->aclk);
-- 
2.25.1



[PATCH] arm/komeda: Compile DEFINE_SHOW_ATTRIBUTE() only when CONFIG_DEBUG_FS is enabled

2024-06-06 Thread pengfuyuan
We do not call komeda_debugfs_init() and the debugfs core function
declaration if CONFIG_DEBUG_FS is not defined, but we should not
compile it either because the debugfs core function declaration is
not included.

Reported-by: k2ci 
Signed-off-by: pengfuyuan 
---
 drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c 
b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
index 14ee79becacb..7ada8e6f407c 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
@@ -21,6 +21,7 @@
 
 #include "komeda_dev.h"
 
+#ifdef CONFIG_DEBUG_FS
 static int komeda_register_show(struct seq_file *sf, void *x)
 {
struct komeda_dev *mdev = sf->private;
@@ -43,7 +44,6 @@ static int komeda_register_show(struct seq_file *sf, void *x)
 
 DEFINE_SHOW_ATTRIBUTE(komeda_register);
 
-#ifdef CONFIG_DEBUG_FS
 static void komeda_debugfs_init(struct komeda_dev *mdev)
 {
if (!debugfs_initialized())
-- 
2.25.1



[PATCH] drm/i915/pxp:fix kernel-doc trivial warnings

2023-05-24 Thread pengfuyuan
The test robot reports some make warnings.

Fix those warnings:
drivers/gpu/drm/i915/pxp/intel_pxp_types.h:96: warning: Function parameter 
or member 'dev_link' not described in 'intel_pxp'

Reported-by: k2ci 
Signed-off-by: pengfuyuan 
---
 drivers/gpu/drm/i915/pxp/intel_pxp_types.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_types.h 
b/drivers/gpu/drm/i915/pxp/intel_pxp_types.h
index 007de49e1ea4..41994a3294a0 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp_types.h
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp_types.h
@@ -33,7 +33,7 @@ struct intel_pxp {
 */
struct i915_pxp_component *pxp_component;
 
-   /* @dev_link: Enforce module relationship for power management 
ordering. */
+   /** @dev_link: Enforce module relationship for power management 
ordering. */
struct device_link *dev_link;
/**
 * @pxp_component_added: track if the pxp component has been added.
-- 
2.25.1


No virus found
Checked by Hillstone Network AntiVirus


[PATCH] drm/i915/gt/uc:fix kernel-doc trivial warnings

2023-05-24 Thread pengfuyuan
The test robot reports some make warnings.

Fix those warnings:
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function 
parameter or member 'marker' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function 
parameter or member 'read_ptr' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function 
parameter or member 'write_ptr' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function 
parameter or member 'size' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function 
parameter or member 'sampled_write_ptr' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function 
parameter or member 'wrap_offset' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function 
parameter or member 'flush_to_file' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function 
parameter or member 'buffer_full_cnt' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function 
parameter or member 'reserved' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function 
parameter or member 'flags' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function 
parameter or member 'version' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc.h:274: warning: Function parameter or 
member 'dbgfs_node' not described in 'intel_guc'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function 
parameter or member 'size' not described in '__guc_capture_bufstate'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function 
parameter or member 'data' not described in '__guc_capture_bufstate'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function 
parameter or member 'rd' not described in '__guc_capture_bufstate'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function 
parameter or member 'wr' not described in '__guc_capture_bufstate'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function 
parameter or member 'link' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function 
parameter or member 'is_partial' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function 
parameter or member 'eng_class' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function 
parameter or member 'eng_inst' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function 
parameter or member 'guc_id' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function 
parameter or member 'lrca' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function 
parameter or member 'reginfo' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function 
parameter or member 'is_valid' not described in '__guc_capture_ads_cache'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function 
parameter or member 'ptr' not described in '__guc_capture_ads_cache'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function 
parameter or member 'size' not described in '__guc_capture_ads_cache'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function 
parameter or member 'status' not described in '__guc_capture_ads_cache'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function 
parameter or member 'ads_null_cache' not described in 'intel_guc_state_capture'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function 
parameter or member 'max_mmio_per_node' not described in 
'intel_guc_state_capture'

Reported-by: k2ci 
Signed-off-by: pengfuyuan 
---
 drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h | 27 +++
 drivers/gpu/drm/i915/gt/uc/intel_guc.h|  1 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h   | 18 +
 3 files changed, 46 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h 
b/drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h
index 9d589c28f40f..84c74244a6a8 100644
--- a/drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h
+++ b/drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h
@@ -18,6 +18,11 @@ struct file;
  * Book-keeping structure used to track read and write pointers
  * as we extract error capture data from the GuC-log-buffer's
  * error-capture

[PATCH] drm/i915/gt: fix kernel-doc trivial warnings

2023-05-24 Thread pengfuyuan
The test robot reports some make warnings.

Fix those warnings:
drivers/gpu/drm/i915/gt/intel_gtt.h:499: warning: Function parameter or 
member 'vm' not described in 'i915_vm_resv_put'
drivers/gpu/drm/i915/gt/intel_context.h:108: warning: Function parameter or 
member 'ce' not described in 'intel_context_lock_pinned'
drivers/gpu/drm/i915/gt/intel_context.h:123: warning: Function parameter or 
member 'ce' not described in 'intel_context_is_pinned'
drivers/gpu/drm/i915/gt/intel_context.h:142: warning: Function parameter or 
member 'ce' not described in 'intel_context_unlock_pinned
drivers/gpu/drm/i915/gt/intel_engine_types.h:293: warning: Function 
parameter or member 'preempt_hang' not described in 'intel_engine_execlists'

Reported-by: k2ci 
Signed-off-by: pengfuyuan 
---
 drivers/gpu/drm/i915/gt/intel_context.h  | 6 +++---
 drivers/gpu/drm/i915/gt/intel_engine_types.h | 3 +++
 drivers/gpu/drm/i915/gt/intel_gtt.h  | 2 +-
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_context.h 
b/drivers/gpu/drm/i915/gt/intel_context.h
index 48f888c3da08..6b5eae7b88bc 100644
--- a/drivers/gpu/drm/i915/gt/intel_context.h
+++ b/drivers/gpu/drm/i915/gt/intel_context.h
@@ -97,7 +97,7 @@ void intel_context_bind_parent_child(struct intel_context 
*parent,
 
 /**
  * intel_context_lock_pinned - Stablises the 'pinned' status of the HW context
- * @ce - the context
+ * @ce: the context
  *
  * Acquire a lock on the pinned status of the HW context, such that the context
  * can neither be bound to the GPU or unbound whilst the lock is held, i.e.
@@ -111,7 +111,7 @@ static inline int intel_context_lock_pinned(struct 
intel_context *ce)
 
 /**
  * intel_context_is_pinned - Reports the 'pinned' status
- * @ce - the context
+ * @ce: the context
  *
  * While in use by the GPU, the context, along with its ring and page
  * tables is pinned into memory and the GTT.
@@ -133,7 +133,7 @@ static inline void intel_context_cancel_request(struct 
intel_context *ce,
 
 /**
  * intel_context_unlock_pinned - Releases the earlier locking of 'pinned' 
status
- * @ce - the context
+ * @ce: the context
  *
  * Releases the lock earlier acquired by intel_context_unlock_pinned().
  */
diff --git a/drivers/gpu/drm/i915/gt/intel_engine_types.h 
b/drivers/gpu/drm/i915/gt/intel_engine_types.h
index 960291f88fd6..1fc1fc882097 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine_types.h
+++ b/drivers/gpu/drm/i915/gt/intel_engine_types.h
@@ -289,6 +289,9 @@ struct intel_engine_execlists {
 */
u8 csb_head;
 
+   /**
+* @preempt_hang: preempt hang state for self-tests.
+*/
I915_SELFTEST_DECLARE(struct st_preempt_hang preempt_hang;)
 };
 
diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.h 
b/drivers/gpu/drm/i915/gt/intel_gtt.h
index 69ce55f517f5..a9aa72a8c59c 100644
--- a/drivers/gpu/drm/i915/gt/intel_gtt.h
+++ b/drivers/gpu/drm/i915/gt/intel_gtt.h
@@ -493,7 +493,7 @@ static inline void i915_vm_put(struct i915_address_space 
*vm)
 
 /**
  * i915_vm_resv_put - Release a reference on the vm's reservation lock
- * @resv: Pointer to a reservation lock obtained from i915_vm_resv_get()
+ * @vm: Pointer to a reservation lock obtained from i915_vm_resv_release()
  */
 static inline void i915_vm_resv_put(struct i915_address_space *vm)
 {
-- 
2.25.1


No virus found
Checked by Hillstone Network AntiVirus


[PATCH] drm/i915:fix kernel-doc trivial warnings

2023-05-24 Thread pengfuyuan
The test robot reports some make warnings.

Fix those warnings:
drivers/gpu/drm/i915/i915_gpu_error.c:2174: warning: Function parameter or 
member 'dump_flags' not described in 'i915_capture_error_state'
drivers/gpu/drm/i915/i915_perf.c:5307: warning: Function parameter or 
member 'i915' not described in 'i915_perf_ioctl_version'
drivers/gpu/drm/i915/i915_active.h:66: warning: Function parameter or 
member 'active' not described in '__i915_active_fence_init'
drivers/gpu/drm/i915/i915_active.h:66: warning: Function parameter or 
member 'fence' not described in '__i915_active_fence_init'
drivers/gpu/drm/i915/i915_active.h:66: warning: Function parameter or 
member 'fn' not described in '__i915_active_fence_init'
drivers/gpu/drm/i915/i915_active.h:89: warning: Function parameter or 
member 'active' not described in 'i915_active_fence_set'
drivers/gpu/drm/i915/i915_active.h:89: warning: Function parameter or 
member 'rq' not described in 'i915_active_fence_set'
drivers/gpu/drm/i915/i915_active.h:102: warning: Function parameter or 
member 'active' not described in 'i915_active_fence_get'
drivers/gpu/drm/i915/i915_active.h:122: warning: Function parameter or 
member 'active' not described in 'i915_active_fence_isset'
drivers/gpu/drm/i915/i915_utils.h:284: warning: Function parameter or 
member 'OP' not described in '__wait_for'
drivers/gpu/drm/i915/i915_utils.h:284: warning: Function parameter or 
member 'COND' not described in '__wait_for'
drivers/gpu/drm/i915/i915_utils.h:284: warning: Function parameter or 
member 'US' not described in '__wait_for'
drivers/gpu/drm/i915/i915_utils.h:284: warning: Function parameter or 
member 'Wmin' not described in '__wait_for'
drivers/gpu/drm/i915/i915_utils.h:284: warning: Function parameter or 
member 'Wmax' not described in '__wait_for'
drivers/gpu/drm/i915/i915_scatterlist.h:164: warning: Function parameter or 
member 'release' not described in 'i915_refct_sgt_ops'
drivers/gpu/drm/i915/i915_scatterlist.h:187: warning: Function parameter or 
member 'rsgt' not described in 'i915_refct_sgt_put'
drivers/gpu/drm/i915/i915_scatterlist.h:198: warning: Function parameter or 
member 'rsgt' not described in 'i915_refct_sgt_get'
drivers/gpu/drm/i915/i915_scatterlist.h:214: warning: Function parameter or 
member 'rsgt' not described in '__i915_refct_sgt_init'
drivers/gpu/drm/i915/i915_vma_resource.h:129: warning: Function parameter 
or member 'wakeref' not described in 'i915_vma_resource'

Reported-by: k2ci 
Signed-off-by: pengfuyuan 
---
 drivers/gpu/drm/i915/i915_active.h   | 14 +++---
 drivers/gpu/drm/i915/i915_gpu_error.c|  1 +
 drivers/gpu/drm/i915/i915_perf.c |  1 +
 drivers/gpu/drm/i915/i915_scatterlist.h  |  9 +
 drivers/gpu/drm/i915/i915_utils.h|  6 ++
 drivers/gpu/drm/i915/i915_vma_resource.h |  1 +
 6 files changed, 21 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_active.h 
b/drivers/gpu/drm/i915/i915_active.h
index 7eb44132183a..77c676ecc263 100644
--- a/drivers/gpu/drm/i915/i915_active.h
+++ b/drivers/gpu/drm/i915/i915_active.h
@@ -49,9 +49,9 @@ void i915_active_noop(struct dma_fence *fence, struct 
dma_fence_cb *cb);
 
 /**
  * __i915_active_fence_init - prepares the activity tracker for use
- * @active - the active tracker
- * @fence - initial fence to track, can be NULL
- * @func - a callback when then the tracker is retired (becomes idle),
+ * @active: the active tracker
+ * @fence: initial fence to track, can be NULL
+ * @fn: a callback when then the tracker is retired (becomes idle),
  * can be NULL
  *
  * i915_active_fence_init() prepares the embedded @active struct for use as
@@ -77,8 +77,8 @@ __i915_active_fence_set(struct i915_active_fence *active,
 
 /**
  * i915_active_fence_set - updates the tracker to watch the current fence
- * @active - the active tracker
- * @rq - the request to watch
+ * @active: the active tracker
+ * @rq: the request to watch
  *
  * i915_active_fence_set() watches the given @rq for completion. While
  * that @rq is busy, the @active reports busy. When that @rq is signaled
@@ -89,7 +89,7 @@ i915_active_fence_set(struct i915_active_fence *active,
  struct i915_request *rq);
 /**
  * i915_active_fence_get - return a reference to the active fence
- * @active - the active tracker
+ * @active: the active tracker
  *
  * i915_active_fence_get() returns a reference to the active fence,
  * or NULL if the active tracker is idle. The reference is obtained under RCU,
@@ -111,7 +111,7 @@ i915_active_fence_get(struct i915_active_fence *active)
 
 /**
  * i915_active_fence_isset - report whether the active tracker is assigned
- * @active - the active tracker
+ * @active: the active tracker
  *
  * i915_active_fence_isset() returns true if the active tracker is currently
  * assigned to a fence. Due to the lazy retiring, that fence may be idle
diff --git a/drivers/gpu/drm

[PATCH] radeon: Fix spelling typo in comment

2022-05-26 Thread pengfuyuan
Fix spelling typo in comment.

Signed-off-by: pengfuyuan 
---
 include/video/radeon.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/video/radeon.h b/include/video/radeon.h
index 005eae19ec09..72f94ccfa725 100644
--- a/include/video/radeon.h
+++ b/include/video/radeon.h
@@ -750,7 +750,7 @@
 #define WAIT_DMA_GUI_IDLE (1 << 9)
 #define WAIT_2D_IDLECLEAN (1 << 16)
 
-/* SURFACE_CNTL bit consants */
+/* SURFACE_CNTL bit constants */
 #define SURF_TRANSLATION_DIS  (1 << 8)
 #define NONSURF_AP0_SWP_16BPP (1 << 20)
 #define NONSURF_AP0_SWP_32BPP (1 << 21)
-- 
2.25.1



[PATCH] drm/amd/display: Remove macro DC_DEFAULT_LOG_MASK

2022-05-13 Thread pengfuyuan
[Why]
The DC_DEFAULT_LOG_MASK macro has not been used for a long time, so remove it.

Signed-off-by: pengfuyuan 
---
 .../drm/amd/display/include/logger_types.h| 33 ---
 1 file changed, 33 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h 
b/drivers/gpu/drm/amd/display/include/logger_types.h
index f093b49c5e6e..1b38cfc41718 100644
--- a/drivers/gpu/drm/amd/display/include/logger_types.h
+++ b/drivers/gpu/drm/amd/display/include/logger_types.h
@@ -131,37 +131,4 @@ enum dc_log_type {
 #define DC_MIN_LOG_MASK ((1 << LOG_ERROR) | \
(1 << LOG_DETECTION_EDID_PARSER))
 
-#define DC_DEFAULT_LOG_MASK ((1ULL << LOG_ERROR) | \
-   (1ULL << LOG_WARNING) | \
-   (1ULL << LOG_EVENT_MODE_SET) | \
-   (1ULL << LOG_EVENT_DETECTION) | \
-   (1ULL << LOG_EVENT_LINK_TRAINING) | \
-   (1ULL << LOG_EVENT_LINK_LOSS) | \
-   (1ULL << LOG_EVENT_UNDERFLOW) | \
-   (1ULL << LOG_RESOURCE) | \
-   (1ULL << LOG_FEATURE_OVERRIDE) | \
-   (1ULL << LOG_DETECTION_EDID_PARSER) | \
-   (1ULL << LOG_DC) | \
-   (1ULL << LOG_HW_HOTPLUG) | \
-   (1ULL << LOG_HW_SET_MODE) | \
-   (1ULL << LOG_HW_RESUME_S3) | \
-   (1ULL << LOG_HW_HPD_IRQ) | \
-   (1ULL << LOG_SYNC) | \
-   (1ULL << LOG_BANDWIDTH_VALIDATION) | \
-   (1ULL << LOG_MST) | \
-   (1ULL << LOG_DETECTION_DP_CAPS) | \
-   (1ULL << LOG_BACKLIGHT)) | \
-   (1ULL << LOG_I2C_AUX) | \
-   (1ULL << LOG_IF_TRACE) | \
-   (1ULL << LOG_HDMI_FRL) | \
-   (1ULL << LOG_SCALER) | \
-   (1ULL << LOG_DTN) /* | \
-   (1ULL << LOG_DEBUG) | \
-   (1ULL << LOG_BIOS) | \
-   (1ULL << LOG_SURFACE) | \
-   (1ULL << LOG_DML) | \
-   (1ULL << LOG_HW_LINK_TRAINING) | \
-   (1ULL << LOG_HW_AUDIO)| \
-   (1ULL << LOG_BANDWIDTH_CALCS)*/
-
 #endif /* __DAL_LOGGER_TYPES_H__ */
-- 
2.25.1



[PATCH] drm/amd/display: Remove macro DC_DEFAULT_LOG_MASK

2022-05-12 Thread pengfuyuan
[Why & How]
The DC_DEFAULT_LOG_MASK macro has not been used for a long time, so remove it.

Signed-off-by: pengfuyuan 
---
 .../drm/amd/display/include/logger_types.h| 34 ---
 1 file changed, 34 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h 
b/drivers/gpu/drm/amd/display/include/logger_types.h
index f093b49c5e6e..a31d7c959f2c 100644
--- a/drivers/gpu/drm/amd/display/include/logger_types.h
+++ b/drivers/gpu/drm/amd/display/include/logger_types.h
@@ -131,37 +131,3 @@ enum dc_log_type {
 #define DC_MIN_LOG_MASK ((1 << LOG_ERROR) | \
(1 << LOG_DETECTION_EDID_PARSER))
 
-#define DC_DEFAULT_LOG_MASK ((1ULL << LOG_ERROR) | \
-   (1ULL << LOG_WARNING) | \
-   (1ULL << LOG_EVENT_MODE_SET) | \
-   (1ULL << LOG_EVENT_DETECTION) | \
-   (1ULL << LOG_EVENT_LINK_TRAINING) | \
-   (1ULL << LOG_EVENT_LINK_LOSS) | \
-   (1ULL << LOG_EVENT_UNDERFLOW) | \
-   (1ULL << LOG_RESOURCE) | \
-   (1ULL << LOG_FEATURE_OVERRIDE) | \
-   (1ULL << LOG_DETECTION_EDID_PARSER) | \
-   (1ULL << LOG_DC) | \
-   (1ULL << LOG_HW_HOTPLUG) | \
-   (1ULL << LOG_HW_SET_MODE) | \
-   (1ULL << LOG_HW_RESUME_S3) | \
-   (1ULL << LOG_HW_HPD_IRQ) | \
-   (1ULL << LOG_SYNC) | \
-   (1ULL << LOG_BANDWIDTH_VALIDATION) | \
-   (1ULL << LOG_MST) | \
-   (1ULL << LOG_DETECTION_DP_CAPS) | \
-   (1ULL << LOG_BACKLIGHT)) | \
-   (1ULL << LOG_I2C_AUX) | \
-   (1ULL << LOG_IF_TRACE) | \
-   (1ULL << LOG_HDMI_FRL) | \
-   (1ULL << LOG_SCALER) | \
-   (1ULL << LOG_DTN) /* | \
-   (1ULL << LOG_DEBUG) | \
-   (1ULL << LOG_BIOS) | \
-   (1ULL << LOG_SURFACE) | \
-   (1ULL << LOG_DML) | \
-   (1ULL << LOG_HW_LINK_TRAINING) | \
-   (1ULL << LOG_HW_AUDIO)| \
-   (1ULL << LOG_BANDWIDTH_CALCS)*/
-
-#endif /* __DAL_LOGGER_TYPES_H__ */
-- 
2.25.1



[PATCH] gpu/drm/radeon: Fix spelling typo in comments

2022-05-02 Thread pengfuyuan
Fix spelling typo in comments.

Signed-off-by: pengfuyuan 
---
 drivers/gpu/drm/radeon/atombios.h | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atombios.h 
b/drivers/gpu/drm/radeon/atombios.h
index bd5dc09e860f..da35a970fcc0 100644
--- a/drivers/gpu/drm/radeon/atombios.h
+++ b/drivers/gpu/drm/radeon/atombios.h
@@ -3599,7 +3599,7 @@ typedef struct  _ATOM_LCD_RTS_RECORD
   UCHAR ucRTSValue;
 }ATOM_LCD_RTS_RECORD;
 
-//!! If the record below exits, it shoud always be the first record for easy 
use in command table!!! 
+//!! If the record below exists, it should always be the first record for easy 
use in command table!!!
 // The record below is only used when LVDS_Info is present. From 
ATOM_LVDS_INFO_V12, use ucLCDPanel_SpecialHandlingCap instead.
 typedef struct  _ATOM_LCD_MODE_CONTROL_CAP
 {
@@ -3823,7 +3823,7 @@ typedef struct _ATOM_DPCD_INFO
 // Note1: This table is filled by SetBiosReservationStartInFB in 
CoreCommSubs.asm
 //at running time.   
 // note2: From RV770, the memory is more than 32bit addressable, so we will 
change 
-//ucTableFormatRevision=1,ucTableContentRevision=4, the strcuture 
remains 
+//ucTableFormatRevision=1,ucTableContentRevision=4, the structure 
remains
 //exactly same as 1.1 and 1.2 (1.3 is never in use), but 
ulStartAddrUsedByFirmware 
 //(in offset to start of memory address) is KB aligned instead of byte 
aligend.
 
/***/
  
@@ -3858,7 +3858,7 @@ typedef struct _ATOM_VRAM_USAGE_BY_FIRMWARE
   ATOM_FIRMWARE_VRAM_RESERVE_INFO  
asFirmwareVramReserveInfo[ATOM_MAX_FIRMWARE_VRAM_USAGE_INFO];
 }ATOM_VRAM_USAGE_BY_FIRMWARE;
 
-// change verion to 1.5, when allow driver to allocate the vram area for 
command table access. 
+// change version to 1.5, when allow driver to allocate the vram area for 
command table access.
 typedef struct _ATOM_FIRMWARE_VRAM_RESERVE_INFO_V1_5
 {
   ULONG   ulStartAddrUsedByFirmware;
@@ -5973,7 +5973,7 @@ typedef struct _ATOM_ASIC_INTERNAL_SS_INFO_V3
 #define CLEAR_ATOM_S7_DOS_8BIT_DAC_EN ((ATOM_DOS_MODE_INFO_DEF << 8 
)|ATOM_S7_DOS_8BIT_DAC_EN_SHIFT | ATOM_FLAG_CLEAR )
 
 // 
-//Portion II: Definitinos only used in Driver
+//Portion II: Definitions only used in Driver
 //
 
 // Macros used by driver
@@ -7162,7 +7162,7 @@ typedef struct _DP_ENCODER_SERVICE_PARAMETERS
 
 // ucAction
 #define ATOM_DP_ACTION_GET_SINK_TYPE   
0x01
-/* obselete */
+/* obsolete */
 #define ATOM_DP_ACTION_TRAINING_START  
0x02
 #define ATOM_DP_ACTION_TRAINING_COMPLETE   
0x03
 #define ATOM_DP_ACTION_TRAINING_PATTERN_SEL0x04
-- 
2.25.1



[PATCH] gpu/drm/radeon: Fix spelling typo in comments

2022-04-28 Thread pengfuyuan
Fix spelling typo in comments.

Signed-off-by: pengfuyuan 
---
 drivers/gpu/drm/radeon/atombios.h | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atombios.h 
b/drivers/gpu/drm/radeon/atombios.h
index bd5dc09e860f..e00d6adf7262 100644
--- a/drivers/gpu/drm/radeon/atombios.h
+++ b/drivers/gpu/drm/radeon/atombios.h
@@ -3599,7 +3599,7 @@ typedef struct  _ATOM_LCD_RTS_RECORD
   UCHAR ucRTSValue;
 }ATOM_LCD_RTS_RECORD;
 
-//!! If the record below exits, it shoud always be the first record for easy 
use in command table!!! 
+//!! If the record below exits, it should always be the first record for easy 
use in command table!!!
 // The record below is only used when LVDS_Info is present. From 
ATOM_LVDS_INFO_V12, use ucLCDPanel_SpecialHandlingCap instead.
 typedef struct  _ATOM_LCD_MODE_CONTROL_CAP
 {
@@ -3823,7 +3823,7 @@ typedef struct _ATOM_DPCD_INFO
 // Note1: This table is filled by SetBiosReservationStartInFB in 
CoreCommSubs.asm
 //at running time.   
 // note2: From RV770, the memory is more than 32bit addressable, so we will 
change 
-//ucTableFormatRevision=1,ucTableContentRevision=4, the strcuture 
remains 
+//ucTableFormatRevision=1,ucTableContentRevision=4, the structure 
remains
 //exactly same as 1.1 and 1.2 (1.3 is never in use), but 
ulStartAddrUsedByFirmware 
 //(in offset to start of memory address) is KB aligned instead of byte 
aligend.
 
/***/
  
@@ -3858,7 +3858,7 @@ typedef struct _ATOM_VRAM_USAGE_BY_FIRMWARE
   ATOM_FIRMWARE_VRAM_RESERVE_INFO  
asFirmwareVramReserveInfo[ATOM_MAX_FIRMWARE_VRAM_USAGE_INFO];
 }ATOM_VRAM_USAGE_BY_FIRMWARE;
 
-// change verion to 1.5, when allow driver to allocate the vram area for 
command table access. 
+// change version to 1.5, when allow driver to allocate the vram area for 
command table access.
 typedef struct _ATOM_FIRMWARE_VRAM_RESERVE_INFO_V1_5
 {
   ULONG   ulStartAddrUsedByFirmware;
@@ -5973,7 +5973,7 @@ typedef struct _ATOM_ASIC_INTERNAL_SS_INFO_V3
 #define CLEAR_ATOM_S7_DOS_8BIT_DAC_EN ((ATOM_DOS_MODE_INFO_DEF << 8 
)|ATOM_S7_DOS_8BIT_DAC_EN_SHIFT | ATOM_FLAG_CLEAR )
 
 // 
-//Portion II: Definitinos only used in Driver
+//Portion II: Definitions only used in Driver
 //
 
 // Macros used by driver
@@ -7162,7 +7162,7 @@ typedef struct _DP_ENCODER_SERVICE_PARAMETERS
 
 // ucAction
 #define ATOM_DP_ACTION_GET_SINK_TYPE   
0x01
-/* obselete */
+/* obsolete */
 #define ATOM_DP_ACTION_TRAINING_START  
0x02
 #define ATOM_DP_ACTION_TRAINING_COMPLETE   
0x03
 #define ATOM_DP_ACTION_TRAINING_PATTERN_SEL0x04
-- 
2.25.1



[PATCH] drm/arm/mali-dp: Fix spelling typo in comment

2022-04-27 Thread pengfuyuan
Fix spelling typo in comment.

Signed-off-by: pengfuyuan 
---
 drivers/gpu/drm/arm/malidp_regs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/arm/malidp_regs.h 
b/drivers/gpu/drm/arm/malidp_regs.h
index 514c50dcb74d..59f63cc2b304 100644
--- a/drivers/gpu/drm/arm/malidp_regs.h
+++ b/drivers/gpu/drm/arm/malidp_regs.h
@@ -145,7 +145,7 @@
 #define MALIDP_SE_COEFFTAB_DATA_MASK   0x3fff
 #define MALIDP_SE_SET_COEFFTAB_DATA(x) \
((x) & MALIDP_SE_COEFFTAB_DATA_MASK)
-/* Enhance coeffents reigster offset */
+/* Enhance coeffents register offset */
 #define MALIDP_SE_IMAGE_ENH0x3C
 /* ENH_LIMITS offset 0x0 */
 #define MALIDP_SE_ENH_LOW_LEVEL24
-- 
2.25.1



[PATCH] drm/arm/mali-dp: Fix spelling typo in comment

2022-04-27 Thread pengfuyuan
Fix spelling typo in comment.

Signed-off-by: pengfuyuan 
---
 drivers/gpu/drm/arm/malidp_regs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/arm/malidp_regs.h 
b/drivers/gpu/drm/arm/malidp_regs.h
index 514c50dcb74d..3bc16db70ddb 100644
--- a/drivers/gpu/drm/arm/malidp_regs.h
+++ b/drivers/gpu/drm/arm/malidp_regs.h
@@ -145,7 +145,7 @@
 #define MALIDP_SE_COEFFTAB_DATA_MASK   0x3fff
 #define MALIDP_SE_SET_COEFFTAB_DATA(x) \
((x) & MALIDP_SE_COEFFTAB_DATA_MASK)
-/* Enhance coeffents reigster offset */
+/* Enhance coefficients register offset */
 #define MALIDP_SE_IMAGE_ENH0x3C
 /* ENH_LIMITS offset 0x0 */
 #define MALIDP_SE_ENH_LOW_LEVEL24
-- 
2.25.1