Re: [0/5] video-SMSC UFX: Adjustments for five function implementations

[SF Markus Elfring]

>>   Delete an error message for a failed memory allocation in two functions
> 
> This patch removes the information about the device for which the allocation 
> fails.

Should a Linux allocation failure report be sufficient here?


>>   Less checks in ufx_usb_probe() after error detection
> 
> This patch depends on the earlier patch (which is not being merged)

Partly, yes.


> so please re-base it if you want it to be applied.

Would you dare to pick another change possibility up from a patch hunk?


>>   Adjust three checks for null pointers
> 
> This patch contains unrelated change ({} braces addition) which should be 
> dropped.

I presented such an update approach so that warnings from the script 
“checkpatch.pl”
will be fixed together.

Regards,
Markus
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/5] video-SMSC UFX: Adjustments for five function implementations

[Bartlomiej Zolnierkiewicz]

On Saturday, November 25, 2017 09:42:57 PM SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sat, 25 Nov 2017 21:38:42 +0100
> 
> A few update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (5):
>   Delete an error message for a failed memory allocation in two functions

This patch removes the information about the device for which the allocation
fails.

>   Less checks in ufx_usb_probe() after error detection

This patch depends on the earlier patch (which is not being merged) so please
re-base it if you want it to be applied.

>   Return an error code only as a constant in ufx_realloc_framebuffer()

ditto

>   Improve a size determination in two functions

Patch queued for 4.16, thanks.

>   Adjust three checks for null pointers

This patch contains unrelated change ({} braces addition) which should be
dropped.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 0/5] video-SMSC UFX: Adjustments for five function implementations

[SF Markus Elfring]

From: Markus Elfring 
Date: Sat, 25 Nov 2017 21:38:42 +0100

A few update suggestions were taken into account
from static source code analysis.

Markus Elfring (5):
  Delete an error message for a failed memory allocation in two functions
  Less checks in ufx_usb_probe() after error detection
  Return an error code only as a constant in ufx_realloc_framebuffer()
  Improve a size determination in two functions
  Adjust three checks for null pointers

 drivers/video/fbdev/smscufx.c | 80 ---
 1 file changed, 29 insertions(+), 51 deletions(-)

-- 
2.15.0


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel