[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #13 from Florian Mickler 2012-02-11 07:52:31 PST --- A patch referencing this bug report has been merged in Linux v3.3-rc3: commit de47a9cd62771e3e78954d855d2304fbad4c5a44 Author: Dave Airlie Date: Thu Feb 2 15:25:16 2012 + drm/radeon: fix use after free in ATRM bios reading code. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #13 from Florian Mickler flor...@mickler.org 2012-02-11 07:52:31 PST --- A patch referencing this bug report has been merged in Linux v3.3-rc3: commit de47a9cd62771e3e78954d855d2304fbad4c5a44 Author: Dave Airlie airl...@redhat.com Date: Thu Feb 2 15:25:16 2012 + drm/radeon: fix use after free in ATRM bios reading code. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 mlambda at gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 mlam...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #12 from Dave Airlie 2012-02-02 06:59:30 PST --- arrgh good catch, I'll send a patch with that fix now, thanks for tracking that down. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #11 from mlambda at gmail.com 2012-02-02 06:22:03 PST --- Created attachment 56517 --> https://bugs.freedesktop.org/attachment.cgi?id=56517 dmesg with my patch -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503
--- Comment #10 from mlambda at gmail.com 2012-02-02 06:20:36 PST ---
I just found the solution:
diff -ur a/drivers/gpu/drm/radeon/radeon_atpx_handler.c
b/drivers/gpu/drm/radeon/radeon_atpx_handler.c
--- a/drivers/gpu/drm/radeon/radeon_atpx_handler.c2012-01-31
22:31:54.0 +0100
+++ b/drivers/gpu/drm/radeon/radeon_atpx_handler.c2012-02-02
15:03:32.408629788 +0100
@@ -58,9 +58,12 @@
}
obj = (union acpi_object *)buffer.pointer;
+printk("obj->buffer.length: %i\n", obj->buffer.length);
+printk("len: %i\n", len);
memcpy(bios+offset, obj->buffer.pointer, obj->buffer.length);
+len = obj->buffer.length;
kfree(buffer.pointer);
-return obj->buffer.length;
+return len;
}
bool radeon_atrm_supported(struct pci_dev *pdev)
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #10 from mlam...@gmail.com 2012-02-02 06:20:36 PST --- I just found the solution: diff -ur a/drivers/gpu/drm/radeon/radeon_atpx_handler.c b/drivers/gpu/drm/radeon/radeon_atpx_handler.c --- a/drivers/gpu/drm/radeon/radeon_atpx_handler.c2012-01-31 22:31:54.0 +0100 +++ b/drivers/gpu/drm/radeon/radeon_atpx_handler.c2012-02-02 15:03:32.408629788 +0100 @@ -58,9 +58,12 @@ } obj = (union acpi_object *)buffer.pointer; +printk(obj-buffer.length: %i\n, obj-buffer.length); +printk(len: %i\n, len); memcpy(bios+offset, obj-buffer.pointer, obj-buffer.length); +len = obj-buffer.length; kfree(buffer.pointer); -return obj-buffer.length; +return len; } bool radeon_atrm_supported(struct pci_dev *pdev) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #11 from mlam...@gmail.com 2012-02-02 06:22:03 PST --- Created attachment 56517 -- https://bugs.freedesktop.org/attachment.cgi?id=56517 dmesg with my patch -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #12 from Dave Airlie airl...@freedesktop.org 2012-02-02 06:59:30 PST --- arrgh good catch, I'll send a patch with that fix now, thanks for tracking that down. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #9 from mlambda at gmail.com 2012-02-01 13:40:08 PST --- Created attachment 56474 --> https://bugs.freedesktop.org/attachment.cgi?id=56474 dmesg with debug patch Here's the dmesg output with your debugging patch applied. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #8 from Dave Airlie 2012-02-01 12:49:24 PST --- Created attachment 56468 --> https://bugs.freedesktop.org/attachment.cgi?id=56468 debugging patch this is a debugging patch to apply on top of 3.3-rc2 can you get the dmesg with it applied? thanks. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #7 from mlambda at gmail.com 2012-02-01 10:26:45 PST --- Created attachment 56462 --> https://bugs.freedesktop.org/attachment.cgi?id=56462 dmesg with commit a3f83ab... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #6 from mlambda at gmail.com 2012-02-01 10:26:12 PST --- Created attachment 56461 --> https://bugs.freedesktop.org/attachment.cgi?id=56461 dmesg with commit 211fa4f... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #5 from mlambda at gmail.com 2012-02-01 10:25:18 PST --- Commit a3f83ab1a717c0e6c2f59a4cfdaa10707cc35c55 works, commit 211fa4fc4e13492151e698d92b0dff56b29928ec doesn't. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #4 from Dave Airlie 2012-02-01 09:02:31 PST --- Its most likely one of 211fa4fc4e13492151e698d92b0dff56b29928ec a3f83ab1a717c0e6c2f59a4cfdaa10707cc35c55 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #3 from mlambda at gmail.com 2012-02-01 08:35:41 PST --- Do you mean this option: CONFIG_PCI_QUIRKS=y ? It is enabled in my kernel config. I'm sorry, but I have never bisected a kernel bug before and I don't know the kernel source very well. Are there many changes to radeon_get_bios from 3.2.2 to 3.3-rc2? Maybe you can guess two commits and I can try them... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #2 from Alex Deucher 2012-02-01 08:14:14 PST --- Please make sure pci quirks are enabled in your kernel config. If it still doesn't work with that enabled, can you bisect? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #1 from mlambda at gmail.com 2012-02-01 07:57:27 PST --- Created attachment 56456 --> https://bugs.freedesktop.org/attachment.cgi?id=56456 dmesg with kernel 3.3-rc2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #1 from mlam...@gmail.com 2012-02-01 07:57:27 PST --- Created attachment 56456 -- https://bugs.freedesktop.org/attachment.cgi?id=56456 dmesg with kernel 3.3-rc2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #2 from Alex Deucher ag...@yahoo.com 2012-02-01 08:14:14 PST --- Please make sure pci quirks are enabled in your kernel config. If it still doesn't work with that enabled, can you bisect? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #3 from mlam...@gmail.com 2012-02-01 08:35:41 PST --- Do you mean this option: CONFIG_PCI_QUIRKS=y ? It is enabled in my kernel config. I'm sorry, but I have never bisected a kernel bug before and I don't know the kernel source very well. Are there many changes to radeon_get_bios from 3.2.2 to 3.3-rc2? Maybe you can guess two commits and I can try them... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #4 from Dave Airlie airl...@freedesktop.org 2012-02-01 09:02:31 PST --- Its most likely one of 211fa4fc4e13492151e698d92b0dff56b29928ec a3f83ab1a717c0e6c2f59a4cfdaa10707cc35c55 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #5 from mlam...@gmail.com 2012-02-01 10:25:18 PST --- Commit a3f83ab1a717c0e6c2f59a4cfdaa10707cc35c55 works, commit 211fa4fc4e13492151e698d92b0dff56b29928ec doesn't. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #6 from mlam...@gmail.com 2012-02-01 10:26:12 PST --- Created attachment 56461 -- https://bugs.freedesktop.org/attachment.cgi?id=56461 dmesg with commit 211fa4f... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #7 from mlam...@gmail.com 2012-02-01 10:26:45 PST --- Created attachment 56462 -- https://bugs.freedesktop.org/attachment.cgi?id=56462 dmesg with commit a3f83ab... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #8 from Dave Airlie airl...@freedesktop.org 2012-02-01 12:49:24 PST --- Created attachment 56468 -- https://bugs.freedesktop.org/attachment.cgi?id=56468 debugging patch this is a debugging patch to apply on top of 3.3-rc2 can you get the dmesg with it applied? thanks. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 45503] [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS ROM
https://bugs.freedesktop.org/show_bug.cgi?id=45503 --- Comment #9 from mlam...@gmail.com 2012-02-01 13:40:08 PST --- Created attachment 56474 -- https://bugs.freedesktop.org/attachment.cgi?id=56474 dmesg with debug patch Here's the dmesg output with your debugging patch applied. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
