[Bug 73931] rmmod radeon and kernel crash
https://bugzilla.kernel.org/show_bug.cgi?id=73931 Mateusz Lenik (m...@mlen.pl) changed: What|Removed |Added CC||m...@mlen.pl --- Comment #11 from Mateusz Lenik (m...@mlen.pl) --- Same issue for amdgpu after unbind (not sure if this should be a separate bug): rook ~ ➤ ls -l /sys/class/hwmon/hwmon1/device lrwxrwxrwx 1 root root 0 cze 8 12:32 /sys/class/hwmon/hwmon1/device -> ../../../:03:00.0 rook ~ ➤ cat /sys/class/hwmon/hwmon1/fan1_input [1]9145 killed cat /sys/class/hwmon/hwmon1/fan1_input Reading fan1_input causes an OOPS: [ 590.507564] BUG: unable to handle kernel NULL pointer dereference at 00b8 [ 590.507584] IP: amdgpu_hwmon_get_fan1_input+0x33/0x84 [ 590.507587] PGD 0 P4D 0 [ 590.507593] Oops: [#4] PREEMPT SMP PTI [ 590.507597] Modules linked in: [ 590.507610] CPU: 39 PID: 9222 Comm: cat Tainted: G D 4.16.14-gentoo #3 [ 590.507613] Hardware name: ASUSTeK COMPUTER INC. Z10PE-D16 WS/Z10PE-D16 WS, BIOS 3407 03/10/2017 [ 590.507617] RIP: 0010:amdgpu_hwmon_get_fan1_input+0x33/0x84 [ 590.507620] RSP: 0018:97790d2dfd68 EFLAGS: 00010246 [ 590.507624] RAX: RBX: 9147b5cd3000 RCX: 9137b5428ac8 [ 590.507627] RDX: 9137b5aa RSI: bbb3e1c0 RDI: 9137b55f7008 [ 590.507630] RBP: fffb R08: 0001 R09: [ 590.507633] R10: 9137af38d400 R11: R12: bb30d000 [ 590.507636] R13: 9147b590d400 R14: 91476a16db00 R15: 0001 [ 590.507639] FS: 7f3838cbe540() GS:9147bf40() knlGS: [ 590.507641] CS: 0010 DS: ES: CR0: 80050033 [ 590.507643] CR2: 00b8 CR3: 002023776005 CR4: 003606e0 [ 590.507645] DR0: DR1: DR2: [ 590.507647] DR3: DR6: fffe0ff0 DR7: 0400 [ 590.507649] Call Trace: [ 590.507660] dev_attr_show+0x23/0x44 [ 590.507668] sysfs_kf_seq_show+0x7f/0xce [ 590.507676] seq_read+0x1c1/0x3d1 [ 590.507687] __vfs_read+0x33/0xcc [ 590.507693] vfs_read+0x9a/0xcf [ 590.507696] SyS_read+0x5f/0xa3 [ 590.507703] do_syscall_64+0x79/0x88 [ 590.507711] entry_SYSCALL_64_after_hwframe+0x3d/0xa2 [ 590.507715] RIP: 0033:0x7f38387f8b75 [ 590.507718] RSP: 002b:72570970 EFLAGS: 0246 ORIG_RAX: [ 590.507721] RAX: ffda RBX: 0002 RCX: 7f38387f8b75 [ 590.507723] RDX: 0002 RSI: 7f3838cd RDI: 0003 [ 590.507725] RBP: 0002 R08: R09: [ 590.507727] R10: 039b R11: 0246 R12: 7f3838cd [ 590.507729] R13: 0003 R14: 7f3838cd000f R15: 0002 [ 590.507738] Code: d3 48 83 ec 10 48 8b 97 18 01 00 00 65 48 8b 04 25 28 00 00 00 48 89 44 24 08 31 c0 c7 44 24 04 00 00 00 00 48 8b 82 08 49 00 00 <48> 8b 80 b8 00 00 00 48 85 c0 74 15 48 8b ba f8 48 00 00 48 8d [ 590.507821] RIP: amdgpu_hwmon_get_fan1_input+0x33/0x84 RSP: 97790d2dfd68 [ 590.507824] CR2: 00b8 [ 590.507830] ---[ end trace eaed7563e433ab4e ]--- -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 73931] rmmod radeon and kernel crash
https://bugzilla.kernel.org/show_bug.cgi?id=73931 --- Comment #10 from Pali Roh?r --- @Alex Deucher: ping -- You are receiving this mail because: You are watching the assignee of the bug.
[Bug 73931] rmmod radeon and kernel crash
https://bugzilla.kernel.org/show_bug.cgi?id=73931 --- Comment #9 from Pali Roh?r --- Any idea about what to do with last two NULL pointer dereference in radeon_driver_open_kms? -- You are receiving this mail because: You are watching the assignee of the bug.
[Bug 73931] rmmod radeon and kernel crash
https://bugzilla.kernel.org/show_bug.cgi?id=73931 --- Comment #8 from Pali Roh?r --- Created attachment 132291 --> https://bugzilla.kernel.org/attachment.cgi?id=132291&action=edit dmesg plymouth log Similar/same problem happends if I start plymouth splash screen (which using intel fb) and then I load radeon module. -- You are receiving this mail because: You are watching the assignee of the bug.
[Bug 73931] rmmod radeon and kernel crash
https://bugzilla.kernel.org/show_bug.cgi?id=73931 --- Comment #7 from Pali Roh?r --- Created attachment 132281 --> https://bugzilla.kernel.org/attachment.cgi?id=132281&action=edit pstore log Ok, now kernel does not crash after loading radeon module again. I modprobed & rmmoded it more times, there was no problem But after I started Xserver (when radeon module was loaded), I got another kernel crash. See output from efi pstore. -- You are receiving this mail because: You are watching the assignee of the bug.
[Bug 73931] rmmod radeon and kernel crash
https://bugzilla.kernel.org/show_bug.cgi?id=73931 Alex Deucher changed: What|Removed |Added Attachment #132231|0 |1 is obsolete|| --- Comment #6 from Alex Deucher --- Created attachment 132261 --> https://bugzilla.kernel.org/attachment.cgi?id=132261&action=edit possible fix v2 Updated patch. -- You are receiving this mail because: You are watching the assignee of the bug.
[Bug 73931] rmmod radeon and kernel crash
https://bugzilla.kernel.org/show_bug.cgi?id=73931 --- Comment #5 from Pali Roh?r --- Created attachment 132251 --> https://bugzilla.kernel.org/attachment.cgi?id=132251&action=edit pstore log Now I found pstore and its efi backend... I modprobed efi-pstore before rmmoding radeon and dmesg logs were stored into efi after kernel crash. So I belive that something usefull is there for you. Attachment generated by: $ cd /sys/fs/pstore/; cat `ls -r *1; ls -r *2` -- You are receiving this mail because: You are watching the assignee of the bug.
[Bug 73931] rmmod radeon and kernel crash
https://bugzilla.kernel.org/show_bug.cgi?id=73931 --- Comment #4 from Pali Roh?r --- No does not help, kernel still crashing. But now I cannot provide syslog output, because userspace rsyslog daemon does not read log from kernel and write data to disk.. Plus output on framebuffer screen is very quickly overwritten, so I cannot capture it. -- You are receiving this mail because: You are watching the assignee of the bug.
[Bug 73931] rmmod radeon and kernel crash
https://bugzilla.kernel.org/show_bug.cgi?id=73931 --- Comment #3 from Alex Deucher --- Created attachment 132231 --> https://bugzilla.kernel.org/attachment.cgi?id=132231&action=edit possible fix Does this help in the second case? -- You are receiving this mail because: You are watching the assignee of the bug.
[Bug 73931] rmmod radeon and kernel crash
https://bugzilla.kernel.org/show_bug.cgi?id=73931 --- Comment #2 from Pali Roh?r --- Created attachment 132221 --> https://bugzilla.kernel.org/attachment.cgi?id=132221&action=edit syslog output after modprobe radeon Yes, your patch fixing original problem. Maybe this is candidate for stable releases. Patch tested on 3.14 and system working fine after rmmoding radeon module, no crash after calling: find /sys But now there is another new kernel crash. When I modprobe radeon module again (after previous successful rmmod), kernel crash. See syslog output in attachment. -- You are receiving this mail because: You are watching the assignee of the bug.
[Bug 73931] rmmod radeon and kernel crash
https://bugzilla.kernel.org/show_bug.cgi?id=73931 Alex Deucher changed: What|Removed |Added CC||alexdeucher at gmail.com --- Comment #1 from Alex Deucher --- Created attachment 132201 --> https://bugzilla.kernel.org/attachment.cgi?id=132201&action=edit possible fix Does the attached patch help? -- You are receiving this mail because: You are watching the assignee of the bug.