[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #20 from Kamil Páral  ---
Glad that it helped :) I have created an RFE for xrandr to ignore case for
scaling mode values - bug 93624.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #19 from Oleg  ---
Hi, Kamil. Indeed it worked as you suggested. I feel dumb now. But I can swear
I've tried it that way too. Although some time ago. Maybe even before Alex
included this patch?
Anyway thanks man you saved me. If we're ever to meet, the beer's on me :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #18 from Kamil Páral  ---
Hi Oleg, I checked and this still works for me (Radeon R9 270, Fedora 23,
kernel-4.2.8-300.fc23.x86_64, mesa-dri-drivers-11.1.0-1.20151218.fc23.x86_64,
DisplayPort cable). Please note that you need to specify the scaling exactly as
printed out on "supported:" line, i.e. with the first letter in upper case. It
is not case insensitive, and if you have the case wrong, the scaling mode is
ignored. Maybe that's the issue?
(It would be nice to have this case insensitive, because it has bitten me in
the past as well. Maybe someone could create an RFE ticket for this?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #17 from Oleg  ---
Maybe I'm late to the party, but this doesn't seem to work for me no matter how
I try.
My video card is Radeon 7770, kernel is 4.2.0 (it didn't work with any older
ones either), Ubuntu 15.10 running open source driver stack, 22" monitor
1680x1050 native resolution which is 16:10 I believe.

Even if set "scaling mode" to "full aspect" (or "center" for that matter) and
then switch to a non-native resolution the image is still stretched to full
screen without respect to the aspect ratio.
I've tried to change the connection (I'm using a DVI -> HDMI cable, tried a
straight DVI -> DVI one), the monitor, and even the distro (tested with the
latest Fedora Live), to no avail. It seems that the setting is simply ignored.

Can anybody kindly suggest how I should go about it eg debug it somehow?
Overall I have a gut feeling there's something that needs to be tweaked besides
the xrandr setting, but have no idea what.

Here's what seems to be an identical complaint:
https://bbs.archlinux.org/viewtopic.php?id=192423

Thanks in advance.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

Alex Deucher  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #16 from Kamil Páral  ---
I believe this can be closed. It seems to work well on my kernel 3.18. Thanks,
Alex.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #15 from Alex Deucher  ---
I've added the patch to my 3.17 queue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #14 from Kamil P?ral  ---
(In reply to comment #13)
> Created attachment 102565 [details] [review]
> better patch
> 
> This version handles the no modes case properly.

I re-tried it, still works for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

Alex Deucher  changed:

   What|Removed |Added

 Attachment #102491|0   |1
is obsolete||

--- Comment #13 from Alex Deucher  ---
Created attachment 102565
  --> https://bugs.freedesktop.org/attachment.cgi?id=102565=edit
better patch

This version handles the no modes case properly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #12 from Alex Deucher  ---
(In reply to comment #11)
> Alex, this is great! It works perfectly for me. I tried all available modes.
> Thanks a lot.
> 
> A follow up question: Is this setting supposed to be reset on reboot or
> remembered? It is reset for me. If one would like to have this remembered,
> in which tool should one ask for such a feature (kernel, X, DE, somewhere
> else)? Thanks.

It's up to the desktop environment.  It should be saved as part of the display
configuration (e.g., along with display modes, orientations, etc., etc.).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #11 from Kamil P?ral  ---
Alex, this is great! It works perfectly for me. I tried all available modes.
Thanks a lot.

A follow up question: Is this setting supposed to be reset on reboot or
remembered? It is reset for me. If one would like to have this remembered, in
which tool should one ask for such a feature (kernel, X, DE, somewhere else)?
Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

Alex Deucher  changed:

   What|Removed |Added

 Attachment #102216|0   |1
is obsolete||

--- Comment #10 from Alex Deucher  ---
Created attachment 102491
  --> https://bugs.freedesktop.org/attachment.cgi?id=102491=edit
working patch

This patch works for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #9 from Kamil P?ral  ---
OK, once I learned how to work with spec files properly, I compiled it with the
patch applied. The scaling mode is now visible for external displays (yay!) and
defaults to None. However, when I try to change it (I tried to set it to
Center), my monitor goes black and I receive "no signal detected" error
message. I had to restart to restore the picture. This happens over both DVI
and DP.

The journal says:

Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): EDID vendor "BNQ",
prod id 32785
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Using hsync ranges
from config file
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Using vrefresh ranges
from config file
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Printing DDC gathered
Modelines:
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1920x1200"x0.0  154.00  1920 1968 2000 2080  1200 1203 1209 1235 +hsync -vsync
(74.0 kHz eP)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"720x480"x0.0   27.00  720 736 798 858  480 489 495 525 -hsync -vsync (31.5 kHz
e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1280x720"x0.0   74.25  1280 1390 1430 1650  720 725 730 750 +hsync +vsync
(45.0 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"720x576"x0.0   27.00  720 732 796 864  576 581 586 625 -hsync -vsync (31.2 kHz
e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"800x600"x0.0   40.00  800 840 968 1056  600 601 605 628 +hsync +vsync (37.9
kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"640x480"x0.0   31.50  640 656 720 840  480 481 484 500 -hsync -vsync (37.5 kHz
e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"640x480"x0.0   25.18  640 656 752 800  480 490 492 525 -hsync -vsync (31.5 kHz
e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"720x400"x0.0   28.32  720 738 846 900  400 412 414 449 -hsync +vsync (31.5 kHz
e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1280x1024"x0.0  135.00  1280 1296 1440 1688  1024 1025 1028 1066 +hsync +vsync
(80.0 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1024x768"x0.0   78.75  1024 1040 1136 1312  768 769 772 800 +hsync +vsync
(60.0 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1024x768"x0.0   65.00  1024 1048 1184 1344  768 771 777 806 -hsync -vsync
(48.4 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"832x624"x0.0   57.28  832 864 928 1152  624 625 628 667 -hsync -vsync (49.7
kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"800x600"x0.0   49.50  800 816 896 1056  600 601 604 625 +hsync +vsync (46.9
kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1152x864"x0.0  108.00  1152 1216 1344 1600  864 865 868 900 +hsync +vsync
(67.5 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1024x576"x60.0   46.99  1024 1064 1168 1312  576 577 580 597 -hsync +vsync
(35.8 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1280x800"x0.0   83.50  1280 1352 1480 1680  800 803 809 831 -hsync +vsync
(49.7 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1280x1024"x0.0  108.00  1280 1328 1440 1688  1024 1025 1028 1066 +hsync +vsync
(64.0 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1440x900"x0.0  106.50  1440 1520 1672 1904  900 903 909 934 -hsync +vsync
(55.9 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1920x1080"x60.0  172.80  1920 2040 2248 2576  1080 1081 1084 1118 -hsync
+vsync (67.1 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1680x1050"x0.0  146.25  1680 1784 1960 2240  1050 1053 1059 1089 -hsync +vsync
(65.3 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1600x1200"x0.0  162.00  1600 1664 1856 2160  1200 1201 1204 1250 +hsync +vsync
(75.0 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1920x1080"x0.0   74.25  1920 2558 2602 2750  1080 1084 1089 1125 +hsync +vsync
(27.0 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1920x1080i"x0.0   74.25  1920 2008 2052 2200  1080 1084 1094 1125 interlace
+hsync +vsync (33.8 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1920x1080i"x0.0   74.25  1920 2448 2492 2640  1080 1084 1094 1125 interlace
+hsync +vsync (28.1 kHz e)
Jul 08 03:02:40 rawhide gdm-Xorg-:0[846]: (II) RADEON(0): Modeline
"1280x720"x0.0   74.25  1280 1720 1760 1980  720 725 730 750 +hsync +vsync
(37.5 kHz e)
Jul 08 03:02:40 rawhide kernel: [drm:drm_calc_timestamping_constants] *ERROR*
crtc 14: Can't calculate constants, dotclock = 0!

The last line seems important.

-- 
You are receiving this mail because:
You are the 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #8 from Kamil P?ral  ---
Yes, you seem to be right. I put the patch into the spec file, but it probably
didn't apply. I'm trying to find out why.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #7 from Alex Deucher  ---
(In reply to comment #6)
> I tried this on a Fedora Rawhide, I tried to rebuild the provided
> 3.16.0-0.rc4 kernel with the patch. After reboot, I still don't see scaling
> mode in xrandr properties, so no, it doesn't work for me. But maybe I did
> something wrong somewhere, that's very possible.

I suspect you aren't using the patch version of the driver.  You should see the
property.  drm_object_attach_property() is what attaches the property to the
connector.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #6 from Kamil P?ral  ---
I tried this on a Fedora Rawhide, I tried to rebuild the provided 3.16.0-0.rc4
kernel with the patch. After reboot, I still don't see scaling mode in xrandr
properties, so no, it doesn't work for me. But maybe I did something wrong
somewhere, that's very possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #5 from Alex Deucher  ---
(In reply to comment #4)
> 
> Thanks a lot! I'm not able to finalize this patch, but I hope someone more
> capable will (I can blog about it to get some attention).

Does the patch work?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #4 from Kamil P?ral  ---
(In reply to comment #2)
> A deeper question is, why run non-native modes to begin with?  Whether it's
> the GPU or the monitor, it's always going to end up scaled.  Why do you want
> to run 1920x1080 when you can run 1920x1200?

I see several reasons:

1) Games do not support all resolutions. All old games (think Diablo or
Starcraft) have a) fixed 4:3 ratio b) a fixed resolution around 800x600. Newer
games (think Warcraft 3) didn't have fixed resolutions, but still had fixed
aspect ratio. But even modern games sometimes do this - when Witcher 2 (AAA
game from 2012) came out, it supported only 16:9 resolutions, but none of 16:10
resolutions (they fixed in afterwards with a patch). Moreover, there is often a
resolution cap hardcoded in the game which is the maximum resolution the
developers tested the game with. So if you buy 1440p or 2160p display today,
you might be surprised how many games don't allow your native resolution to be
selected, for no apparent reason.

2) Performance reasons. If your system is not able to run modern games in your
native resolution even with low details, you simply need to use a lower one,
there is no other choice. Lowering your resolution is the number one approach
how to make the game faster. It is very common.

3) Some people might prefer to run in a lower resolution to make things
"bigger". This might not be too common and probably not apply to games, rather
desktop. But I personally know some older people with a bit worse eyesight, who
prefer blurry but bigger text and widgets, rather than small and sharp.


(In reply to comment #1)
> I'm not sure when I'll have time to implement this, but just about
> everything you need is already in place.  The attached patch should get you
> started and may even work...

Thanks a lot! I'm not able to finalize this patch, but I hope someone more
capable will (I can blog about it to get some attention).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #3 from Henri Verbeet  ---
Some of the games this applies to only know 640x480 and 800x600, and perhaps
1024x768.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #2 from Alex Deucher  ---
A deeper question is, why run non-native modes to begin with?  Whether it's the
GPU or the monitor, it's always going to end up scaled.  Why do you want to run
1920x1080 when you can run 1920x1200?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 80868] Support screen scaling modes for external monitors

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80868

--- Comment #1 from Alex Deucher  ---
Created attachment 102216
  --> https://bugs.freedesktop.org/attachment.cgi?id=102216=edit
starter implementation

I'm not sure when I'll have time to implement this, but just about everything
you need is already in place.  The attached patch should get you started and
may even work...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: