Re: [Nouveau] [PATCH v3 10/10] drm/nouveau: Enable stereoscopic 3D output over HDMI

2017-04-13 Thread Ben Skeggs 

On 04/13/2017 01:22 AM, Alastair Bridgewater wrote:

On Tue, Apr 11, 2017 at 1:32 PM, Ilia Mirkin > wrote:

On Tue, Apr 11, 2017 at 1:11 PM, Alastair Bridgewater
> wrote:
> +   /* HDMI 3D support */
> +   if ((disp->disp.oclass >= NV50_DISP)

You probably meant G82_DISP. Although I don't know if there were any
G80's with DP or HDMI. Either way, all that logic is in hdmig84.c (and
newer), so ... :)


Having taken a closer look at the lower level code, I agree. It should
be G82_DISP.  Will correct in the v4 patch series (if there ends up
being a v4 patch series). Good catch, and thank you!

Hey Alastair,

Firstly, a minor nit-pick:  I modified some of the commit titles a 
little.  For any changes under nvkm/, use 
"drm/nouveau/[SUBDEV][/CHIPSET(s)]:" as a prefix instead of just 
drm/nouveau.


Second, and more importantly, this series looks really good to me.  Nice 
work!


I've given it a quick test on a 3D-capable TV I have, and the TV 
definitely thinks it's getting a 3D mode :)  My glasses are flat, so 
couldn't test any further.


Regardless, I've fixed up the suggestion that Ilia made and merged the 
series.


If there's any other changes to come, there's plenty of time to squash 
those in before the next merge window.


Thanks again,
Ben.



-- Alastair Bridgewater


___
Nouveau mailing list
nouv...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Nouveau] [PATCH v3 10/10] drm/nouveau: Enable stereoscopic 3D output over HDMI

2017-04-12 Thread Alastair Bridgewater 
On Tue, Apr 11, 2017 at 1:32 PM, Ilia Mirkin  wrote:

> On Tue, Apr 11, 2017 at 1:11 PM, Alastair Bridgewater
>  wrote:
> > +   /* HDMI 3D support */
> > +   if ((disp->disp.oclass >= NV50_DISP)
>
> You probably meant G82_DISP. Although I don't know if there were any
> G80's with DP or HDMI. Either way, all that logic is in hdmig84.c (and
> newer), so ... :)
>

Having taken a closer look at the lower level code, I agree. It should be
G82_DISP.  Will correct in the v4 patch series (if there ends up being a v4
patch series). Good catch, and thank you!

-- Alastair Bridgewater
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Nouveau] [PATCH v3 10/10] drm/nouveau: Enable stereoscopic 3D output over HDMI

2017-04-11 Thread Ilia Mirkin 
On Tue, Apr 11, 2017 at 1:11 PM, Alastair Bridgewater
 wrote:
> Enable stereoscopic output for HDMI and DisplayPort connectors on
> NV50+ (G80+) hardware.  We do not enable stereoscopy on older
> hardware in case there is some older board that still has HDMI
> output but for which we have no logic for setting the Vendor
> InfoFrame.
>
> With this, I get an obvious 3D output when using the "testdisplay"
> program from intel-gpu-tools with the "-3" parameter and outputting
> to a 3D-capable HDMI display, for all available 3D modes (be they
> TB, SBSH, or FP) on all four G80+ DISPs.
>
> Signed-off-by: Alastair Bridgewater 
> ---
>  drivers/gpu/drm/nouveau/nouveau_connector.c | 7 +++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c 
> b/drivers/gpu/drm/nouveau/nouveau_connector.c
> index 9a91e79..ff188c7 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
> @@ -1324,6 +1324,13 @@ nouveau_connector_create(struct drm_device *dev, int 
> index)
> break;
> }
>
> +   /* HDMI 3D support */
> +   if ((disp->disp.oclass >= NV50_DISP)

You probably meant G82_DISP. Although I don't know if there were any
G80's with DP or HDMI. Either way, all that logic is in hdmig84.c (and
newer), so ... :)

> +   && ((type == DRM_MODE_CONNECTOR_DisplayPort)
> +   || (type == DRM_MODE_CONNECTOR_eDP)
> +   || (type == DRM_MODE_CONNECTOR_HDMIA)))
> +   connector->stereo_allowed = true;
> +
> /* defaults, will get overridden in detect() */
> connector->interlace_allowed = false;
> connector->doublescan_allowed = false;
> --
> 2.10.2
>
> ___
> Nouveau mailing list
> nouv...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel