[PATCH] OMAPDSS: HDMI: hot plug detect fix

[Tomi Valkeinen]

On Mon, 2012-02-20 at 15:03 -0600, Rob Clark wrote:
> From: Rob Clark 
> 
> The "OMAPDSS: HDMI: PHY burnout fix" commit switched the HDMI driver
> over to using a GPIO for plug detect.  Unfortunately the ->detect()
> method was not also updated, causing HDMI to no longer work for the
> omapdrm driver (because it would actually check if a connection was
> detected before attempting to enable display).

Thanks, I totally missed that.

 Tomi

-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: 

Re: [PATCH] OMAPDSS: HDMI: hot plug detect fix

[Tomi Valkeinen]

On Mon, 2012-02-20 at 15:03 -0600, Rob Clark wrote:
> From: Rob Clark 
> 
> The "OMAPDSS: HDMI: PHY burnout fix" commit switched the HDMI driver
> over to using a GPIO for plug detect.  Unfortunately the ->detect()
> method was not also updated, causing HDMI to no longer work for the
> omapdrm driver (because it would actually check if a connection was
> detected before attempting to enable display).

Thanks, I totally missed that.

 Tomi



signature.asc
Description: This is a digitally signed message part
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] OMAPDSS: HDMI: hot plug detect fix

[Rob Clark]

From: Rob Clark 

The "OMAPDSS: HDMI: PHY burnout fix" commit switched the HDMI driver
over to using a GPIO for plug detect.  Unfortunately the ->detect()
method was not also updated, causing HDMI to no longer work for the
omapdrm driver (because it would actually check if a connection was
detected before attempting to enable display).

Signed-off-by: Rob Clark 
---
 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |9 +
 1 files changed, 1 insertions(+), 8 deletions(-)

diff --git a/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c 
b/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
index 2d72334..6847a47 100644
--- a/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
+++ b/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
@@ -479,14 +479,7 @@ int ti_hdmi_4xxx_read_edid(struct hdmi_ip_data *ip_data,

 bool ti_hdmi_4xxx_detect(struct hdmi_ip_data *ip_data)
 {
-   int r;
-
-   void __iomem *base = hdmi_core_sys_base(ip_data);
-
-   /* HPD */
-   r = REG_GET(base, HDMI_CORE_SYS_SYS_STAT, 1, 1);
-
-   return r == 1;
+   return gpio_get_value(ip_data->hpd_gpio);
 }

 static void hdmi_core_init(struct hdmi_core_video_config *video_cfg,
-- 
1.7.5.4

[PATCH] OMAPDSS: HDMI: hot plug detect fix

[Rob Clark]

From: Rob Clark 

The "OMAPDSS: HDMI: PHY burnout fix" commit switched the HDMI driver
over to using a GPIO for plug detect.  Unfortunately the ->detect()
method was not also updated, causing HDMI to no longer work for the
omapdrm driver (because it would actually check if a connection was
detected before attempting to enable display).

Signed-off-by: Rob Clark 
---
 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |9 +
 1 files changed, 1 insertions(+), 8 deletions(-)

diff --git a/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c 
b/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
index 2d72334..6847a47 100644
--- a/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
+++ b/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
@@ -479,14 +479,7 @@ int ti_hdmi_4xxx_read_edid(struct hdmi_ip_data *ip_data,
 
 bool ti_hdmi_4xxx_detect(struct hdmi_ip_data *ip_data)
 {
-   int r;
-
-   void __iomem *base = hdmi_core_sys_base(ip_data);
-
-   /* HPD */
-   r = REG_GET(base, HDMI_CORE_SYS_SYS_STAT, 1, 1);
-
-   return r == 1;
+   return gpio_get_value(ip_data->hpd_gpio);
 }
 
 static void hdmi_core_init(struct hdmi_core_video_config *video_cfg,
-- 
1.7.5.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel