Re: (subset) [PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

[Lee Jones]

On Sat, 16 Mar 2024 12:45:27 +0300, Dan Carpenter wrote:
> The "num_levels" variable is used to store error codes from
> device_property_count_u32() so it needs to be signed.  This doesn't
> cause an issue at runtime because devm_kcalloc() won't allocate negative
> sizes.  However, it's still worth fixing.
> 
> 

Applied, thanks!

[1/1] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()
  commit: 84a053e072c8aacff8074ac5d6f7a4e7ff745209

--
Lee Jones [李琼斯]

RE: [PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

[FLAVIO SULIGOI]

Hi Dan,

> The "num_levels" variable is used to store error codes from
> device_property_count_u32() so it needs to be signed.  This doesn't cause an
> issue at runtime because devm_kcalloc() won't allocate negative sizes.
> However, it's still worth fixing.
> 
> Fixes: b54c828bdba9 ("backlight: mp3309c: Make use of device properties")
> Signed-off-by: Dan Carpenter 

I've just tested on my board with the mp3309c chip, all is ok.
Thanks!

Tested-by: Flavio Suligoi 

Re: [PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

[Daniel Thompson]

On Sat, Mar 16, 2024 at 12:45:27PM +0300, Dan Carpenter wrote:
> The "num_levels" variable is used to store error codes from
> device_property_count_u32() so it needs to be signed.  This doesn't
> cause an issue at runtime because devm_kcalloc() won't allocate negative
> sizes.  However, it's still worth fixing.
>
> Fixes: b54c828bdba9 ("backlight: mp3309c: Make use of device properties")
> Signed-off-by: Dan Carpenter 

Reviewed-by: Daniel Thompson 


Daniel.

Re: [PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

[Andy Shevchenko]

On Sat, Mar 16, 2024 at 12:45:27PM +0300, Dan Carpenter wrote:
> The "num_levels" variable is used to store error codes from
> device_property_count_u32() so it needs to be signed.  This doesn't
> cause an issue at runtime because devm_kcalloc() won't allocate negative
> sizes.  However, it's still worth fixing.

Agree.
Reviewed-by: Andy Shevchenko 

-- 
With Best Regards,
Andy Shevchenko

[PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

[Dan Carpenter]

The "num_levels" variable is used to store error codes from
device_property_count_u32() so it needs to be signed.  This doesn't
cause an issue at runtime because devm_kcalloc() won't allocate negative
sizes.  However, it's still worth fixing.

Fixes: b54c828bdba9 ("backlight: mp3309c: Make use of device properties")
Signed-off-by: Dan Carpenter 
---
 drivers/video/backlight/mp3309c.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/backlight/mp3309c.c 
b/drivers/video/backlight/mp3309c.c
index c80a1481e742..4e98e60417d2 100644
--- a/drivers/video/backlight/mp3309c.c
+++ b/drivers/video/backlight/mp3309c.c
@@ -205,8 +205,9 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip,
struct mp3309c_platform_data *pdata)
 {
int ret, i;
-   unsigned int num_levels, tmp_value;
+   unsigned int tmp_value;
struct device *dev = chip->dev;
+   int num_levels;
 
if (!dev_fwnode(dev))
return dev_err_probe(dev, -ENODEV, "failed to get firmware 
node\n");
-- 
2.43.0