Re: [PATCH] char/agp: remove agp_bridge_data::type

2024-02-16 Thread Daniel Vetter
On Tue, Feb 13, 2024 at 12:15:11PM +0100, Jiri Slaby (SUSE) wrote:
> agp_bridge_data::type is unused (and I cannot find when was used last).
> 
> Therefore, remove it.
> 
> Found by https://github.com/jirislaby/clang-struct.
> 
> Signed-off-by: Jiri Slaby (SUSE) 
> Cc: David Airlie 
> Cc: dri-devel@lists.freedesktop.org

Thanks, pushed to drm-misc-next.
-Sima

> ---
>  drivers/char/agp/agp.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/agp/agp.h b/drivers/char/agp/agp.h
> index 5c36ab85f80b..67d7be800a7c 100644
> --- a/drivers/char/agp/agp.h
> +++ b/drivers/char/agp/agp.h
> @@ -138,7 +138,6 @@ struct agp_bridge_data {
>   unsigned long gart_bus_addr;
>   unsigned long gatt_bus_addr;
>   u32 mode;
> - enum chipset_type type;
>   unsigned long *key_list;
>   atomic_t current_memory_agp;
>   atomic_t agp_in_use;
> -- 
> 2.43.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


[PATCH] char/agp: remove agp_bridge_data::type

2024-02-13 Thread Jiri Slaby (SUSE)
agp_bridge_data::type is unused (and I cannot find when was used last).

Therefore, remove it.

Found by https://github.com/jirislaby/clang-struct.

Signed-off-by: Jiri Slaby (SUSE) 
Cc: David Airlie 
Cc: dri-devel@lists.freedesktop.org
---
 drivers/char/agp/agp.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/char/agp/agp.h b/drivers/char/agp/agp.h
index 5c36ab85f80b..67d7be800a7c 100644
--- a/drivers/char/agp/agp.h
+++ b/drivers/char/agp/agp.h
@@ -138,7 +138,6 @@ struct agp_bridge_data {
unsigned long gart_bus_addr;
unsigned long gatt_bus_addr;
u32 mode;
-   enum chipset_type type;
unsigned long *key_list;
atomic_t current_memory_agp;
atomic_t agp_in_use;
-- 
2.43.1