[PATCH] dma-buf/sw_sync: put fence reference from the fence creation
On 27 October 2016 at 03:24, Chris Wilson wrote: > On Wed, Oct 26, 2016 at 06:59:59PM -0200, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Once sw_sync_ioctl_create_fence() returns we no longer have the >> *pt pointer to the fence base object thus we need to put the reference >> we have from the fence creation to keep a correct reference accounting. >> >> Signed-off-by: Gustavo Padovan > Fixes: 30cd85dd6edc ("dma-buf/sync_file: hold reference to fence when > creating sync_file") > Reviewed-by: Chris Wilson > -Chris > Applied to drm-misc; Thanks! > -- > Chris Wilson, Intel Open Source Technology Centre > ___ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] dma-buf/sw_sync: put fence reference from the fence creation
On Wed, Oct 26, 2016 at 06:59:59PM -0200, Gustavo Padovan wrote: > From: Gustavo Padovan > > Once sw_sync_ioctl_create_fence() returns we no longer have the > *pt pointer to the fence base object thus we need to put the reference > we have from the fence creation to keep a correct reference accounting. > > Signed-off-by: Gustavo Padovan Fixes: 30cd85dd6edc ("dma-buf/sync_file: hold reference to fence when creating sync_file") Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre
[PATCH] dma-buf/sw_sync: put fence reference from the fence creation
From: Gustavo PadovanOnce sw_sync_ioctl_create_fence() returns we no longer have the *pt pointer to the fence base object thus we need to put the reference we have from the fence creation to keep a correct reference accounting. Signed-off-by: Gustavo Padovan --- drivers/dma-buf/sw_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/sw_sync.c b/drivers/dma-buf/sw_sync.c index 82e0ca4..efed2b7 100644 --- a/drivers/dma-buf/sw_sync.c +++ b/drivers/dma-buf/sw_sync.c @@ -316,8 +316,8 @@ static long sw_sync_ioctl_create_fence(struct sync_timeline *obj, } sync_file = sync_file_create(>base); + dma_fence_put(>base); if (!sync_file) { - dma_fence_put(>base); err = -ENOMEM; goto err; } -- 2.5.5