Re: [PATCH] drm/amd/display: avoid variable reinitialization

2023-11-06 Thread Alex Deucher 
Applied.  Thanks!

On Tue, Oct 24, 2023 at 2:11 PM Bragatheswaran Manickavel
 wrote:
>
> The member variable enable_hpo_pg_support is already initialized
> and hence the reinitialization instruction can be removed. Issue
> identified using the doubleinit.cocci Coccinelle semantic patch script.
>
> Signed-off-by: Bragatheswaran Manickavel 
> ---
>  drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c 
> b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> index 99d55b958977..1fd9df8da09c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> @@ -739,7 +739,6 @@ static const struct dc_debug_options debug_defaults_drv = 
> {
> .disable_boot_optimizations = false,
> .disable_unbounded_requesting = false,
> .disable_mem_low_power = false,
> -   .enable_hpo_pg_support = false,
> //must match enable_single_display_2to1_odm_policy to support dynamic 
> ODM transitions
> .enable_double_buffered_dsc_pg_support = true,
> .enable_dp_dig_pixel_rate_div_policy = 1,
> --
> 2.34.1
>

Re: [PATCH] drm/amd/display: avoid variable reinitialization

2023-11-04 Thread Bragatheswaran Manickavel 



On 30/10/23 20:17, Bragatheswaran Manickavel wrote:


On 24/10/23 23:41, Bragatheswaran Manickavel wrote:

The member variable enable_hpo_pg_support is already initialized
and hence the reinitialization instruction can be removed. Issue
identified using the doubleinit.cocci Coccinelle semantic patch script.

Signed-off-by: Bragatheswaran Manickavel 
---
  drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c 
b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c

index 99d55b958977..1fd9df8da09c 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
@@ -739,7 +739,6 @@ static const struct dc_debug_options 
debug_defaults_drv = {

  .disable_boot_optimizations = false,
  .disable_unbounded_requesting = false,
  .disable_mem_low_power = false,
-    .enable_hpo_pg_support = false,
  //must match enable_single_display_2to1_odm_policy to support 
dynamic ODM transitions

  .enable_double_buffered_dsc_pg_support = true,
  .enable_dp_dig_pixel_rate_div_policy = 1,



just a friendly ping

Thanks,
Bragathe


Could someone help me in reviewing this changes ?

Thanks,
Bragathe

Re: [PATCH] drm/amd/display: avoid variable reinitialization

2023-10-30 Thread Bragatheswaran Manickavel 



On 24/10/23 23:41, Bragatheswaran Manickavel wrote:

The member variable enable_hpo_pg_support is already initialized
and hence the reinitialization instruction can be removed. Issue
identified using the doubleinit.cocci Coccinelle semantic patch script.

Signed-off-by: Bragatheswaran Manickavel 
---
  drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c 
b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
index 99d55b958977..1fd9df8da09c 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
@@ -739,7 +739,6 @@ static const struct dc_debug_options debug_defaults_drv = {
.disable_boot_optimizations = false,
.disable_unbounded_requesting = false,
.disable_mem_low_power = false,
-   .enable_hpo_pg_support = false,
//must match enable_single_display_2to1_odm_policy to support dynamic 
ODM transitions
.enable_double_buffered_dsc_pg_support = true,
.enable_dp_dig_pixel_rate_div_policy = 1,



just a friendly ping

Thanks,
Bragathe

[PATCH] drm/amd/display: avoid variable reinitialization

2023-10-24 Thread Bragatheswaran Manickavel 
The member variable enable_hpo_pg_support is already initialized 
and hence the reinitialization instruction can be removed. Issue 
identified using the doubleinit.cocci Coccinelle semantic patch script.

Signed-off-by: Bragatheswaran Manickavel 
---
 drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c 
b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
index 99d55b958977..1fd9df8da09c 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
@@ -739,7 +739,6 @@ static const struct dc_debug_options debug_defaults_drv = {
.disable_boot_optimizations = false,
.disable_unbounded_requesting = false,
.disable_mem_low_power = false,
-   .enable_hpo_pg_support = false,
//must match enable_single_display_2to1_odm_policy to support dynamic 
ODM transitions
.enable_double_buffered_dsc_pg_support = true,
.enable_dp_dig_pixel_rate_div_policy = 1,
-- 
2.34.1

Re: [PATCH] drm/amd/display: avoid variable reinitialization

2023-01-16 Thread Alex Deucher 
This is already fixed.

Thanks,

Alex

On Sun, Jan 15, 2023 at 4:32 AM Deepak R Varma  wrote:
>
> The member variable set_odm_combine is already initialized and hence the
> reinitialization instruction can be removed. Issue identified using the
> dubleinit.cocci Coccinelle semantic patch script.
>
> Signed-off-by: Deepak R Varma 
> ---
>  drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c 
> b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> index 41edbd64ea21..777d8efee977 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> @@ -254,7 +254,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = {
> .get_hw_timing = optc1_get_hw_timing,
> .init_odm = optc3_init_odm,
> .set_odm_bypass = optc314_set_odm_bypass,
> -   .set_odm_combine = optc314_set_odm_combine,
> .set_h_timing_div_manual_mode = 
> optc314_set_h_timing_div_manual_mode,
>  };
>
> --
> 2.34.1
>
>
>

[PATCH] drm/amd/display: avoid variable reinitialization

2023-01-15 Thread Deepak R Varma 
The member variable set_odm_combine is already initialized and hence the
reinitialization instruction can be removed. Issue identified using the
dubleinit.cocci Coccinelle semantic patch script.

Signed-off-by: Deepak R Varma 
---
 drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c 
b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
index 41edbd64ea21..777d8efee977 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
@@ -254,7 +254,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = {
.get_hw_timing = optc1_get_hw_timing,
.init_odm = optc3_init_odm,
.set_odm_bypass = optc314_set_odm_bypass,
-   .set_odm_combine = optc314_set_odm_combine,
.set_h_timing_div_manual_mode = 
optc314_set_h_timing_div_manual_mode,
 };
 
-- 
2.34.1