Re: [PATCH] drm/amd/display: code clean up in dce80_hw_sequencer.c

2020-04-13 Thread Alex Deucher
On Mon, Apr 13, 2020 at 5:29 AM Jason Yan  wrote:
>
> Fix the following gcc warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_hw_sequencer.c:43:46:
> warning: ‘reg_offsets’ defined but not used [-Wunused-const-variable=]
>  static const struct dce80_hw_seq_reg_offsets reg_offsets[] = {
>   ^~~
>
> Reported-by: Hulk Robot 
> Signed-off-by: Jason Yan 

Applied.  Thanks!

Alex

> ---
>  .../amd/display/dc/dce80/dce80_hw_sequencer.c | 28 ---
>  1 file changed, 28 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_hw_sequencer.c 
> b/drivers/gpu/drm/amd/display/dc/dce80/dce80_hw_sequencer.c
> index 893261c81854..d2ceebdbdf51 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_hw_sequencer.c
> @@ -36,34 +36,6 @@
>  #include "dce/dce_8_0_d.h"
>  #include "dce/dce_8_0_sh_mask.h"
>
> -struct dce80_hw_seq_reg_offsets {
> -   uint32_t crtc;
> -};
> -
> -static const struct dce80_hw_seq_reg_offsets reg_offsets[] = {
> -{
> -   .crtc = (mmCRTC0_CRTC_GSL_CONTROL - mmCRTC_GSL_CONTROL),
> -},
> -{
> -   .crtc = (mmCRTC1_CRTC_GSL_CONTROL - mmCRTC_GSL_CONTROL),
> -},
> -{
> -   .crtc = (mmCRTC2_CRTC_GSL_CONTROL - mmCRTC_GSL_CONTROL),
> -},
> -{
> -   .crtc = (mmCRTC3_CRTC_GSL_CONTROL - mmCRTC_GSL_CONTROL),
> -},
> -{
> -   .crtc = (mmCRTC4_CRTC_GSL_CONTROL - mmCRTC_GSL_CONTROL),
> -},
> -{
> -   .crtc = (mmCRTC5_CRTC_GSL_CONTROL - mmCRTC_GSL_CONTROL),
> -}
> -};
> -
> -#define HW_REG_CRTC(reg, id)\
> -   (reg + reg_offsets[id].crtc)
> -
>  
> /***
>   * Private definitions
>   
> **/
> --
> 2.21.1
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH] drm/amd/display: code clean up in dce80_hw_sequencer.c

2020-04-13 Thread Jason Yan
Fix the following gcc warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_hw_sequencer.c:43:46:
warning: ‘reg_offsets’ defined but not used [-Wunused-const-variable=]
 static const struct dce80_hw_seq_reg_offsets reg_offsets[] = {
  ^~~

Reported-by: Hulk Robot 
Signed-off-by: Jason Yan 
---
 .../amd/display/dc/dce80/dce80_hw_sequencer.c | 28 ---
 1 file changed, 28 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_hw_sequencer.c 
b/drivers/gpu/drm/amd/display/dc/dce80/dce80_hw_sequencer.c
index 893261c81854..d2ceebdbdf51 100644
--- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_hw_sequencer.c
@@ -36,34 +36,6 @@
 #include "dce/dce_8_0_d.h"
 #include "dce/dce_8_0_sh_mask.h"
 
-struct dce80_hw_seq_reg_offsets {
-   uint32_t crtc;
-};
-
-static const struct dce80_hw_seq_reg_offsets reg_offsets[] = {
-{
-   .crtc = (mmCRTC0_CRTC_GSL_CONTROL - mmCRTC_GSL_CONTROL),
-},
-{
-   .crtc = (mmCRTC1_CRTC_GSL_CONTROL - mmCRTC_GSL_CONTROL),
-},
-{
-   .crtc = (mmCRTC2_CRTC_GSL_CONTROL - mmCRTC_GSL_CONTROL),
-},
-{
-   .crtc = (mmCRTC3_CRTC_GSL_CONTROL - mmCRTC_GSL_CONTROL),
-},
-{
-   .crtc = (mmCRTC4_CRTC_GSL_CONTROL - mmCRTC_GSL_CONTROL),
-},
-{
-   .crtc = (mmCRTC5_CRTC_GSL_CONTROL - mmCRTC_GSL_CONTROL),
-}
-};
-
-#define HW_REG_CRTC(reg, id)\
-   (reg + reg_offsets[id].crtc)
-
 
/***
  * Private definitions
  
**/
-- 
2.21.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel