Re: [PATCH] drm/bridge/sii8620: add missing error handling in probe

[Sean Paul]

On Wed, Feb 22, 2017 at 12:47:37PM +0100, Andrzej Hajda wrote:
> devm_request_threaded_irq result should be checked for errors.
> 
> Signed-off-by: Andrzej Hajda 

Applied to -misc

Thanks,

Sean

> ---
>  drivers/gpu/drm/bridge/sil-sii8620.c | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c 
> b/drivers/gpu/drm/bridge/sil-sii8620.c
> index cdd0a9d..2d51a22 100644
> --- a/drivers/gpu/drm/bridge/sil-sii8620.c
> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c
> @@ -2184,6 +2184,10 @@ static int sii8620_probe(struct i2c_client *client,
>   sii8620_irq_thread,
>   IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
>   "sii8620", ctx);
> + if (ret < 0) {
> + dev_err(dev, "failed to install IRQ handler\n");
> + return ret;
> + }
>  
>   ctx->gpio_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
>   if (IS_ERR(ctx->gpio_reset)) {
> -- 
> 2.7.4
> 
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Sean Paul, Software Engineer, Google / Chromium OS
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/bridge/sii8620: add missing error handling in probe

[Andrzej Hajda]

devm_request_threaded_irq result should be checked for errors.

Signed-off-by: Andrzej Hajda 
---
 drivers/gpu/drm/bridge/sil-sii8620.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c 
b/drivers/gpu/drm/bridge/sil-sii8620.c
index cdd0a9d..2d51a22 100644
--- a/drivers/gpu/drm/bridge/sil-sii8620.c
+++ b/drivers/gpu/drm/bridge/sil-sii8620.c
@@ -2184,6 +2184,10 @@ static int sii8620_probe(struct i2c_client *client,
sii8620_irq_thread,
IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
"sii8620", ctx);
+   if (ret < 0) {
+   dev_err(dev, "failed to install IRQ handler\n");
+   return ret;
+   }
 
ctx->gpio_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
if (IS_ERR(ctx->gpio_reset)) {
-- 
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel