Re: [PATCH] drm/bridge: adv7511: Attach next bridge without creating connector
On Mon, 13 May 2024 16:02:43 +0800, Liu Ying wrote: > The connector is created by either this ADV7511 bridge driver or > any DRM device driver/previous bridge driver, so this ADV7511 > bridge driver should not let the next bridge driver create connector. > > If the next bridge is a HDMI connector, the next bridge driver > would fail to attach bridge from display_connector_attach() without > the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. > > [...] Applied to drm-misc-next-fixes, thanks! [1/1] drm/bridge: adv7511: Attach next bridge without creating connector commit: 20da948e3a807c67f0efe4f665e64728be370f3d Best regards, -- With best wishes Dmitry
Re: [PATCH] drm/bridge: adv7511: Attach next bridge without creating connector
On Mon, 13 May 2024 at 10:55, Liu Ying wrote:
>
> The connector is created by either this ADV7511 bridge driver or
> any DRM device driver/previous bridge driver, so this ADV7511
> bridge driver should not let the next bridge driver create connector.
>
> If the next bridge is a HDMI connector, the next bridge driver
> would fail to attach bridge from display_connector_attach() without
> the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag.
>
> Add that flag to drm_bridge_attach() function call in
> adv7511_bridge_attach() to fix the issue.
>
> This fixes the issue where the HDMI connector bridge fails to attach
> to the previous ADV7535 bridge on i.MX8MP EVK platform:
>
> [2.216442] [drm:drm_bridge_attach] *ERROR* failed to attach bridge
> /hdmi-connector to encoder None-37: -22
> [2.220675] mmc1: SDHCI controller on 30b5.mmc [30b5.mmc] using
> ADMA
> [2.226262] [drm:drm_bridge_attach] *ERROR* failed to attach bridge
> /soc@0/bus@3080/i2c@30a3/hdmi@3d to encoder None-37: -22
> [2.245204] [drm:drm_bridge_attach] *ERROR* failed to attach bridge
> /soc@0/bus@32c0/dsi@32e6 to encoder None-37: -22
> [2.256445] imx-lcdif 32e8.display-controller: error -EINVAL: Failed
> to attach bridge for endpoint0
> [2.265850] imx-lcdif 32e8.display-controller: error -EINVAL: Cannot
> connect bridge
> [2.274009] imx-lcdif 32e8.display-controller: probe with driver
> imx-lcdif failed with error -22
>
> Fixes: 14b3cdbd0e5b ("drm/bridge: adv7511: make it honour next bridge in DT")
> Signed-off-by: Liu Ying
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
[PATCH] drm/bridge: adv7511: Attach next bridge without creating connector
The connector is created by either this ADV7511 bridge driver or
any DRM device driver/previous bridge driver, so this ADV7511
bridge driver should not let the next bridge driver create connector.
If the next bridge is a HDMI connector, the next bridge driver
would fail to attach bridge from display_connector_attach() without
the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag.
Add that flag to drm_bridge_attach() function call in
adv7511_bridge_attach() to fix the issue.
This fixes the issue where the HDMI connector bridge fails to attach
to the previous ADV7535 bridge on i.MX8MP EVK platform:
[2.216442] [drm:drm_bridge_attach] *ERROR* failed to attach bridge
/hdmi-connector to encoder None-37: -22
[2.220675] mmc1: SDHCI controller on 30b5.mmc [30b5.mmc] using ADMA
[2.226262] [drm:drm_bridge_attach] *ERROR* failed to attach bridge
/soc@0/bus@3080/i2c@30a3/hdmi@3d to encoder None-37: -22
[2.245204] [drm:drm_bridge_attach] *ERROR* failed to attach bridge
/soc@0/bus@32c0/dsi@32e6 to encoder None-37: -22
[2.256445] imx-lcdif 32e8.display-controller: error -EINVAL: Failed to
attach bridge for endpoint0
[2.265850] imx-lcdif 32e8.display-controller: error -EINVAL: Cannot
connect bridge
[2.274009] imx-lcdif 32e8.display-controller: probe with driver
imx-lcdif failed with error -22
Fixes: 14b3cdbd0e5b ("drm/bridge: adv7511: make it honour next bridge in DT")
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index dd21b81bd28f..66ccb61e2a66 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -953,7 +953,8 @@ static int adv7511_bridge_attach(struct drm_bridge *bridge,
int ret = 0;
if (adv->next_bridge) {
- ret = drm_bridge_attach(bridge->encoder, adv->next_bridge,
bridge, flags);
+ ret = drm_bridge_attach(bridge->encoder, adv->next_bridge,
bridge,
+ flags | DRM_BRIDGE_ATTACH_NO_CONNECTOR);
if (ret)
return ret;
}
--
2.34.1
