Re: [PATCH] drm/bridge: dw-hdmi: Switch to SPDX identifier
On Wed, May 23, 2018 at 06:07:49PM +0300, Laurent Pinchart wrote: > Hi Lucas, > > (CC'ing Greg) > > On Wednesday, 23 May 2018 18:02:23 EEST Lucas Stach wrote: > > Am Dienstag, den 22.05.2018, 13:37 +0300 schrieb Laurent Pinchart: > > > On Tuesday, 22 May 2018 12:29:21 EEST Lucas Stach wrote: > > >> Am Sonntag, den 20.05.2018, 14:05 -0300 schrieb Fabio Estevam: > > From: Fabio Estevam> > >>> > > >>> Adopt the SPDX license identifier headers to ease license compliance > > >>> management. > > >>> > > Signed-off-by: Fabio Estevam > > >>> > > >>> --- > > >>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +-- > > >>> 1 file changed, 1 insertion(+), 6 deletions(-) > > >>> > > >>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > >>> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index ec8d000..3bc62d5 > > >>> 100644 > > >>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > >>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > >>> @@ -1,15 +1,10 @@ > > >>> +// SPDX-License-Identifier: GPL-2.0+ > > >> > > >> The GPL-2.0+ tag is deprecated, please use GPL-2.0-or-later instead. > > >> > > >> Same comment applies to some other SPDX conversion patches from you. > > > > > > Documentation/process/license-rules.rst still mentions GPL-2.0+, not > > > GPL-2.0- or-later. Until the documentation gets updated, I think we > > > should stick to GPL-2.0+. > > > > The (what I would consider canonical) description of the license [1] > > has a pretty fat DEPRECATED tag attached to it. I would prefer not to > > pull in patches to convert the license stuff to a tag that's already > > deprecated. > > This topic has been discussed before, and Greg asked to stick to the > identifiers defined in Documentation/process/license-rules.rst. As he started > the whole SPDX initiative, I'm inclined to just do as he said :-) I don't > have > a strong opinion on this topic personally, but I think that consistency is > important. Yes, stick to what we have for now please. I think Thomas has worked to bring in the update for the new SPDX tags, but as the "old" ones are not invalid, please wait for that to happen before adding them to the kernel tree. I think it might make 4.18, unless we get some more "fun" security issues to distract us... thanks, greg k-h ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/bridge: dw-hdmi: Switch to SPDX identifier
Hi Lucas, (CC'ing Greg) On Wednesday, 23 May 2018 18:02:23 EEST Lucas Stach wrote: > Am Dienstag, den 22.05.2018, 13:37 +0300 schrieb Laurent Pinchart: > > On Tuesday, 22 May 2018 12:29:21 EEST Lucas Stach wrote: > >> Am Sonntag, den 20.05.2018, 14:05 -0300 schrieb Fabio Estevam: > From: Fabio Estevam> >>> > >>> Adopt the SPDX license identifier headers to ease license compliance > >>> management. > >>> > Signed-off-by: Fabio Estevam > >>> > >>> --- > >>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +-- > >>> 1 file changed, 1 insertion(+), 6 deletions(-) > >>> > >>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > >>> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index ec8d000..3bc62d5 > >>> 100644 > >>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > >>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > >>> @@ -1,15 +1,10 @@ > >>> +// SPDX-License-Identifier: GPL-2.0+ > >> > >> The GPL-2.0+ tag is deprecated, please use GPL-2.0-or-later instead. > >> > >> Same comment applies to some other SPDX conversion patches from you. > > > > Documentation/process/license-rules.rst still mentions GPL-2.0+, not > > GPL-2.0- or-later. Until the documentation gets updated, I think we > > should stick to GPL-2.0+. > > The (what I would consider canonical) description of the license [1] > has a pretty fat DEPRECATED tag attached to it. I would prefer not to > pull in patches to convert the license stuff to a tag that's already > deprecated. This topic has been discussed before, and Greg asked to stick to the identifiers defined in Documentation/process/license-rules.rst. As he started the whole SPDX initiative, I'm inclined to just do as he said :-) I don't have a strong opinion on this topic personally, but I think that consistency is important. > [1] https://spdx.org/licenses/GPL-2.0+.html -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/bridge: dw-hdmi: Switch to SPDX identifier
Hi Laurent, Am Dienstag, den 22.05.2018, 13:37 +0300 schrieb Laurent Pinchart: > Hi Lucas, > > On Tuesday, 22 May 2018 12:29:21 EEST Lucas Stach wrote: > > Am Sonntag, den 20.05.2018, 14:05 -0300 schrieb Fabio Estevam: > > > > From: Fabio Estevam> > > > > > Adopt the SPDX license identifier headers to ease license compliance > > > management. > > > > > > > Signed-off-by: Fabio Estevam > > > > > > --- > > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +-- > > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index ec8d000..3bc62d5 100644 > > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > > @@ -1,15 +1,10 @@ > > > +// SPDX-License-Identifier: GPL-2.0+ > > > > The GPL-2.0+ tag is deprecated, please use GPL-2.0-or-later instead. > > > > Same comment applies to some other SPDX conversion patches from you. > > Documentation/process/license-rules.rst still mentions GPL-2.0+, not GPL-2.0- > or-later. Until the documentation gets updated, I think we should stick to > GPL-2.0+. The (what I would consider canonical) description of the license [1] has a pretty fat DEPRECATED tag attached to it. I would prefer not to pull in patches to convert the license stuff to a tag that's already deprecated. Regards, Lucas [1] https://spdx.org/licenses/GPL-2.0+.html ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/bridge: dw-hdmi: Switch to SPDX identifier
Hi Lucas, On Tuesday, 22 May 2018 12:29:21 EEST Lucas Stach wrote: > Am Sonntag, den 20.05.2018, 14:05 -0300 schrieb Fabio Estevam: > > > From: Fabio Estevam> > > > Adopt the SPDX license identifier headers to ease license compliance > > management. > > > > > Signed-off-by: Fabio Estevam > > > > --- > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +-- > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index ec8d000..3bc62d5 100644 > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > @@ -1,15 +1,10 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > The GPL-2.0+ tag is deprecated, please use GPL-2.0-or-later instead. > > Same comment applies to some other SPDX conversion patches from you. Documentation/process/license-rules.rst still mentions GPL-2.0+, not GPL-2.0- or-later. Until the documentation gets updated, I think we should stick to GPL-2.0+. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/bridge: dw-hdmi: Switch to SPDX identifier
Hi Fabio, Am Sonntag, den 20.05.2018, 14:05 -0300 schrieb Fabio Estevam: > > From: Fabio Estevam> > Adopt the SPDX license identifier headers to ease license compliance > management. > > > Signed-off-by: Fabio Estevam > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index ec8d000..3bc62d5 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -1,15 +1,10 @@ > +// SPDX-License-Identifier: GPL-2.0+ The GPL-2.0+ tag is deprecated, please use GPL-2.0-or-later instead. Same comment applies to some other SPDX conversion patches from you. Regards, Lucas ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/bridge: dw-hdmi: Switch to SPDX identifier
From: Fabio EstevamAdopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Fabio Estevam --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index ec8d000..3bc62d5 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -1,15 +1,10 @@ +// SPDX-License-Identifier: GPL-2.0+ /* * DesignWare High-Definition Multimedia Interface (HDMI) driver * * Copyright (C) 2013-2015 Mentor Graphics Inc. * Copyright (C) 2011-2013 Freescale Semiconductor, Inc. * Copyright (C) 2010, Guennadi Liakhovetski - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * */ #include #include -- 2.7.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel