Re: [PATCH] drm/bridge: tc358767: Enable DSI burst mode, LPM, non-continuous clock

2022-10-17 Thread Maxime Ripard
On Sun, Oct 16, 2022 at 02:36:32AM +0200, Marek Vasut wrote:
> The TC358767/TC358867/TC9595 are capable of DSI burst mode, which
> is more energy efficient than the non-burst modes. Make use of it.
> 
> The TC358767/TC358867/TC9595 are capable of DSI non-continuous clock,
> since it sources the internal PLL clock from external clock source.
> The DSI non-continuous clock further reduces power utilization.
> 
> The TC358767/TC358867/TC9595 may use DSI LPM for command transmissions,
> make sure this is configured correctly in the DSI mode flags.
> 
> Signed-off-by: Marek Vasut 

Acked-by: Maxime Ripard 

Maxime


signature.asc
Description: PGP signature


[PATCH] drm/bridge: tc358767: Enable DSI burst mode, LPM, non-continuous clock

2022-10-15 Thread Marek Vasut
The TC358767/TC358867/TC9595 are capable of DSI burst mode, which
is more energy efficient than the non-burst modes. Make use of it.

The TC358767/TC358867/TC9595 are capable of DSI non-continuous clock,
since it sources the internal PLL clock from external clock source.
The DSI non-continuous clock further reduces power utilization.

The TC358767/TC358867/TC9595 may use DSI LPM for command transmissions,
make sure this is configured correctly in the DSI mode flags.

Signed-off-by: Marek Vasut 
---
Cc: Jonas Karlman 
Cc: Laurent Pinchart 
Cc: Lucas Stach 
Cc: Maxime Ripard 
Cc: Neil Armstrong 
Cc: Robert Foss 
Cc: Sam Ravnborg 
---
 drivers/gpu/drm/bridge/tc358767.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/tc358767.c 
b/drivers/gpu/drm/bridge/tc358767.c
index 67f294f96e823..b5f4e5328eaf9 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -1899,10 +1899,10 @@ static int tc_mipi_dsi_host_attach(struct tc_data *tc)
 "failed to create dsi device\n");
 
tc->dsi = dsi;
-
dsi->lanes = dsi_lanes;
dsi->format = MIPI_DSI_FMT_RGB888;
-   dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE;
+   dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
+ MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS;
 
ret = mipi_dsi_attach(dsi);
if (ret < 0) {
-- 
2.35.1