Re: [PATCH] drm/bridge: tc358767: Set default CLRSIPO count

2022-10-17 Thread Maxime Ripard
On Sun, Oct 16, 2022 at 02:35:56AM +0200, Marek Vasut wrote:
> The current CLRSIPO count is still marginal and does not work with high
> DSI clock rates in burst mode. Increase it further to allow the DSI link
> to work at up to 1Gbps lane speed. This returns the counts to defaults
> as provided by datasheet.
> 
> Fixes: ea6490b02240b ("drm/bridge: tc358767: increase CLRSIPO count")
> Signed-off-by: Marek Vasut 

Acked-by: Maxime Ripard 

Maxime


signature.asc
Description: PGP signature


[PATCH] drm/bridge: tc358767: Set default CLRSIPO count

2022-10-15 Thread Marek Vasut
The current CLRSIPO count is still marginal and does not work with high
DSI clock rates in burst mode. Increase it further to allow the DSI link
to work at up to 1Gbps lane speed. This returns the counts to defaults
as provided by datasheet.

Fixes: ea6490b02240b ("drm/bridge: tc358767: increase CLRSIPO count")
Signed-off-by: Marek Vasut 
---
Cc: Jonas Karlman 
Cc: Laurent Pinchart 
Cc: Lucas Stach 
Cc: Maxime Ripard 
Cc: Neil Armstrong 
Cc: Robert Foss 
Cc: Sam Ravnborg 
---
 drivers/gpu/drm/bridge/tc358767.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/tc358767.c 
b/drivers/gpu/drm/bridge/tc358767.c
index 98cfb50a83bec..67f294f96e823 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -1267,10 +1267,10 @@ static int tc_dsi_rx_enable(struct tc_data *tc)
u32 value;
int ret;
 
-   regmap_write(tc->regmap, PPI_D0S_CLRSIPOCOUNT, 5);
-   regmap_write(tc->regmap, PPI_D1S_CLRSIPOCOUNT, 5);
-   regmap_write(tc->regmap, PPI_D2S_CLRSIPOCOUNT, 5);
-   regmap_write(tc->regmap, PPI_D3S_CLRSIPOCOUNT, 5);
+   regmap_write(tc->regmap, PPI_D0S_CLRSIPOCOUNT, 25);
+   regmap_write(tc->regmap, PPI_D1S_CLRSIPOCOUNT, 25);
+   regmap_write(tc->regmap, PPI_D2S_CLRSIPOCOUNT, 25);
+   regmap_write(tc->regmap, PPI_D3S_CLRSIPOCOUNT, 25);
regmap_write(tc->regmap, PPI_D0S_ATMR, 0);
regmap_write(tc->regmap, PPI_D1S_ATMR, 0);
regmap_write(tc->regmap, PPI_TX_RX_TA, TTA_GET | TTA_SURE);
-- 
2.35.1