Re: [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing
Le mer. 20 nov. 2019 à 00:28, Benjamin GAIGNARD a écrit : > > > On 11/19/19 7:53 PM, Souza, Jose wrote: > > On Tue, 2019-11-19 at 13:58 +0100, Benjamin Gaignard wrote: > >> Include drm_crtc_helper_internal.h to provide > >> drm_connector_get_single_encoder > >> prototype. > >> > >> Fixes: a92462d6bf493 ("drm/connector: Share with non-atomic drivers > >> the function to get the single encoder") > > drm_connector_get_single_encoder() is implemented before the use in > > this file so it is not broken, no need of a fixes tag. > > > > Reviewed-by: José Roberto de Souza > > I will remove fixe tag before push it. > > Thanks, > > Benjamin Applied on drm-misc-next with out Fixes tag. Thanks for the review. Benjamin > > > > >> Cc: José Roberto de Souza > >> > >> Signed-off-by: Benjamin Gaignard > >> --- > >> drivers/gpu/drm/drm_crtc_helper.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/drm_crtc_helper.c > >> b/drivers/gpu/drm/drm_crtc_helper.c > >> index 499b05aaccfc..93a4eec429e8 100644 > >> --- a/drivers/gpu/drm/drm_crtc_helper.c > >> +++ b/drivers/gpu/drm/drm_crtc_helper.c > >> @@ -48,6 +48,8 @@ > >> #include > >> #include > >> > >> +#include "drm_crtc_helper_internal.h" > >> + > >> /** > >>* DOC: overview > >>* > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing
On 11/19/19 7:53 PM, Souza, Jose wrote: > On Tue, 2019-11-19 at 13:58 +0100, Benjamin Gaignard wrote: >> Include drm_crtc_helper_internal.h to provide >> drm_connector_get_single_encoder >> prototype. >> >> Fixes: a92462d6bf493 ("drm/connector: Share with non-atomic drivers >> the function to get the single encoder") > drm_connector_get_single_encoder() is implemented before the use in > this file so it is not broken, no need of a fixes tag. > > Reviewed-by: José Roberto de Souza I will remove fixe tag before push it. Thanks, Benjamin > >> Cc: José Roberto de Souza >> >> Signed-off-by: Benjamin Gaignard >> --- >> drivers/gpu/drm/drm_crtc_helper.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_crtc_helper.c >> b/drivers/gpu/drm/drm_crtc_helper.c >> index 499b05aaccfc..93a4eec429e8 100644 >> --- a/drivers/gpu/drm/drm_crtc_helper.c >> +++ b/drivers/gpu/drm/drm_crtc_helper.c >> @@ -48,6 +48,8 @@ >> #include >> #include >> >> +#include "drm_crtc_helper_internal.h" >> + >> /** >>* DOC: overview >>* ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing
Include drm_crtc_helper_internal.h to provide drm_connector_get_single_encoder prototype. Fixes: a92462d6bf493 ("drm/connector: Share with non-atomic drivers the function to get the single encoder") Cc: José Roberto de Souza Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_crtc_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index 499b05aaccfc..93a4eec429e8 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -48,6 +48,8 @@ #include #include +#include "drm_crtc_helper_internal.h" + /** * DOC: overview * -- 2.15.0 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing
On Tue, 2019-11-19 at 13:58 +0100, Benjamin Gaignard wrote: > Include drm_crtc_helper_internal.h to provide > drm_connector_get_single_encoder > prototype. > > Fixes: a92462d6bf493 ("drm/connector: Share with non-atomic drivers > the function to get the single encoder") drm_connector_get_single_encoder() is implemented before the use in this file so it is not broken, no need of a fixes tag. Reviewed-by: José Roberto de Souza > > Cc: José Roberto de Souza > > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/drm_crtc_helper.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c > b/drivers/gpu/drm/drm_crtc_helper.c > index 499b05aaccfc..93a4eec429e8 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -48,6 +48,8 @@ > #include > #include > > +#include "drm_crtc_helper_internal.h" > + > /** > * DOC: overview > * ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel