[PATCH] drm/crtc-helper: use drm_framebuffer flags
On 23 July 2014 01:40, Benjamin Gaignard wrote: > Adding LKML and David in diffusion list to get an opinion on this patch > > 2014-07-10 10:01 GMT+02:00 Fabien DESSENNE : >> Hi, >> Can anyone review this patch ? It's been in drm-next for a few weeks. Dave.
[PATCH] drm/crtc-helper: use drm_framebuffer flags
Adding LKML and David in diffusion list to get an opinion on this patch 2014-07-10 10:01 GMT+02:00 Fabien DESSENNE : > Hi, > Can anyone review this patch ? > Thanks for your time. > Fabien > >> -Original Message- >> From: Fabien DESSENNE [mailto:fabien.dessenne at st.com] >> Sent: mardi 1 juillet 2014 14:41 >> To: dri-devel at lists.freedesktop.org >> Cc: Benjamin Gaignard; Vincent ABRIOU; Fabien DESSENNE >> Subject: [PATCH] drm/crtc-helper: use drm_framebuffer flags >> >> The "flags" parameter of the DRM_IOCTL_MODE_ADDFB2 ioctl must be >> propagated and used by the driver. >> The only possible value of flags is DRM_MODE_FB_INTERLACED. >> >> Signed-off-by: Fabien Dessenne >> Reviewed-by: Benjamin GAIGNARD >> --- >> drivers/gpu/drm/drm_crtc_helper.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/drm_crtc_helper.c >> b/drivers/gpu/drm/drm_crtc_helper.c >> index 23500c0..5974489 100644 >> --- a/drivers/gpu/drm/drm_crtc_helper.c >> +++ b/drivers/gpu/drm/drm_crtc_helper.c >> @@ -966,6 +966,7 @@ int drm_helper_mode_fill_fb_struct(struct >> drm_framebuffer *fb, >> drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth, >> &fb->bits_per_pixel); >> fb->pixel_format = mode_cmd->pixel_format; >> + fb->flags = mode_cmd->flags; >> >> return 0; >> } >> -- >> 1.9.1 > -- Benjamin Gaignard Graphic Working Group Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[PATCH] drm/crtc-helper: use drm_framebuffer flags
Hi, Can anyone review this patch ? Thanks for your time. Fabien > -Original Message- > From: Fabien DESSENNE [mailto:fabien.dessenne at st.com] > Sent: mardi 1 juillet 2014 14:41 > To: dri-devel at lists.freedesktop.org > Cc: Benjamin Gaignard; Vincent ABRIOU; Fabien DESSENNE > Subject: [PATCH] drm/crtc-helper: use drm_framebuffer flags > > The "flags" parameter of the DRM_IOCTL_MODE_ADDFB2 ioctl must be > propagated and used by the driver. > The only possible value of flags is DRM_MODE_FB_INTERLACED. > > Signed-off-by: Fabien Dessenne > Reviewed-by: Benjamin GAIGNARD > --- > drivers/gpu/drm/drm_crtc_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c > b/drivers/gpu/drm/drm_crtc_helper.c > index 23500c0..5974489 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -966,6 +966,7 @@ int drm_helper_mode_fill_fb_struct(struct > drm_framebuffer *fb, > drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth, > &fb->bits_per_pixel); > fb->pixel_format = mode_cmd->pixel_format; > + fb->flags = mode_cmd->flags; > > return 0; > } > -- > 1.9.1
[PATCH] drm/crtc-helper: use drm_framebuffer flags
The "flags" parameter of the DRM_IOCTL_MODE_ADDFB2 ioctl must be propagated and used by the driver. The only possible value of flags is DRM_MODE_FB_INTERLACED. Signed-off-by: Fabien Dessenne Reviewed-by: Benjamin GAIGNARD --- drivers/gpu/drm/drm_crtc_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index 23500c0..5974489 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -966,6 +966,7 @@ int drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb, drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth, &fb->bits_per_pixel); fb->pixel_format = mode_cmd->pixel_format; + fb->flags = mode_cmd->flags; return 0; } -- 1.9.1
[PATCH] drm/crtc-helper: use drm_framebuffer flags
The "flags" parameter of the DRM_IOCTL_MODE_ADDFB2 ioctl must be propagated and used by the driver. The only possible value of flags is DRM_MODE_FB_INTERLACED. Change-Id: I989c01b1e6eef753eb004a5ac876665ea8ab0da6 Signed-off-by: Fabien Dessenne Change-Id: I2350ad8bd1553a4a7388e8d8b7733e65f1e8caef Reviewed-on: https://gerrit.st.com/8141 Reviewed-by: Benjamin GAIGNARD --- drivers/gpu/drm/drm_crtc_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index 23500c0..5974489 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -966,6 +966,7 @@ int drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb, drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth, &fb->bits_per_pixel); fb->pixel_format = mode_cmd->pixel_format; + fb->flags = mode_cmd->flags; return 0; } -- 1.9.1
