[PATCH] drm/exynos: add phy settings for RB resolutions
Hi,
Have posted a patch that updates the phy settings provided by our hardware team.
For now support for 88.75 MHz is removed, will update it as and when i
recieve and settings
for that pixel clock.
Regards,
Shirish S
On Wed, Apr 2, 2014 at 9:39 AM, Shirish S wrote:
> Hi,
> Kindly hold the merging of this patch, i shall
> update it with proper values, once i receive it from our hardware team.
> Regards,
> ShirisH S
> On Thu, Mar 20, 2014 at 1:05 PM, St?phane Marchesin
> wrote:
>>
>>
>>
>> On Wed, Mar 12, 2014 at 10:28 PM, Shirish S wrote:
>>>
>>> This patch adds support for the below mentioned
>>> pixel clocks in Exynos5250.
>>> Without them, following display modes won't
>>> be supported:
>>>
>>> 71 MHz - 1280x800 at 60Hz RB
>>> 73.25 MHz - 800x600 at 120Hz RB
>>> 88.75 MHz - 1440x900 at 60Hz RB
>>> 115.5 MHz - 1024x768 at 120Hz RB
>>> 119 MHz - 1680x1050 at 60Hz RB
>>>
>>> Signed-off-by: Shirish S
>>> ---
>>> V2: Incorporated review comments
>>>
>>> drivers/gpu/drm/exynos/exynos_hdmi.c | 45
>>> ++
>>> 1 file changed, 45 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
>>> b/drivers/gpu/drm/exynos/exynos_hdmi.c
>>> index 12fdf55..406d89d 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
>>> @@ -304,6 +304,24 @@ static const struct hdmiphy_config
>>> hdmiphy_v14_configs[] = {
>>> },
>>> },
>>> {
>>> + .pixel_clock = 7100,
>>> + .conf = {
>>> + 0x01, 0x91, 0x1e, 0x15, 0x40, 0x3c, 0xce, 0x08,
>>> + 0x04, 0x20, 0xb2, 0xd8, 0x45, 0xa0, 0xac, 0x80,
>>> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
>>> + 0x54, 0xad, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
>>> + },
>>> + },
>>> + {
>>> + .pixel_clock = 7325,
>>> + .conf = {
>>> + 0x01, 0xd1, 0x1f, 0x15, 0x40, 0x18, 0xe9, 0x08,
>>> + 0x02, 0xa0, 0xb7, 0xd8, 0x45, 0xa0, 0xac, 0x80,
>>> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
>>> + 0x54, 0xa8, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
>>> + },
>>> + },
>>> + {
>>> .pixel_clock = 74176000,
>>> .conf = {
>>> 0x01, 0xd1, 0x3e, 0x35, 0x40, 0x5b, 0xde, 0x08,
>>> @@ -331,6 +349,15 @@ static const struct hdmiphy_config
>>> hdmiphy_v14_configs[] = {
>>> },
>>> },
>>> {
>>> + .pixel_clock = 8875,
>>> + .conf = {
>>> + 0x01, 0x91, 0x25, 0x17, 0x40, 0x30, 0xfe, 0x08,
>>> + 0x06, 0x20, 0xde, 0xd8, 0x45, 0xa0, 0xac, 0x80,
>>> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
>>> + 0x54, 0x8a, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
>>> + },
>>> + },
>>> + {
>>> .pixel_clock = 10650,
>>> .conf = {
>>> 0x01, 0xd1, 0x2c, 0x12, 0x40, 0x0c, 0x09, 0x08,
>>> @@ -349,6 +376,24 @@ static const struct hdmiphy_config
>>> hdmiphy_v14_configs[] = {
>>> },
>>> },
>>> {
>>> + .pixel_clock = 11550,
>>> + .conf = {
>>> + 0x01, 0xd1, 0x30, 0x1a, 0x40, 0x40, 0x10, 0x04,
>>> + 0x04, 0xa0, 0x21, 0xd9, 0x45, 0xa0, 0xac, 0x80,
>>> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
>>> + 0x54, 0xaa, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,
>>> + },
>>> + },
>>> + {
>>> + .pixel_clock = 11900,
>>
>>
>>
>> We have found that the 119MHz clock doesn't work in Chrome OS (the clock
>> doesn't stabilize), so we removed it. We should probably remove it here as
>> well.
>>
>> St?phane
>>
> I have informed this issue to the hardware team, and will update it
> once i receive
> any changes,
> Also i
>>> + .conf = {
>>> + 0x01, 0x91, 0x32, 0x14, 0x40, 0x60, 0xd8, 0x08,
>>> + 0x06, 0x20, 0x2a, 0xd9, 0x45, 0xa0, 0xac, 0x80,
>>> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
>>> + 0x54, 0x9d, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,
>>> + },
>>> + },
>>> + {
>>> .pixel_clock = 14625,
>>> .conf = {
>>> 0x01, 0xd1, 0x3d, 0x15, 0x40, 0x18, 0xfd, 0x08,
>>> --
>>> 1.7.10.4
>>>
>>> ___
>>> dri-devel mailing list
>>> dri-devel at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>>
>>
[PATCH] drm/exynos: add phy settings for RB resolutions
Hi,
Kindly hold the merging of this patch, i shall
update it with proper values, once i receive it from our hardware team.
Regards,
ShirisH S
On Thu, Mar 20, 2014 at 1:05 PM, St?phane Marchesin
wrote:
>
>
>
> On Wed, Mar 12, 2014 at 10:28 PM, Shirish S wrote:
>>
>> This patch adds support for the below mentioned
>> pixel clocks in Exynos5250.
>> Without them, following display modes won't
>> be supported:
>>
>> 71 MHz - 1280x800 at 60Hz RB
>> 73.25 MHz - 800x600 at 120Hz RB
>> 88.75 MHz - 1440x900 at 60Hz RB
>> 115.5 MHz - 1024x768 at 120Hz RB
>> 119 MHz - 1680x1050 at 60Hz RB
>>
>> Signed-off-by: Shirish S
>> ---
>> V2: Incorporated review comments
>>
>> drivers/gpu/drm/exynos/exynos_hdmi.c | 45
>> ++
>> 1 file changed, 45 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
>> b/drivers/gpu/drm/exynos/exynos_hdmi.c
>> index 12fdf55..406d89d 100644
>> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
>> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
>> @@ -304,6 +304,24 @@ static const struct hdmiphy_config
>> hdmiphy_v14_configs[] = {
>> },
>> },
>> {
>> + .pixel_clock = 7100,
>> + .conf = {
>> + 0x01, 0x91, 0x1e, 0x15, 0x40, 0x3c, 0xce, 0x08,
>> + 0x04, 0x20, 0xb2, 0xd8, 0x45, 0xa0, 0xac, 0x80,
>> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
>> + 0x54, 0xad, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
>> + },
>> + },
>> + {
>> + .pixel_clock = 7325,
>> + .conf = {
>> + 0x01, 0xd1, 0x1f, 0x15, 0x40, 0x18, 0xe9, 0x08,
>> + 0x02, 0xa0, 0xb7, 0xd8, 0x45, 0xa0, 0xac, 0x80,
>> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
>> + 0x54, 0xa8, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
>> + },
>> + },
>> + {
>> .pixel_clock = 74176000,
>> .conf = {
>> 0x01, 0xd1, 0x3e, 0x35, 0x40, 0x5b, 0xde, 0x08,
>> @@ -331,6 +349,15 @@ static const struct hdmiphy_config
>> hdmiphy_v14_configs[] = {
>> },
>> },
>> {
>> + .pixel_clock = 8875,
>> + .conf = {
>> + 0x01, 0x91, 0x25, 0x17, 0x40, 0x30, 0xfe, 0x08,
>> + 0x06, 0x20, 0xde, 0xd8, 0x45, 0xa0, 0xac, 0x80,
>> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
>> + 0x54, 0x8a, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
>> + },
>> + },
>> + {
>> .pixel_clock = 10650,
>> .conf = {
>> 0x01, 0xd1, 0x2c, 0x12, 0x40, 0x0c, 0x09, 0x08,
>> @@ -349,6 +376,24 @@ static const struct hdmiphy_config
>> hdmiphy_v14_configs[] = {
>> },
>> },
>> {
>> + .pixel_clock = 11550,
>> + .conf = {
>> + 0x01, 0xd1, 0x30, 0x1a, 0x40, 0x40, 0x10, 0x04,
>> + 0x04, 0xa0, 0x21, 0xd9, 0x45, 0xa0, 0xac, 0x80,
>> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
>> + 0x54, 0xaa, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,
>> + },
>> + },
>> + {
>> + .pixel_clock = 11900,
>
>
>
> We have found that the 119MHz clock doesn't work in Chrome OS (the clock
> doesn't stabilize), so we removed it. We should probably remove it here as
> well.
>
> St?phane
>
I have informed this issue to the hardware team, and will update it
once i receive
any changes,
Also i
>> + .conf = {
>> + 0x01, 0x91, 0x32, 0x14, 0x40, 0x60, 0xd8, 0x08,
>> + 0x06, 0x20, 0x2a, 0xd9, 0x45, 0xa0, 0xac, 0x80,
>> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
>> + 0x54, 0x9d, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,
>> + },
>> + },
>> + {
>> .pixel_clock = 14625,
>> .conf = {
>> 0x01, 0xd1, 0x3d, 0x15, 0x40, 0x18, 0xfd, 0x08,
>> --
>> 1.7.10.4
>>
>> ___
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
[PATCH] drm/exynos: add phy settings for RB resolutions
On Wed, Mar 12, 2014 at 10:28 PM, Shirish S wrote:
> This patch adds support for the below mentioned
> pixel clocks in Exynos5250.
> Without them, following display modes won't
> be supported:
>
> 71 MHz - 1280x800 at 60Hz RB
> 73.25 MHz - 800x600 at 120Hz RB
> 88.75 MHz - 1440x900 at 60Hz RB
> 115.5 MHz - 1024x768 at 120Hz RB
> 119 MHz - 1680x1050 at 60Hz RB
>
> Signed-off-by: Shirish S
> ---
> V2: Incorporated review comments
>
> drivers/gpu/drm/exynos/exynos_hdmi.c | 45
> ++
> 1 file changed, 45 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
> b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 12fdf55..406d89d 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -304,6 +304,24 @@ static const struct hdmiphy_config
> hdmiphy_v14_configs[] = {
> },
> },
> {
> + .pixel_clock = 7100,
> + .conf = {
> + 0x01, 0x91, 0x1e, 0x15, 0x40, 0x3c, 0xce, 0x08,
> + 0x04, 0x20, 0xb2, 0xd8, 0x45, 0xa0, 0xac, 0x80,
> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
> + 0x54, 0xad, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
> + },
> + },
> + {
> + .pixel_clock = 7325,
> + .conf = {
> + 0x01, 0xd1, 0x1f, 0x15, 0x40, 0x18, 0xe9, 0x08,
> + 0x02, 0xa0, 0xb7, 0xd8, 0x45, 0xa0, 0xac, 0x80,
> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
> + 0x54, 0xa8, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
> + },
> + },
> + {
> .pixel_clock = 74176000,
> .conf = {
> 0x01, 0xd1, 0x3e, 0x35, 0x40, 0x5b, 0xde, 0x08,
> @@ -331,6 +349,15 @@ static const struct hdmiphy_config
> hdmiphy_v14_configs[] = {
> },
> },
> {
> + .pixel_clock = 8875,
> + .conf = {
> + 0x01, 0x91, 0x25, 0x17, 0x40, 0x30, 0xfe, 0x08,
> + 0x06, 0x20, 0xde, 0xd8, 0x45, 0xa0, 0xac, 0x80,
> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
> + 0x54, 0x8a, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
> + },
> + },
> + {
> .pixel_clock = 10650,
> .conf = {
> 0x01, 0xd1, 0x2c, 0x12, 0x40, 0x0c, 0x09, 0x08,
> @@ -349,6 +376,24 @@ static const struct hdmiphy_config
> hdmiphy_v14_configs[] = {
> },
> },
> {
> + .pixel_clock = 11550,
> + .conf = {
> + 0x01, 0xd1, 0x30, 0x1a, 0x40, 0x40, 0x10, 0x04,
> + 0x04, 0xa0, 0x21, 0xd9, 0x45, 0xa0, 0xac, 0x80,
> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
> + 0x54, 0xaa, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,
> + },
> + },
> + {
> + .pixel_clock = 11900,
>
We have found that the 119MHz clock doesn't work in Chrome OS (the clock
doesn't stabilize), so we removed it. We should probably remove it here as
well.
St?phane
+ .conf = {
> + 0x01, 0x91, 0x32, 0x14, 0x40, 0x60, 0xd8, 0x08,
> + 0x06, 0x20, 0x2a, 0xd9, 0x45, 0xa0, 0xac, 0x80,
> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
> + 0x54, 0x9d, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,
> + },
> + },
> + {
> .pixel_clock = 14625,
> .conf = {
> 0x01, 0xd1, 0x3d, 0x15, 0x40, 0x18, 0xfd, 0x08,
> --
> 1.7.10.4
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
-- next part --
An HTML attachment was scrubbed...
URL:
[PATCH] drm/exynos: add phy settings for RB resolutions
Applied.
Thanks,
Inki Dae
2014-03-13 14:28 GMT+09:00 Shirish S :
> This patch adds support for the below mentioned
> pixel clocks in Exynos5250.
> Without them, following display modes won't
> be supported:
>
> 71 MHz - 1280x800 at 60Hz RB
> 73.25 MHz - 800x600 at 120Hz RB
> 88.75 MHz - 1440x900 at 60Hz RB
> 115.5 MHz - 1024x768 at 120Hz RB
> 119 MHz - 1680x1050 at 60Hz RB
>
> Signed-off-by: Shirish S
> ---
> V2: Incorporated review comments
>
> drivers/gpu/drm/exynos/exynos_hdmi.c | 45
> ++
> 1 file changed, 45 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
> b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 12fdf55..406d89d 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -304,6 +304,24 @@ static const struct hdmiphy_config hdmiphy_v14_configs[]
> = {
> },
> },
> {
> + .pixel_clock = 7100,
> + .conf = {
> + 0x01, 0x91, 0x1e, 0x15, 0x40, 0x3c, 0xce, 0x08,
> + 0x04, 0x20, 0xb2, 0xd8, 0x45, 0xa0, 0xac, 0x80,
> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
> + 0x54, 0xad, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
> + },
> + },
> + {
> + .pixel_clock = 7325,
> + .conf = {
> + 0x01, 0xd1, 0x1f, 0x15, 0x40, 0x18, 0xe9, 0x08,
> + 0x02, 0xa0, 0xb7, 0xd8, 0x45, 0xa0, 0xac, 0x80,
> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
> + 0x54, 0xa8, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
> + },
> + },
> + {
> .pixel_clock = 74176000,
> .conf = {
> 0x01, 0xd1, 0x3e, 0x35, 0x40, 0x5b, 0xde, 0x08,
> @@ -331,6 +349,15 @@ static const struct hdmiphy_config hdmiphy_v14_configs[]
> = {
> },
> },
> {
> + .pixel_clock = 8875,
> + .conf = {
> + 0x01, 0x91, 0x25, 0x17, 0x40, 0x30, 0xfe, 0x08,
> + 0x06, 0x20, 0xde, 0xd8, 0x45, 0xa0, 0xac, 0x80,
> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
> + 0x54, 0x8a, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
> + },
> + },
> + {
> .pixel_clock = 10650,
> .conf = {
> 0x01, 0xd1, 0x2c, 0x12, 0x40, 0x0c, 0x09, 0x08,
> @@ -349,6 +376,24 @@ static const struct hdmiphy_config hdmiphy_v14_configs[]
> = {
> },
> },
> {
> + .pixel_clock = 11550,
> + .conf = {
> + 0x01, 0xd1, 0x30, 0x1a, 0x40, 0x40, 0x10, 0x04,
> + 0x04, 0xa0, 0x21, 0xd9, 0x45, 0xa0, 0xac, 0x80,
> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
> + 0x54, 0xaa, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,
> + },
> + },
> + {
> + .pixel_clock = 11900,
> + .conf = {
> + 0x01, 0x91, 0x32, 0x14, 0x40, 0x60, 0xd8, 0x08,
> + 0x06, 0x20, 0x2a, 0xd9, 0x45, 0xa0, 0xac, 0x80,
> + 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
> + 0x54, 0x9d, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,
> + },
> + },
> + {
> .pixel_clock = 14625,
> .conf = {
> 0x01, 0xd1, 0x3d, 0x15, 0x40, 0x18, 0xfd, 0x08,
> --
> 1.7.10.4
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/exynos: add phy settings for RB resolutions
Hi Shirish, On 13.03.2014 06:28, Shirish S wrote: > This patch adds support for the below mentioned > pixel clocks in Exynos5250. > Without them, following display modes won?t > be supported: > > 71 MHz- 1280x800 at 60Hz RB > 73.25 MHz - 800x600 at 120Hz RB > 88.75 MHz - 1440x900 at 60Hz RB > 115.5 MHz - 1024x768 at 120Hz RB > 119 MHz - 1680x1050 at 60Hz RB > > Signed-off-by: Shirish S > --- > V2: Incorporated review comments > > drivers/gpu/drm/exynos/exynos_hdmi.c | 45 > ++ > 1 file changed, 45 insertions(+) Reviewed-by: Tomasz Figa Best regards, Tomasz
[PATCH] drm/exynos: add phy settings for RB resolutions
This patch adds support for the below mentioned
pixel clocks in Exynos5250.
Without them, following display modes won?t
be supported:
71 MHz - 1280x800 at 60Hz RB
73.25 MHz - 800x600 at 120Hz RB
88.75 MHz - 1440x900 at 60Hz RB
115.5 MHz - 1024x768 at 120Hz RB
119 MHz - 1680x1050 at 60Hz RB
Signed-off-by: Shirish S
---
V2: Incorporated review comments
drivers/gpu/drm/exynos/exynos_hdmi.c | 45 ++
1 file changed, 45 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 12fdf55..406d89d 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -304,6 +304,24 @@ static const struct hdmiphy_config hdmiphy_v14_configs[] =
{
},
},
{
+ .pixel_clock = 7100,
+ .conf = {
+ 0x01, 0x91, 0x1e, 0x15, 0x40, 0x3c, 0xce, 0x08,
+ 0x04, 0x20, 0xb2, 0xd8, 0x45, 0xa0, 0xac, 0x80,
+ 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
+ 0x54, 0xad, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
+ },
+ },
+ {
+ .pixel_clock = 7325,
+ .conf = {
+ 0x01, 0xd1, 0x1f, 0x15, 0x40, 0x18, 0xe9, 0x08,
+ 0x02, 0xa0, 0xb7, 0xd8, 0x45, 0xa0, 0xac, 0x80,
+ 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
+ 0x54, 0xa8, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
+ },
+ },
+ {
.pixel_clock = 74176000,
.conf = {
0x01, 0xd1, 0x3e, 0x35, 0x40, 0x5b, 0xde, 0x08,
@@ -331,6 +349,15 @@ static const struct hdmiphy_config hdmiphy_v14_configs[] =
{
},
},
{
+ .pixel_clock = 8875,
+ .conf = {
+ 0x01, 0x91, 0x25, 0x17, 0x40, 0x30, 0xfe, 0x08,
+ 0x06, 0x20, 0xde, 0xd8, 0x45, 0xa0, 0xac, 0x80,
+ 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
+ 0x54, 0x8a, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
+ },
+ },
+ {
.pixel_clock = 10650,
.conf = {
0x01, 0xd1, 0x2c, 0x12, 0x40, 0x0c, 0x09, 0x08,
@@ -349,6 +376,24 @@ static const struct hdmiphy_config hdmiphy_v14_configs[] =
{
},
},
{
+ .pixel_clock = 11550,
+ .conf = {
+ 0x01, 0xd1, 0x30, 0x1a, 0x40, 0x40, 0x10, 0x04,
+ 0x04, 0xa0, 0x21, 0xd9, 0x45, 0xa0, 0xac, 0x80,
+ 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
+ 0x54, 0xaa, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,
+ },
+ },
+ {
+ .pixel_clock = 11900,
+ .conf = {
+ 0x01, 0x91, 0x32, 0x14, 0x40, 0x60, 0xd8, 0x08,
+ 0x06, 0x20, 0x2a, 0xd9, 0x45, 0xa0, 0xac, 0x80,
+ 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
+ 0x54, 0x9d, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,
+ },
+ },
+ {
.pixel_clock = 14625,
.conf = {
0x01, 0xd1, 0x3d, 0x15, 0x40, 0x18, 0xfd, 0x08,
--
1.7.10.4
[PATCH] drm/exynos: add phy settings for RB resolutions
Hi Tomasz,
Thanks for the review comments,
On Wed, Mar 12, 2014 at 8:26 AM, Tomasz Figa wrote:
>
> Hi Shirish,
>
>
> On 10.03.2014 15:17, Shirish S wrote:
>>
>> below is list of pixel clocks and resoluitons
>> this patch adds:
>>
>> 7100 - 1280x800 at 60Hz RB
>> 7325 - 800x600 at 120Hz RB
>> 8875 - 1440x900 at 60Hz RB
>> 11550 - 1024x768 at 120Hz RB
>> 11900 - 1680x1050 at 60Hz RB
>>
>> without these pixel clocks' support the mentioned
>> resolutions fail to be detected in exynos5250.
>
>
> This commit message is poorly written. Please start sentences with capital
> letters and check spelling before sending.
>
> Here follows an example of commit message for this patch:
>
> 8<---
>
> This patch adds several new pixel clock settings for HDMI PHY v14
> (Exynos5250). Without them following display modes cannot be supported:
>
> 7100 Hz - 1280x800 at 60Hz RB
> 7325 Hz - 800x600 at 120Hz RB
> 8875 Hz - 1440x900 at 60Hz RB
> 11550 Hz - 1024x768 at 120Hz RB
> 11900 Hz - 1680x1050 at 60Hz RB
>
> --->8
>
>
agreed, have updated it in the next patchset
>>
>> Signed-off-by: Shirish S
>> ---
>> drivers/gpu/drm/exynos/exynos_hdmi.c | 45
>> ++
>> 1 file changed, 45 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
>> b/drivers/gpu/drm/exynos/exynos_hdmi.c
>> index c021ddc..650ce48 100644
>> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
>> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
>> @@ -303,6 +303,24 @@ static const struct hdmiphy_config
>> hdmiphy_v14_configs[] = {
>> },
>> },
>> {
>> + .pixel_clock = 7100,
>> + .conf = {
>> + 0x01, 0x91, 0x1E, 0x15, 0x40, 0x3C, 0xCE, 0x08,
>
>
> Lowercase is preferred by kernel coding style for hexadecimal values.
Done.
>
> Best regards,
> Tomasz
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
Thanks & Regards,
Shirish S
[PATCH] drm/exynos: add phy settings for RB resolutions
Hi Shirish,
On 10.03.2014 15:17, Shirish S wrote:
> below is list of pixel clocks and resoluitons
> this patch adds:
>
> 7100 - 1280x800 at 60Hz RB
> 7325 - 800x600 at 120Hz RB
> 8875 - 1440x900 at 60Hz RB
> 11550 - 1024x768 at 120Hz RB
> 11900 - 1680x1050 at 60Hz RB
>
> without these pixel clocks' support the mentioned
> resolutions fail to be detected in exynos5250.
This commit message is poorly written. Please start sentences with
capital letters and check spelling before sending.
Here follows an example of commit message for this patch:
8<---
This patch adds several new pixel clock settings for HDMI PHY v14
(Exynos5250). Without them following display modes cannot be supported:
7100 Hz - 1280x800 at 60Hz RB
7325 Hz - 800x600 at 120Hz RB
8875 Hz - 1440x900 at 60Hz RB
11550 Hz - 1024x768 at 120Hz RB
11900 Hz - 1680x1050 at 60Hz RB
--->8
>
> Signed-off-by: Shirish S
> ---
> drivers/gpu/drm/exynos/exynos_hdmi.c | 45
> ++
> 1 file changed, 45 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
> b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index c021ddc..650ce48 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -303,6 +303,24 @@ static const struct hdmiphy_config hdmiphy_v14_configs[]
> = {
> },
> },
> {
> + .pixel_clock = 7100,
> + .conf = {
> + 0x01, 0x91, 0x1E, 0x15, 0x40, 0x3C, 0xCE, 0x08,
Lowercase is preferred by kernel coding style for hexadecimal values.
Best regards,
Tomasz
[PATCH] drm/exynos: add phy settings for RB resolutions
below is list of pixel clocks and resoluitons
this patch adds:
7100 - 1280x800 at 60Hz RB
7325 - 800x600 at 120Hz RB
8875 - 1440x900 at 60Hz RB
11550 - 1024x768 at 120Hz RB
11900 - 1680x1050 at 60Hz RB
without these pixel clocks' support the mentioned
resolutions fail to be detected in exynos5250.
Signed-off-by: Shirish S
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 45 ++
1 file changed, 45 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index c021ddc..650ce48 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -303,6 +303,24 @@ static const struct hdmiphy_config hdmiphy_v14_configs[] =
{
},
},
{
+ .pixel_clock = 7100,
+ .conf = {
+ 0x01, 0x91, 0x1E, 0x15, 0x40, 0x3C, 0xCE, 0x08,
+ 0x04, 0x20, 0xB2, 0xD8, 0x45, 0xA0, 0xAC, 0x80,
+ 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
+ 0x54, 0xAD, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
+ },
+ },
+ {
+ .pixel_clock = 7325,
+ .conf = {
+ 0x01, 0xD1, 0x1F, 0x15, 0x40, 0x18, 0xE9, 0x08,
+ 0x02, 0xA0, 0xB7, 0xD8, 0x45, 0xA0, 0xAC, 0x80,
+ 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
+ 0x54, 0xA8, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
+ },
+ },
+ {
.pixel_clock = 74176000,
.conf = {
0x01, 0xd1, 0x3e, 0x35, 0x40, 0x5b, 0xde, 0x08,
@@ -330,6 +348,15 @@ static const struct hdmiphy_config hdmiphy_v14_configs[] =
{
},
},
{
+ .pixel_clock = 8875,
+ .conf = {
+ 0x01, 0x91, 0x25, 0x17, 0x40, 0x30, 0xFE, 0x08,
+ 0x06, 0x20, 0xDE, 0xD8, 0x45, 0xA0, 0xAC, 0x80,
+ 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
+ 0x54, 0x8A, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,
+ },
+ },
+ {
.pixel_clock = 10650,
.conf = {
0x01, 0xd1, 0x2c, 0x12, 0x40, 0x0c, 0x09, 0x08,
@@ -348,6 +375,24 @@ static const struct hdmiphy_config hdmiphy_v14_configs[] =
{
},
},
{
+ .pixel_clock = 11550,
+ .conf = {
+ 0x01, 0xD1, 0x30, 0x1A, 0x40, 0x40, 0x10, 0x04,
+ 0x04, 0xA0, 0x21, 0xD9, 0x45, 0xA0, 0xAC, 0x80,
+ 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
+ 0x54, 0xAA, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,
+ },
+ },
+ {
+ .pixel_clock = 11900,
+ .conf = {
+ 0x01, 0x91, 0x32, 0x14, 0x40, 0x60, 0xD8, 0x08,
+ 0x06, 0x20, 0x2A, 0xD9, 0x45, 0xA0, 0xAC, 0x80,
+ 0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,
+ 0x54, 0x9D, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,
+ },
+ },
+ {
.pixel_clock = 14625,
.conf = {
0x01, 0xd1, 0x3d, 0x15, 0x40, 0x18, 0xfd, 0x08,
--
1.7.10.4
