[PATCH] drm/exynos: fix nested calls to lock mutex in drm resume
On 22 May 2014 23:26, Sachin Kamat wrote: > Hi Rahul, > > On 22 May 2014 19:46, Rahul Sharma wrote: >> Hi Inki, >> >> This is another one which has not got reviewed. Please review. > > Inki has applied a similar patch from Takashi [1]. Thanks Sachin, Good that solution is merged. @ Inki, sorry for raising concern. It went unnoticed. Regards, Rahul Sharma. > > [1] https://lkml.org/lkml/2014/5/9/24 > > -- > With warm regards, > Sachin
[PATCH] drm/exynos: fix nested calls to lock mutex in drm resume
add Mr. Dae On Thu, May 22, 2014 at 11:16 PM, Rahul Sharma wrote: > Hi Inki, > > This is another one which has not got reviewed. Please review. > > Regards, > Rahul Sharma > > On 30 April 2014 19:11, Rahul Sharma wrote: >> From: Rahul Sharma >> >> While testing S2R on exynos board, system is hanging and >> rebooting due to nested mutex_lock calls in exynos drm >> resume callback. Changing the order of the calls is fixing >> the issue. >> >> Signed-off-by: Rahul Sharma >> --- >> Based on exynos-drm-next branch in Inki Dae's tree. >> drivers/gpu/drm/exynos/exynos_drm_drv.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c >> b/drivers/gpu/drm/exynos/exynos_drm_drv.c >> index bb7dfee..2bb6233 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c >> @@ -184,8 +184,8 @@ static int exynos_drm_resume(struct drm_device *dev) >> connector->funcs->dpms(connector, connector->dpms); >> } >> >> - drm_helper_resume_force_mode(dev); >> drm_modeset_unlock_all(dev); >> + drm_helper_resume_force_mode(dev); >> >> return 0; >> } >> -- >> 1.7.9.5 >> > ___ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/exynos: fix nested calls to lock mutex in drm resume
Hi Rahul, On 22 May 2014 19:46, Rahul Sharma wrote: > Hi Inki, > > This is another one which has not got reviewed. Please review. Inki has applied a similar patch from Takashi [1]. [1] https://lkml.org/lkml/2014/5/9/24 -- With warm regards, Sachin
[PATCH] drm/exynos: fix nested calls to lock mutex in drm resume
Hi Inki, This is another one which has not got reviewed. Please review. Regards, Rahul Sharma On 30 April 2014 19:11, Rahul Sharma wrote: > From: Rahul Sharma > > While testing S2R on exynos board, system is hanging and > rebooting due to nested mutex_lock calls in exynos drm > resume callback. Changing the order of the calls is fixing > the issue. > > Signed-off-by: Rahul Sharma > --- > Based on exynos-drm-next branch in Inki Dae's tree. > drivers/gpu/drm/exynos/exynos_drm_drv.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c > b/drivers/gpu/drm/exynos/exynos_drm_drv.c > index bb7dfee..2bb6233 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c > @@ -184,8 +184,8 @@ static int exynos_drm_resume(struct drm_device *dev) > connector->funcs->dpms(connector, connector->dpms); > } > > - drm_helper_resume_force_mode(dev); > drm_modeset_unlock_all(dev); > + drm_helper_resume_force_mode(dev); > > return 0; > } > -- > 1.7.9.5 >
[PATCH] drm/exynos: fix nested calls to lock mutex in drm resume
From: Rahul Sharma While testing S2R on exynos board, system is hanging and rebooting due to nested mutex_lock calls in exynos drm resume callback. Changing the order of the calls is fixing the issue. Signed-off-by: Rahul Sharma --- Based on exynos-drm-next branch in Inki Dae's tree. drivers/gpu/drm/exynos/exynos_drm_drv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index bb7dfee..2bb6233 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -184,8 +184,8 @@ static int exynos_drm_resume(struct drm_device *dev) connector->funcs->dpms(connector, connector->dpms); } - drm_helper_resume_force_mode(dev); drm_modeset_unlock_all(dev); + drm_helper_resume_force_mode(dev); return 0; } -- 1.7.9.5
[PATCH] drm/exynos: fix nested calls to lock mutex in drm resume
From: Rahul Sharma While testing S2R on exynos board, system is hanging and rebooting due to nested mutex_lock calls in exynos drm resume callback. Changing the order of the calls is fixing the issue. Change-Id: I3f3ada8a413a414dca0bbac53cfc5fe3138af4d6 Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_drm_drv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index bb7dfee..2bb6233 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -184,8 +184,8 @@ static int exynos_drm_resume(struct drm_device *dev) connector->funcs->dpms(connector, connector->dpms); } - drm_helper_resume_force_mode(dev); drm_modeset_unlock_all(dev); + drm_helper_resume_force_mode(dev); return 0; } -- 1.7.9.5
