Re: [PATCH] drm/fb-helper: disallow if DRM=y and FB=m

2021-09-13 Thread Sam Ravnborg
Hi Adam,

On Sun, Sep 12, 2021 at 11:00:54PM +0200, Adam Borowski wrote:
> A subfeature of a built-in can't depend on a module.

Maybe I am a bit dense this morning, but I do not really see what error
this fixes. Can you elaborate a bit what situations are fixed by this
patch.

Thanks in advance,

Sam

> 
> Signed-off-by: Adam Borowski 
> ---
>  drivers/gpu/drm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index cea777ae7fb9..75a5a9359d4b 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -103,7 +103,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS
>  config DRM_FBDEV_EMULATION
>   bool "Enable legacy fbdev support for your modesetting driver"
>   depends on DRM
> - depends on FB
> + depends on FB >= DRM
>   select DRM_KMS_HELPER
>   select FB_CFB_FILLRECT
>   select FB_CFB_COPYAREA
> -- 
> 2.33.0


[PATCH] drm/fb-helper: disallow if DRM=y and FB=m

2021-09-12 Thread Adam Borowski
A subfeature of a built-in can't depend on a module.

Signed-off-by: Adam Borowski 
---
 drivers/gpu/drm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index cea777ae7fb9..75a5a9359d4b 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -103,7 +103,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS
 config DRM_FBDEV_EMULATION
bool "Enable legacy fbdev support for your modesetting driver"
depends on DRM
-   depends on FB
+   depends on FB >= DRM
select DRM_KMS_HELPER
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
-- 
2.33.0