Re: [PATCH] drm/i915: fixup dma_fence_wait usage

[Thomas Hellström]

On 11/2/21 16:50, Matthew Auld wrote:

dma_fence_wait expects a boolean for whether it should be interruptible,
not a timeout value.

Signed-off-by: Matthew Auld 
Cc: Thomas Hellström 
---
  drivers/gpu/drm/i915/i915_vma.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 90546fa58fc1..8781c4f61952 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -349,7 +349,7 @@ int i915_vma_wait_for_bind(struct i915_vma *vma)
fence = dma_fence_get_rcu_safe(>active.excl.fence);
rcu_read_unlock();
if (fence) {
-   err = dma_fence_wait(fence, MAX_SCHEDULE_TIMEOUT);
+   err = dma_fence_wait(fence, true);
dma_fence_put(fence);
}
}


LGTM. Reviewed-by: Thomas Hellström 

[PATCH] drm/i915: fixup dma_fence_wait usage

[Matthew Auld]

dma_fence_wait expects a boolean for whether it should be interruptible,
not a timeout value.

Signed-off-by: Matthew Auld 
Cc: Thomas Hellström 
---
 drivers/gpu/drm/i915/i915_vma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 90546fa58fc1..8781c4f61952 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -349,7 +349,7 @@ int i915_vma_wait_for_bind(struct i915_vma *vma)
fence = dma_fence_get_rcu_safe(>active.excl.fence);
rcu_read_unlock();
if (fence) {
-   err = dma_fence_wait(fence, MAX_SCHEDULE_TIMEOUT);
+   err = dma_fence_wait(fence, true);
dma_fence_put(fence);
}
}
-- 
2.31.1