Re: BAD -- Patch "drm/mgag200: Flag all G200 SE A machines as broken wrt " has been added to the 5.4-stable tree
Hi
I am having difficulties with this patch on : 5.4.2 variant ; The system is
not booting with these patches applied.
I had verified a prototype of the patch on 5.4.0-rc8 ;
I am currently debugging it , but I will be OoO until 1/6/2020 after today .
> On Dec 19, 2019, at 5:37 AM, gre...@linuxfoundation.org wrote:
>
>
> This is a note to let you know that I've just added the patch titled
>
>drm/mgag200: Flag all G200 SE A machines as broken wrt
>
> to the 5.4-stable tree which can be found at:
>
> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.kernel.org_git_-3Fp-3Dlinux_kernel_git_stable_stable-2Dqueue.git-3Ba-3Dsummary=DwIDaQ=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE=t2fPg9D87F7D8jm0_3CG9yoiIKdRg4qc_thBw4bzMhc=Nb5EnzCYEqUCU43_FPM930DrN6A-OrVBoIvQhl3A6xo=mqHE1ETbyuc9Qg_WHNUzDRBGo073QFCYwTAxpxXEQJU=
>
>
> The filename of the patch is:
> drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
> and it can be found in the queue-5.4 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let know about it.
>
>
> From 4adf0b49eea926a55fd956ef7d86750f771435ff Mon Sep 17 00:00:00 2001
> From: Thomas Zimmermann
> Date: Fri, 6 Dec 2019 09:19:01 +0100
> Subject: drm/mgag200: Flag all G200 SE A machines as broken wrt
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> From: Thomas Zimmermann
>
> commit 4adf0b49eea926a55fd956ef7d86750f771435ff upstream.
>
> Several MGA G200 SE machines don't respect the value of the startadd
> register field. After more feedback on affected machines, neither PCI
> subvendor ID nor the internal ID seem to hint towards the bug. All
> affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was
> decided to flag all G200 SE A machines as broken.
>
> Signed-off-by: Thomas Zimmermann
> Acked-by: Gerd Hoffmann
> Fixes: 1591fadf857c ("drm/mgag200: Add workaround for HW that does not
> support 'startadd'")
> Cc: Thomas Zimmermann
> Cc: John Donnelly
> Cc: Daniel Vetter
> Cc: Gerd Hoffmann
> Cc: Dave Airlie
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: David Airlie
> Cc: Sam Ravnborg
> Cc: "Y.C. Chen"
> Cc: Neil Armstrong
> Cc: Thomas Gleixner
> Cc: "José Roberto de Souza"
> Cc: Andrzej Pietrasiewicz
> Cc: dri-devel@lists.freedesktop.org
> Cc: # v5.3+
> Cc: Greg Kroah-Hartman
> Cc: Allison Randal
> Cc: Alex Deucher
> Cc: "Noralf Trønnes"
> Link:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.freedesktop.org_patch_msgid_20191206081901.9938-2D1-2Dtzimmermann-40suse.de=DwIDaQ=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE=t2fPg9D87F7D8jm0_3CG9yoiIKdRg4qc_thBw4bzMhc=Nb5EnzCYEqUCU43_FPM930DrN6A-OrVBoIvQhl3A6xo=hkr0WOmd31sveBOYMZnLk8Sb2ujD-JxnYwjeSLBw9cA=
>
> Signed-off-by: Greg Kroah-Hartman
>
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.c |3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -30,9 +30,8 @@ module_param_named(modeset, mgag200_mode
> static struct drm_driver driver;
>
> static const struct pci_device_id pciidlist[] = {
> - { PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
> + { PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
> - { PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A
> },
> { PCI_VENDOR_ID_MATROX, 0x524, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_B
> },
> { PCI_VENDOR_ID_MATROX, 0x530, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_EV },
> { PCI_VENDOR_ID_MATROX, 0x532, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_WB },
>
>
> Patches currently in stable-queue which might be from tzimmerm...@suse.de are
>
> queue-5.4/drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
> queue-5.4/drm-mgag200-store-flags-from-pci-driver-data-in-device-structure.patch
> queue-5.4/drm-mgag200-add-workaround-for-hw-that-does-not-support-startadd.patch
> queue-5.4/drm-mgag200-extract-device-type-from-flags.patch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: IGNORE -- Patch "drm/mgag200: Flag all G200 SE A machines as broken wrt " has been added to the 5.4-stable tree
I discovered I was missing a commit when I merged .
This series is fine .
> On Dec 19, 2019, at 12:24 PM, John Donnelly
> wrote:
>
> Hi
>
> I am having difficulties with this patch on : 5.4.2 variant ; The system is
> not booting with these patches applied.
>
> I had verified a prototype of the patch on 5.4.0-rc8 ;
>
> I am currently debugging it , but I will be OoO until 1/6/2020 after today .
>
>
>
>
>
>
>
>
>
>
>> On Dec 19, 2019, at 5:37 AM, gre...@linuxfoundation.org wrote:
>>
>>
>> This is a note to let you know that I've just added the patch titled
>>
>> drm/mgag200: Flag all G200 SE A machines as broken wrt
>>
>> to the 5.4-stable tree which can be found at:
>>
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.kernel.org_git_-3Fp-3Dlinux_kernel_git_stable_stable-2Dqueue.git-3Ba-3Dsummary=DwIDaQ=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE=t2fPg9D87F7D8jm0_3CG9yoiIKdRg4qc_thBw4bzMhc=Nb5EnzCYEqUCU43_FPM930DrN6A-OrVBoIvQhl3A6xo=mqHE1ETbyuc9Qg_WHNUzDRBGo073QFCYwTAxpxXEQJU=
>>
>>
>> The filename of the patch is:
>>drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
>> and it can be found in the queue-5.4 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let know about it.
>>
>>
>> From 4adf0b49eea926a55fd956ef7d86750f771435ff Mon Sep 17 00:00:00 2001
>> From: Thomas Zimmermann
>> Date: Fri, 6 Dec 2019 09:19:01 +0100
>> Subject: drm/mgag200: Flag all G200 SE A machines as broken wrt
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> From: Thomas Zimmermann
>>
>> commit 4adf0b49eea926a55fd956ef7d86750f771435ff upstream.
>>
>> Several MGA G200 SE machines don't respect the value of the startadd
>> register field. After more feedback on affected machines, neither PCI
>> subvendor ID nor the internal ID seem to hint towards the bug. All
>> affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was
>> decided to flag all G200 SE A machines as broken.
>>
>> Signed-off-by: Thomas Zimmermann
>> Acked-by: Gerd Hoffmann
>> Fixes: 1591fadf857c ("drm/mgag200: Add workaround for HW that does not
>> support 'startadd'")
>> Cc: Thomas Zimmermann
>> Cc: John Donnelly
>> Cc: Daniel Vetter
>> Cc: Gerd Hoffmann
>> Cc: Dave Airlie
>> Cc: Maarten Lankhorst
>> Cc: Maxime Ripard
>> Cc: David Airlie
>> Cc: Sam Ravnborg
>> Cc: "Y.C. Chen"
>> Cc: Neil Armstrong
>> Cc: Thomas Gleixner
>> Cc: "José Roberto de Souza"
>> Cc: Andrzej Pietrasiewicz
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: # v5.3+
>> Cc: Greg Kroah-Hartman
>> Cc: Allison Randal
>> Cc: Alex Deucher
>> Cc: "Noralf Trønnes"
>> Link:
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.freedesktop.org_patch_msgid_20191206081901.9938-2D1-2Dtzimmermann-40suse.de=DwIDaQ=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE=t2fPg9D87F7D8jm0_3CG9yoiIKdRg4qc_thBw4bzMhc=Nb5EnzCYEqUCU43_FPM930DrN6A-OrVBoIvQhl3A6xo=hkr0WOmd31sveBOYMZnLk8Sb2ujD-JxnYwjeSLBw9cA=
>>
>> Signed-off-by: Greg Kroah-Hartman
>>
>> ---
>> drivers/gpu/drm/mgag200/mgag200_drv.c |3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
>> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
>> @@ -30,9 +30,8 @@ module_param_named(modeset, mgag200_mode
>> static struct drm_driver driver;
>>
>> static const struct pci_device_id pciidlist[] = {
>> -{ PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
>> +{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
>> G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
>> -{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A
>> },
>> { PCI_VENDOR_ID_MATROX, 0x524, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_B
>> },
>> { PCI_VENDOR_ID_MATROX, 0x530, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_EV },
>> { PCI_VENDOR_ID_MATROX, 0x532, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_WB },
>>
>>
>> Patches currently in stable-queue which might be from tzimmerm...@suse.de are
>>
>> queue-5.4/drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
>> queue-5.4/drm-mgag200-store-flags-from-pci-driver-data-in-device-structure.patch
>> queue-5.4/drm-mgag200-add-workaround-for-hw-that-does-not-support-startadd.patch
>> queue-5.4/drm-mgag200-extract-device-type-from-flags.patch
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patch "drm/mgag200: Flag all G200 SE A machines as broken wrt " has been added to the 5.4-stable tree
This is a note to let you know that I've just added the patch titled
drm/mgag200: Flag all G200 SE A machines as broken wrt
to the 5.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
and it can be found in the queue-5.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let know about it.
From 4adf0b49eea926a55fd956ef7d86750f771435ff Mon Sep 17 00:00:00 2001
From: Thomas Zimmermann
Date: Fri, 6 Dec 2019 09:19:01 +0100
Subject: drm/mgag200: Flag all G200 SE A machines as broken wrt
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Thomas Zimmermann
commit 4adf0b49eea926a55fd956ef7d86750f771435ff upstream.
Several MGA G200 SE machines don't respect the value of the startadd
register field. After more feedback on affected machines, neither PCI
subvendor ID nor the internal ID seem to hint towards the bug. All
affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was
decided to flag all G200 SE A machines as broken.
Signed-off-by: Thomas Zimmermann
Acked-by: Gerd Hoffmann
Fixes: 1591fadf857c ("drm/mgag200: Add workaround for HW that does not support
'startadd'")
Cc: Thomas Zimmermann
Cc: John Donnelly
Cc: Daniel Vetter
Cc: Gerd Hoffmann
Cc: Dave Airlie
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: David Airlie
Cc: Sam Ravnborg
Cc: "Y.C. Chen"
Cc: Neil Armstrong
Cc: Thomas Gleixner
Cc: "José Roberto de Souza"
Cc: Andrzej Pietrasiewicz
Cc: dri-devel@lists.freedesktop.org
Cc: # v5.3+
Cc: Greg Kroah-Hartman
Cc: Allison Randal
Cc: Alex Deucher
Cc: "Noralf Trønnes"
Link:
https://patchwork.freedesktop.org/patch/msgid/20191206081901.9938-1-tzimmerm...@suse.de
Signed-off-by: Greg Kroah-Hartman
---
drivers/gpu/drm/mgag200/mgag200_drv.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -30,9 +30,8 @@ module_param_named(modeset, mgag200_mode
static struct drm_driver driver;
static const struct pci_device_id pciidlist[] = {
- { PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
+ { PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
- { PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A
},
{ PCI_VENDOR_ID_MATROX, 0x524, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_B
},
{ PCI_VENDOR_ID_MATROX, 0x530, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_EV },
{ PCI_VENDOR_ID_MATROX, 0x532, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_WB },
Patches currently in stable-queue which might be from tzimmerm...@suse.de are
queue-5.4/drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
queue-5.4/drm-mgag200-store-flags-from-pci-driver-data-in-device-structure.patch
queue-5.4/drm-mgag200-add-workaround-for-hw-that-does-not-support-startadd.patch
queue-5.4/drm-mgag200-extract-device-type-from-flags.patch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/mgag200: Flag all G200 SE A machines as broken wrt
> On Dec 6, 2019, at 4:04 AM, Gerd Hoffmann wrote:
>
>> Several MGA G200 SE machines don't respect the value of the startadd
>> register field. After more feedback on affected machines, neither PCI
>> subvendor ID nor the internal ID seem to hint towards the bug. All
>> affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was
>> decided to flag all G200 SE A machines as broken.
>
>> -{ PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
>> +{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
>> G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
>> -{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A
>> },
>
> Acked-by: Gerd Hoffmann
Tested-by: John Donnelly
This series of commits appear to resolve the display issue in 5.4.-rc8 as
reported in :
https://gitlab.freedesktop.org/drm/misc/issues/7
52ca22daadbb 2019-12-06 | drm/mgag200: Flag all G200 SE A machines as broken
wrt
e0f1a41a45b3 2019-12-06 | drm/mgag200: Add workaround for HW that does not
support 'startadd'
11a219a38f2d 2019-12-06 | drm/mgag200: Store flags from PCI driver data in
device structure
a23512ace008 2019-12-06 | drm/mgag200: Extract device type from flags
There is one commit I did not apply :
[PATCH v2] drm/mgag200: Add module parameter to pin all buffers at offset 0
I don’t see a need for that now since we using the PCI-ID of 0x522 for the fix.
>
> cheers,
> Gerd
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_dri-2Ddevel=DwIGaQ=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE=t2fPg9D87F7D8jm0_3CG9yoiIKdRg4qc_thBw4bzMhc=cFYmB62lgH3WoOWZuvgMKjsgMXQUscmrypDlQhYpF_E=21ZEZohFZBQsEr5bo3sS4pMpCf2ca5KXFJq5X3XUzQw=
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/mgag200: Flag all G200 SE A machines as broken wrt
> Several MGA G200 SE machines don't respect the value of the startadd
> register field. After more feedback on affected machines, neither PCI
> subvendor ID nor the internal ID seem to hint towards the bug. All
> affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was
> decided to flag all G200 SE A machines as broken.
> - { PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
> + { PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
> - { PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A
> },
Acked-by: Gerd Hoffmann
cheers,
Gerd
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/mgag200: Flag all G200 SE A machines as broken wrt
Several MGA G200 SE machines don't respect the value of the startadd
register field. After more feedback on affected machines, neither PCI
subvendor ID nor the internal ID seem to hint towards the bug. All
affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was
decided to flag all G200 SE A machines as broken.
Signed-off-by: Thomas Zimmermann
Fixes: 1591fadf857c ("drm/mgag200: Add workaround for HW that does not support
'startadd'")
Cc: Thomas Zimmermann
Cc: John Donnelly
Cc: Daniel Vetter
Cc: Gerd Hoffmann
Cc: Dave Airlie
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: David Airlie
Cc: Sam Ravnborg
Cc: "Y.C. Chen"
Cc: Neil Armstrong
Cc: Thomas Gleixner
Cc: "José Roberto de Souza"
Cc: Andrzej Pietrasiewicz
Cc: dri-devel@lists.freedesktop.org
Cc: # v5.3+
Cc: Greg Kroah-Hartman
Cc: Allison Randal
Cc: Alex Deucher
Cc: "Noralf Trønnes"
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c
b/drivers/gpu/drm/mgag200/mgag200_drv.c
index 30b3b827adf8..9f4f5f071add 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -30,9 +30,8 @@ module_param_named(modeset, mgag200_modeset, int, 0400);
static struct drm_driver driver;
static const struct pci_device_id pciidlist[] = {
- { PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
+ { PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
- { PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A
},
{ PCI_VENDOR_ID_MATROX, 0x524, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_B
},
{ PCI_VENDOR_ID_MATROX, 0x530, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_EV },
{ PCI_VENDOR_ID_MATROX, 0x532, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_WB },
--
2.23.0
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
