Re: [PATCH] drm/msm/dpu: remove extra drm_encoder_cleanup from the error path

2023-12-12 Thread Dmitry Baryshkov 


On Mon, 11 Dec 2023 17:54:40 +0300, Dmitry Baryshkov wrote:
> The drmm handler will perform drm_encoder_cleanup() for us. Moreover if
> we call drm_encoder_cleanup() manually, the drmm_encoder_alloc_release()
> will spawn warnings at drivers/gpu/drm/drm_encoder.c:214. Drop these
> extra drm_encoder_cleanup() calls.
> 
> 

Applied, thanks!

[1/1] drm/msm/dpu: remove extra drm_encoder_cleanup from the error path
  https://gitlab.freedesktop.org/lumag/msm/-/commit/014a07f72a33

Best regards,
-- 
Dmitry Baryshkov

Re: [PATCH] drm/msm/dpu: remove extra drm_encoder_cleanup from the error path

2023-12-11 Thread Abhinav Kumar 




On 12/11/2023 6:54 AM, Dmitry Baryshkov wrote:

The drmm handler will perform drm_encoder_cleanup() for us. Moreover if
we call drm_encoder_cleanup() manually, the drmm_encoder_alloc_release()
will spawn warnings at drivers/gpu/drm/drm_encoder.c:214. Drop these
extra drm_encoder_cleanup() calls.

Fixes: cd42c56d9c0b ("drm/msm/dpu: use drmm-managed allocation for 
dpu_encoder_virt")
Signed-off-by: Dmitry Baryshkov 
---
  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 ---
  1 file changed, 3 deletions(-)



Reviewed-by: Abhinav Kumar 
Tested-by: Abhinav Kumar  #sm8250 CI

Re: [PATCH] drm/msm/dpu: remove extra drm_encoder_cleanup from the error path

2023-12-11 Thread Dmitry Baryshkov 
On Mon, 11 Dec 2023 at 16:54, Dmitry Baryshkov
 wrote:
>
> The drmm handler will perform drm_encoder_cleanup() for us. Moreover if
> we call drm_encoder_cleanup() manually, the drmm_encoder_alloc_release()
> will spawn warnings at drivers/gpu/drm/drm_encoder.c:214. Drop these
> extra drm_encoder_cleanup() calls.
>
> Fixes: cd42c56d9c0b ("drm/msm/dpu: use drmm-managed allocation for 
> dpu_encoder_virt")
> Signed-off-by: Dmitry Baryshkov 

Reported-by: Konrad Dybcio 


-- 
With best wishes
Dmitry

[PATCH] drm/msm/dpu: remove extra drm_encoder_cleanup from the error path

2023-12-11 Thread Dmitry Baryshkov 
The drmm handler will perform drm_encoder_cleanup() for us. Moreover if
we call drm_encoder_cleanup() manually, the drmm_encoder_alloc_release()
will spawn warnings at drivers/gpu/drm/drm_encoder.c:214. Drop these
extra drm_encoder_cleanup() calls.

Fixes: cd42c56d9c0b ("drm/msm/dpu: use drmm-managed allocation for 
dpu_encoder_virt")
Signed-off-by: Dmitry Baryshkov 
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index dc24fe4bb3b0..d60edb93d4f7 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -586,7 +586,6 @@ static int _dpu_kms_initialize_displayport(struct 
drm_device *dev,
rc = msm_dp_modeset_init(priv->dp[i], dev, encoder);
if (rc) {
DPU_ERROR("modeset_init failed for DP, rc = %d\n", rc);
-   drm_encoder_cleanup(encoder);
return rc;
}
}
@@ -619,7 +618,6 @@ static int _dpu_kms_initialize_hdmi(struct drm_device *dev,
rc = msm_hdmi_modeset_init(priv->hdmi, dev, encoder);
if (rc) {
DPU_ERROR("modeset_init failed for DP, rc = %d\n", rc);
-   drm_encoder_cleanup(encoder);
return rc;
}
 
@@ -651,7 +649,6 @@ static int _dpu_kms_initialize_writeback(struct drm_device 
*dev,
n_formats);
if (rc) {
DPU_ERROR("dpu_writeback_init, rc = %d\n", rc);
-   drm_encoder_cleanup(encoder);
return rc;
}
 
-- 
2.39.2