[PATCH] drm/panel/ld9040: add power control sequence

[Thierry Reding]

On Tue, Apr 08, 2014 at 12:58:05PM +0200, Andrzej Hajda wrote:
> Some ld9040 panels do not start without providing power control sequence
> during initialization. The patch fixes the driver by providing such
> sequence for all panels.
> 
> Signed-off-by: Andrzej Hajda 
> ---
>  drivers/gpu/drm/panel/panel-ld9040.c | 3 +++
>  1 file changed, 3 insertions(+)

I've applied this to my drm/panel/for-next branch. Judging by the commit
description this isn't a critical bug fix, so not a candidate for -fixes
at this point.

Thierry
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: 

[PATCH] drm/panel/ld9040: add power control sequence

[Andrzej Hajda]

Gently ping nr 2.

Regards
Andrzej

On 04/17/2014 02:54 PM, Andrzej Hajda wrote:
> Hi Inki,
>
> Could you pick up this patch into the fixes branch.
>
> Regards
> Andrzej
>
> On 04/08/2014 12:58 PM, Andrzej Hajda wrote:
>> Some ld9040 panels do not start without providing power control sequence
>> during initialization. The patch fixes the driver by providing such
>> sequence for all panels.
>>
>> Signed-off-by: Andrzej Hajda 
>> ---
>>  drivers/gpu/drm/panel/panel-ld9040.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-ld9040.c 
>> b/drivers/gpu/drm/panel/panel-ld9040.c
>> index 1f1f837..db1601f 100644
>> --- a/drivers/gpu/drm/panel/panel-ld9040.c
>> +++ b/drivers/gpu/drm/panel/panel-ld9040.c
>> @@ -27,6 +27,7 @@
>>  #define MCS_ELVSS_ON0xb1
>>  #define MCS_USER_SETTING0xf0
>>  #define MCS_DISPCTL 0xf2
>> +#define MCS_POWER_CTRL  0xf4
>>  #define MCS_GTCON   0xf7
>>  #define MCS_PANEL_CONDITION 0xf8
>>  #define MCS_GAMMA_SET1  0xf9
>> @@ -182,6 +183,8 @@ static void ld9040_init(struct ld9040 *ctx)
>>  ld9040_dcs_write_seq_static(ctx, MCS_DISPCTL,
>>  0x02, 0x08, 0x08, 0x10, 0x10);
>>  ld9040_dcs_write_seq_static(ctx, MCS_MANPWR, 0x04);
>> +ld9040_dcs_write_seq_static(ctx, MCS_POWER_CTRL,
>> +0x0a, 0x87, 0x25, 0x6a, 0x44, 0x02, 0x88);
>>  ld9040_dcs_write_seq_static(ctx, MCS_ELVSS_ON, 0x0d, 0x00, 0x16);
>>  ld9040_dcs_write_seq_static(ctx, MCS_GTCON, 0x09, 0x00, 0x00);
>>  ld9040_brightness_set(ctx);

[PATCH] drm/panel/ld9040: add power control sequence

[Andrzej Hajda]

Hi Inki,

Could you pick up this patch into the fixes branch.

Regards
Andrzej

On 04/08/2014 12:58 PM, Andrzej Hajda wrote:
> Some ld9040 panels do not start without providing power control sequence
> during initialization. The patch fixes the driver by providing such
> sequence for all panels.
>
> Signed-off-by: Andrzej Hajda 
> ---
>  drivers/gpu/drm/panel/panel-ld9040.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-ld9040.c 
> b/drivers/gpu/drm/panel/panel-ld9040.c
> index 1f1f837..db1601f 100644
> --- a/drivers/gpu/drm/panel/panel-ld9040.c
> +++ b/drivers/gpu/drm/panel/panel-ld9040.c
> @@ -27,6 +27,7 @@
>  #define MCS_ELVSS_ON 0xb1
>  #define MCS_USER_SETTING 0xf0
>  #define MCS_DISPCTL  0xf2
> +#define MCS_POWER_CTRL   0xf4
>  #define MCS_GTCON0xf7
>  #define MCS_PANEL_CONDITION  0xf8
>  #define MCS_GAMMA_SET1   0xf9
> @@ -182,6 +183,8 @@ static void ld9040_init(struct ld9040 *ctx)
>   ld9040_dcs_write_seq_static(ctx, MCS_DISPCTL,
>   0x02, 0x08, 0x08, 0x10, 0x10);
>   ld9040_dcs_write_seq_static(ctx, MCS_MANPWR, 0x04);
> + ld9040_dcs_write_seq_static(ctx, MCS_POWER_CTRL,
> + 0x0a, 0x87, 0x25, 0x6a, 0x44, 0x02, 0x88);
>   ld9040_dcs_write_seq_static(ctx, MCS_ELVSS_ON, 0x0d, 0x00, 0x16);
>   ld9040_dcs_write_seq_static(ctx, MCS_GTCON, 0x09, 0x00, 0x00);
>   ld9040_brightness_set(ctx);

[PATCH] drm/panel/ld9040: add power control sequence

[Andrzej Hajda]

Some ld9040 panels do not start without providing power control sequence
during initialization. The patch fixes the driver by providing such
sequence for all panels.

Signed-off-by: Andrzej Hajda 
---
 drivers/gpu/drm/panel/panel-ld9040.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-ld9040.c 
b/drivers/gpu/drm/panel/panel-ld9040.c
index 1f1f837..db1601f 100644
--- a/drivers/gpu/drm/panel/panel-ld9040.c
+++ b/drivers/gpu/drm/panel/panel-ld9040.c
@@ -27,6 +27,7 @@
 #define MCS_ELVSS_ON   0xb1
 #define MCS_USER_SETTING   0xf0
 #define MCS_DISPCTL0xf2
+#define MCS_POWER_CTRL 0xf4
 #define MCS_GTCON  0xf7
 #define MCS_PANEL_CONDITION0xf8
 #define MCS_GAMMA_SET1 0xf9
@@ -182,6 +183,8 @@ static void ld9040_init(struct ld9040 *ctx)
ld9040_dcs_write_seq_static(ctx, MCS_DISPCTL,
0x02, 0x08, 0x08, 0x10, 0x10);
ld9040_dcs_write_seq_static(ctx, MCS_MANPWR, 0x04);
+   ld9040_dcs_write_seq_static(ctx, MCS_POWER_CTRL,
+   0x0a, 0x87, 0x25, 0x6a, 0x44, 0x02, 0x88);
ld9040_dcs_write_seq_static(ctx, MCS_ELVSS_ON, 0x0d, 0x00, 0x16);
ld9040_dcs_write_seq_static(ctx, MCS_GTCON, 0x09, 0x00, 0x00);
ld9040_brightness_set(ctx);
-- 
1.8.3.2