Patch "drm/psr: Fix missed entry in PSR setup time table." has been added to the 4.14-stable tree
This is a note to let you know that I've just added the patch titled
drm/psr: Fix missed entry in PSR setup time table.
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-psr-fix-missed-entry-in-psr-setup-time-table.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let know about it.
From bdcc02cf1bb508fc700df7662f55058f651f2621 Mon Sep 17 00:00:00 2001
From: Dhinakaran Pandiyan
Date: Fri, 11 May 2018 12:51:42 -0700
Subject: drm/psr: Fix missed entry in PSR setup time table.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Dhinakaran Pandiyan
commit bdcc02cf1bb508fc700df7662f55058f651f2621 upstream.
Entry corresponding to 220 us setup time was missing. I am not aware of
any specific bug this fixes, but this could potentially result in enabling
PSR on a panel with a higher setup time requirement than supported by the
hardware.
I verified the value is present in eDP spec versions 1.3, 1.4 and 1.4a.
Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()")
Cc: sta...@vger.kernel.org
Cc: Ville Syrjälä
Cc: Jose Roberto de Souza
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: José Roberto de Souza
Reviewed-by: Tarun Vyas
Signed-off-by: Dhinakaran Pandiyan
Signed-off-by: Jani Nikula
Link:
https://patchwork.freedesktop.org/patch/msgid/20180511195145.3829-3-dhinakaran.pandi...@intel.com
Signed-off-by: Greg Kroah-Hartman
---
drivers/gpu/drm/drm_dp_helper.c |1 +
1 file changed, 1 insertion(+)
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1139,6 +1139,7 @@ int drm_dp_psr_setup_time(const u8 psr_c
static const u16 psr_setup_time_us[] = {
PSR_SETUP_TIME(330),
PSR_SETUP_TIME(275),
+ PSR_SETUP_TIME(220),
PSR_SETUP_TIME(165),
PSR_SETUP_TIME(110),
PSR_SETUP_TIME(55),
Patches currently in stable-queue which might be from
dhinakaran.pandi...@intel.com are
queue-4.14/drm-psr-fix-missed-entry-in-psr-setup-time-table.patch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patch "drm/psr: Fix missed entry in PSR setup time table." has been added to the 4.9-stable tree
This is a note to let you know that I've just added the patch titled
drm/psr: Fix missed entry in PSR setup time table.
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-psr-fix-missed-entry-in-psr-setup-time-table.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let know about it.
From bdcc02cf1bb508fc700df7662f55058f651f2621 Mon Sep 17 00:00:00 2001
From: Dhinakaran Pandiyan
Date: Fri, 11 May 2018 12:51:42 -0700
Subject: drm/psr: Fix missed entry in PSR setup time table.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Dhinakaran Pandiyan
commit bdcc02cf1bb508fc700df7662f55058f651f2621 upstream.
Entry corresponding to 220 us setup time was missing. I am not aware of
any specific bug this fixes, but this could potentially result in enabling
PSR on a panel with a higher setup time requirement than supported by the
hardware.
I verified the value is present in eDP spec versions 1.3, 1.4 and 1.4a.
Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()")
Cc: sta...@vger.kernel.org
Cc: Ville Syrjälä
Cc: Jose Roberto de Souza
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: José Roberto de Souza
Reviewed-by: Tarun Vyas
Signed-off-by: Dhinakaran Pandiyan
Signed-off-by: Jani Nikula
Link:
https://patchwork.freedesktop.org/patch/msgid/20180511195145.3829-3-dhinakaran.pandi...@intel.com
Signed-off-by: Greg Kroah-Hartman
---
drivers/gpu/drm/drm_dp_helper.c |1 +
1 file changed, 1 insertion(+)
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1065,6 +1065,7 @@ int drm_dp_psr_setup_time(const u8 psr_c
static const u16 psr_setup_time_us[] = {
PSR_SETUP_TIME(330),
PSR_SETUP_TIME(275),
+ PSR_SETUP_TIME(220),
PSR_SETUP_TIME(165),
PSR_SETUP_TIME(110),
PSR_SETUP_TIME(55),
Patches currently in stable-queue which might be from
dhinakaran.pandi...@intel.com are
queue-4.9/drm-psr-fix-missed-entry-in-psr-setup-time-table.patch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patch "drm/psr: Fix missed entry in PSR setup time table." has been added to the 4.16-stable tree
This is a note to let you know that I've just added the patch titled
drm/psr: Fix missed entry in PSR setup time table.
to the 4.16-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-psr-fix-missed-entry-in-psr-setup-time-table.patch
and it can be found in the queue-4.16 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let know about it.
From bdcc02cf1bb508fc700df7662f55058f651f2621 Mon Sep 17 00:00:00 2001
From: Dhinakaran Pandiyan
Date: Fri, 11 May 2018 12:51:42 -0700
Subject: drm/psr: Fix missed entry in PSR setup time table.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Dhinakaran Pandiyan
commit bdcc02cf1bb508fc700df7662f55058f651f2621 upstream.
Entry corresponding to 220 us setup time was missing. I am not aware of
any specific bug this fixes, but this could potentially result in enabling
PSR on a panel with a higher setup time requirement than supported by the
hardware.
I verified the value is present in eDP spec versions 1.3, 1.4 and 1.4a.
Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()")
Cc: sta...@vger.kernel.org
Cc: Ville Syrjälä
Cc: Jose Roberto de Souza
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: José Roberto de Souza
Reviewed-by: Tarun Vyas
Signed-off-by: Dhinakaran Pandiyan
Signed-off-by: Jani Nikula
Link:
https://patchwork.freedesktop.org/patch/msgid/20180511195145.3829-3-dhinakaran.pandi...@intel.com
Signed-off-by: Greg Kroah-Hartman
---
drivers/gpu/drm/drm_dp_helper.c |1 +
1 file changed, 1 insertion(+)
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1141,6 +1141,7 @@ int drm_dp_psr_setup_time(const u8 psr_c
static const u16 psr_setup_time_us[] = {
PSR_SETUP_TIME(330),
PSR_SETUP_TIME(275),
+ PSR_SETUP_TIME(220),
PSR_SETUP_TIME(165),
PSR_SETUP_TIME(110),
PSR_SETUP_TIME(55),
Patches currently in stable-queue which might be from
dhinakaran.pandi...@intel.com are
queue-4.16/drm-psr-fix-missed-entry-in-psr-setup-time-table.patch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/psr: Fix missed entry in PSR setup time table.
On Fri, 2018-05-11 at 18:03 +, Souza, Jose wrote:
> On Thu, 2018-05-10 at 17:54 -0700, Dhinakaran Pandiyan wrote:
> >
> > Entry corresponding to 220 us setup time was missing. I am not
> > aware
> > of
> > any specific bug this fixes, but this could potentially result in
> > enabling
> > PSR on a panel with a higher setup time requirement than supported
> > by
> > the
> > hardware.
> It should be 'a lower setup time'.
> Sink sets 2h requesting 220us but source will only wait 165us.
By hardware, I meant source :) We'll end up enabling PSR on a sink with
a higher setup time requirement (220us) than supported by the source
hardware (let's say 200 us) because we read the sink requirement as 165
us.
>
> Other than that looks good:
> Reviewed-by: José Roberto de Souza
>
Thanks!
I'll resend this along the other PSR patch you reviewed.
> >
> >
> > I verified the value is present in eDP spec versions 1.3, 1.4 and
> > 1.4a.
> >
> > Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()")
> > Cc: sta...@vger.kernel.org
> > Cc: Ville Syrjälä
> > Cc: Jose Roberto de Souza
> > Signed-off-by: Dhinakaran Pandiyan
> > ---
> > drivers/gpu/drm/drm_dp_helper.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/drm_dp_helper.c
> > b/drivers/gpu/drm/drm_dp_helper.c
> > index 36c7609a4bd5..a7ba602a43a8 100644
> > --- a/drivers/gpu/drm/drm_dp_helper.c
> > +++ b/drivers/gpu/drm/drm_dp_helper.c
> > @@ -1159,6 +1159,7 @@ int drm_dp_psr_setup_time(const u8
> > psr_cap[EDP_PSR_RECEIVER_CAP_SIZE])
> > static const u16 psr_setup_time_us[] = {
> > PSR_SETUP_TIME(330),
> > PSR_SETUP_TIME(275),
> > + PSR_SETUP_TIME(220),
> > PSR_SETUP_TIME(165),
> > PSR_SETUP_TIME(110),
> > PSR_SETUP_TIME(55),
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
