[PATCH] drm/qxl: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

[SF Markus Elfring]

From: Markus Elfring 
Date: Fri, 22 Jul 2016 14:14:54 +0200

The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 drivers/gpu/drm/qxl/qxl_display.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/qxl/qxl_display.c 
b/drivers/gpu/drm/qxl/qxl_display.c
index ad42968..3aef127 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -468,8 +468,7 @@ void qxl_user_framebuffer_destroy(struct drm_framebuffer 
*fb)
 {
struct qxl_framebuffer *qxl_fb = to_qxl_framebuffer(fb);

-   if (qxl_fb->obj)
-   drm_gem_object_unreference_unlocked(qxl_fb->obj);
+   drm_gem_object_unreference_unlocked(qxl_fb->obj);
drm_framebuffer_cleanup(fb);
kfree(qxl_fb);
 }
-- 
2.9.2

[PATCH] drm/qxl: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

[Sean Paul]

On Fri, Jul 22, 2016 at 8:22 AM, SF Markus Elfring
 wrote:
> From: Markus Elfring 
> Date: Fri, 22 Jul 2016 14:14:54 +0200
>
> The drm_gem_object_unreference_unlocked() function tests whether
> its argument is NULL and then returns immediately.
> Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring 

Applied to drm-misc

> ---
>  drivers/gpu/drm/qxl/qxl_display.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_display.c 
> b/drivers/gpu/drm/qxl/qxl_display.c
> index ad42968..3aef127 100644
> --- a/drivers/gpu/drm/qxl/qxl_display.c
> +++ b/drivers/gpu/drm/qxl/qxl_display.c
> @@ -468,8 +468,7 @@ void qxl_user_framebuffer_destroy(struct drm_framebuffer 
> *fb)
>  {
> struct qxl_framebuffer *qxl_fb = to_qxl_framebuffer(fb);
>
> -   if (qxl_fb->obj)
> -   drm_gem_object_unreference_unlocked(qxl_fb->obj);
> +   drm_gem_object_unreference_unlocked(qxl_fb->obj);
> drm_framebuffer_cleanup(fb);
> kfree(qxl_fb);
>  }
> --
> 2.9.2
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel