Patch "drm/sti: Depend on OF rather than selecting it" has been added to the 4.17-stable tree
This is a note to let you know that I've just added the patch titled drm/sti: Depend on OF rather than selecting it to the 4.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-sti-depend-on-of-rather-than-selecting-it.patch and it can be found in the queue-4.17 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. From c9fea6f4379c72b7c59e1efceab09a35bc7eac43 Mon Sep 17 00:00:00 2001 From: Oliver O'Halloran Date: Tue, 3 Apr 2018 15:34:01 +1000 Subject: drm/sti: Depend on OF rather than selecting it From: Oliver O'Halloran commit c9fea6f4379c72b7c59e1efceab09a35bc7eac43 upstream. Commit cc6b741c6f63 ("drm: sti: remove useless fields from vtg structure") reworked some code inside of this driver and made it select CONFIG_OF. This results in the entire OF layer being enabled when building an allmodconfig on ia64. OF on ia64 is completely unsupported so this isn't a great state of affairs. The 0day robot noticed a link-time failure on ia64 caused by using of_node_to_nid() in an otherwise unrelated driver. The generic fallback for of_node_to_nid() only exists when: defined(CONFIG_OF) && defined(CONFIG_NUMA) == false Since CONFIG_NUMA is usually selected for IA64 we get the link failure. Fix this by making the driver depend on OF rather than selecting it, odds are that was the original intent. Link: https://lists.01.org/pipermail/kbuild-all/2018-March/045172.html Fixes: cc6b741c6f63 ("drm: sti: remove useless fields from vtg structure") Cc: Benjamin Gaignard Cc: Vincent Abriou Cc: David Airlie Cc: dri-devel@lists.freedesktop.org Cc: linux-i...@vger.kernel.org Cc: sta...@vger.kernel.org Signed-off-by: Oliver O'Halloran Reviewed-by: Benjamin Gaignard Signed-off-by: Philippe Cornu Link: https://patchwork.freedesktop.org/patch/msgid/20180403053401.30045-1-ooh...@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/sti/Kconfig |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/gpu/drm/sti/Kconfig +++ b/drivers/gpu/drm/sti/Kconfig @@ -1,6 +1,6 @@ config DRM_STI tristate "DRM Support for STMicroelectronics SoC stiH4xx Series" - depends on DRM && (ARCH_STI || ARCH_MULTIPLATFORM) + depends on OF && DRM && (ARCH_STI || ARCH_MULTIPLATFORM) select RESET_CONTROLLER select DRM_KMS_HELPER select DRM_GEM_CMA_HELPER @@ -8,6 +8,5 @@ config DRM_STI select DRM_PANEL select FW_LOADER select SND_SOC_HDMI_CODEC if SND_SOC - select OF help Choose this option to enable DRM on STM stiH4xx chipset Patches currently in stable-queue which might be from ooh...@gmail.com are queue-4.17/drm-sti-depend-on-of-rather-than-selecting-it.patch ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/sti: Depend on OF rather than selecting it
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: cc6b741c6f63 drm: sti: remove useless fields from vtg structure. The bot has also determined it's probably a bug fixing patch. (score: 96.6729) The bot has tested the following trees: v4.16. v4.16: Build OK! -- Thanks, Sasha ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/sti: Depend on OF rather than selecting it
On 04/05/2018 01:05 PM, Benjamin Gaignard wrote: > 2018-04-03 7:34 GMT+02:00 Oliver O'Halloran: >> Commit cc6b741c6f63 ("drm: sti: remove useless fields from vtg >> structure") reworked some code inside of this driver and made it select >> CONFIG_OF. This results in the entire OF layer being enabled when >> building an allmodconfig on ia64. OF on ia64 is completely unsupported >> so this isn't a great state of affairs. >> >> The 0day robot noticed a link-time failure on ia64 caused by >> using of_node_to_nid() in an otherwise unrelated driver. The >> generic fallback for of_node_to_nid() only exists when: >> >> defined(CONFIG_OF) && defined(CONFIG_NUMA) == false >> >> Since CONFIG_NUMA is usually selected for IA64 we get the link failure. >> Fix this by making the driver depend on OF rather than selecting it, >> odds are that was the original intent. >> >> Link: https://lists.01.org/pipermail/kbuild-all/2018-March/045172.html >> Fixes: cc6b741c6f63 ("drm: sti: remove useless fields from vtg structure") >> Cc: Benjamin Gaignard >> Cc: Vincent Abriou >> Cc: David Airlie >> Cc: dri-devel@lists.freedesktop.org >> Cc: linux-i...@vger.kernel.org >> Cc: sta...@vger.kernel.org >> Signed-off-by: Oliver O'Halloran > > Reviewed-by: Benjamin Gaignard Applied on drm-misc-next Many thanks for your patch, Philippe :-) > >> --- >> Cc`ed to stable since the ia64 guys might want it backported. I'm not >> bothered if it just goes into mainline. >> --- >> drivers/gpu/drm/sti/Kconfig | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig >> index cca4b3c9aeb5..1963cc1b1cc5 100644 >> --- a/drivers/gpu/drm/sti/Kconfig >> +++ b/drivers/gpu/drm/sti/Kconfig >> @@ -1,6 +1,6 @@ >> config DRM_STI >> tristate "DRM Support for STMicroelectronics SoC stiH4xx Series" >> - depends on DRM && (ARCH_STI || ARCH_MULTIPLATFORM) >> + depends on OF && DRM && (ARCH_STI || ARCH_MULTIPLATFORM) >> select RESET_CONTROLLER >> select DRM_KMS_HELPER >> select DRM_GEM_CMA_HELPER >> @@ -8,6 +8,5 @@ config DRM_STI >> select DRM_PANEL >> select FW_LOADER >> select SND_SOC_HDMI_CODEC if SND_SOC >> - select OF >> help >>Choose this option to enable DRM on STM stiH4xx chipset >> -- >> 2.9.5 >> > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/sti: Depend on OF rather than selecting it
2018-04-03 7:34 GMT+02:00 Oliver O'Halloran: > Commit cc6b741c6f63 ("drm: sti: remove useless fields from vtg > structure") reworked some code inside of this driver and made it select > CONFIG_OF. This results in the entire OF layer being enabled when > building an allmodconfig on ia64. OF on ia64 is completely unsupported > so this isn't a great state of affairs. > > The 0day robot noticed a link-time failure on ia64 caused by > using of_node_to_nid() in an otherwise unrelated driver. The > generic fallback for of_node_to_nid() only exists when: > > defined(CONFIG_OF) && defined(CONFIG_NUMA) == false > > Since CONFIG_NUMA is usually selected for IA64 we get the link failure. > Fix this by making the driver depend on OF rather than selecting it, > odds are that was the original intent. > > Link: https://lists.01.org/pipermail/kbuild-all/2018-March/045172.html > Fixes: cc6b741c6f63 ("drm: sti: remove useless fields from vtg structure") > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Cc: David Airlie > Cc: dri-devel@lists.freedesktop.org > Cc: linux-i...@vger.kernel.org > Cc: sta...@vger.kernel.org > Signed-off-by: Oliver O'Halloran Reviewed-by: Benjamin Gaignard > --- > Cc`ed to stable since the ia64 guys might want it backported. I'm not > bothered if it just goes into mainline. > --- > drivers/gpu/drm/sti/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig > index cca4b3c9aeb5..1963cc1b1cc5 100644 > --- a/drivers/gpu/drm/sti/Kconfig > +++ b/drivers/gpu/drm/sti/Kconfig > @@ -1,6 +1,6 @@ > config DRM_STI > tristate "DRM Support for STMicroelectronics SoC stiH4xx Series" > - depends on DRM && (ARCH_STI || ARCH_MULTIPLATFORM) > + depends on OF && DRM && (ARCH_STI || ARCH_MULTIPLATFORM) > select RESET_CONTROLLER > select DRM_KMS_HELPER > select DRM_GEM_CMA_HELPER > @@ -8,6 +8,5 @@ config DRM_STI > select DRM_PANEL > select FW_LOADER > select SND_SOC_HDMI_CODEC if SND_SOC > - select OF > help > Choose this option to enable DRM on STM stiH4xx chipset > -- > 2.9.5 > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/sti: Depend on OF rather than selecting it
Commit cc6b741c6f63 ("drm: sti: remove useless fields from vtg structure") reworked some code inside of this driver and made it select CONFIG_OF. This results in the entire OF layer being enabled when building an allmodconfig on ia64. OF on ia64 is completely unsupported so this isn't a great state of affairs. The 0day robot noticed a link-time failure on ia64 caused by using of_node_to_nid() in an otherwise unrelated driver. The generic fallback for of_node_to_nid() only exists when: defined(CONFIG_OF) && defined(CONFIG_NUMA) == false Since CONFIG_NUMA is usually selected for IA64 we get the link failure. Fix this by making the driver depend on OF rather than selecting it, odds are that was the original intent. Link: https://lists.01.org/pipermail/kbuild-all/2018-March/045172.html Fixes: cc6b741c6f63 ("drm: sti: remove useless fields from vtg structure") Cc: Benjamin GaignardCc: Vincent Abriou Cc: David Airlie Cc: dri-devel@lists.freedesktop.org Cc: linux-i...@vger.kernel.org Cc: sta...@vger.kernel.org Signed-off-by: Oliver O'Halloran --- Cc`ed to stable since the ia64 guys might want it backported. I'm not bothered if it just goes into mainline. --- drivers/gpu/drm/sti/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig index cca4b3c9aeb5..1963cc1b1cc5 100644 --- a/drivers/gpu/drm/sti/Kconfig +++ b/drivers/gpu/drm/sti/Kconfig @@ -1,6 +1,6 @@ config DRM_STI tristate "DRM Support for STMicroelectronics SoC stiH4xx Series" - depends on DRM && (ARCH_STI || ARCH_MULTIPLATFORM) + depends on OF && DRM && (ARCH_STI || ARCH_MULTIPLATFORM) select RESET_CONTROLLER select DRM_KMS_HELPER select DRM_GEM_CMA_HELPER @@ -8,6 +8,5 @@ config DRM_STI select DRM_PANEL select FW_LOADER select SND_SOC_HDMI_CODEC if SND_SOC - select OF help Choose this option to enable DRM on STM stiH4xx chipset -- 2.9.5 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel