[PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()
vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields and should be printed with a %zd specifier. Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") Signed-off-by: Boris Brezillon --- drivers/gpu/drm/vc4/vc4_bo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c index 3c3d11236910..4ae45d7dac42 100644 --- a/drivers/gpu/drm/vc4/vc4_bo.c +++ b/drivers/gpu/drm/vc4/vc4_bo.c @@ -88,11 +88,11 @@ int vc4_bo_stats_debugfs(struct seq_file *m, void *unused) mutex_lock(&vc4->purgeable.lock); if (vc4->purgeable.num) - seq_printf(m, "%30s: %6dkb BOs (%d)\n", "userspace BO cache", + seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "userspace BO cache", vc4->purgeable.size / 1024, vc4->purgeable.num); if (vc4->purgeable.purged_num) - seq_printf(m, "%30s: %6dkb BOs (%d)\n", "total purged BO", + seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "total purged BO", vc4->purgeable.purged_size / 1024, vc4->purgeable.purged_num); mutex_unlock(&vc4->purgeable.lock); -- 2.11.0 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()
Hi Boris, 2017-11-01 Boris Brezillon : > vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields > and should be printed with a %zd specifier. > > Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_bo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c > index 3c3d11236910..4ae45d7dac42 100644 > --- a/drivers/gpu/drm/vc4/vc4_bo.c > +++ b/drivers/gpu/drm/vc4/vc4_bo.c > @@ -88,11 +88,11 @@ int vc4_bo_stats_debugfs(struct seq_file *m, void *unused) > > mutex_lock(&vc4->purgeable.lock); > if (vc4->purgeable.num) > - seq_printf(m, "%30s: %6dkb BOs (%d)\n", "userspace BO cache", > + seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "userspace BO cache", > vc4->purgeable.size / 1024, vc4->purgeable.num); > > if (vc4->purgeable.purged_num) > - seq_printf(m, "%30s: %6dkb BOs (%d)\n", "total purged BO", > + seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "total purged BO", > vc4->purgeable.purged_size / 1024, > vc4->purgeable.purged_num); > mutex_unlock(&vc4->purgeable.lock); Reviewed-by: Gustavo Padovan Gustavo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()
Boris Brezillon writes: > vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields > and should be printed with a %zd specifier. > > Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") > Signed-off-by: Boris Brezillon Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()
On Wed, 1 Nov 2017 10:57:31 +0100 Boris Brezillon wrote: > vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields > and should be printed with a %zd specifier. Applied to drm-misc-next. > > Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_bo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c > index 3c3d11236910..4ae45d7dac42 100644 > --- a/drivers/gpu/drm/vc4/vc4_bo.c > +++ b/drivers/gpu/drm/vc4/vc4_bo.c > @@ -88,11 +88,11 @@ int vc4_bo_stats_debugfs(struct seq_file *m, void *unused) > > mutex_lock(&vc4->purgeable.lock); > if (vc4->purgeable.num) > - seq_printf(m, "%30s: %6dkb BOs (%d)\n", "userspace BO cache", > + seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "userspace BO cache", > vc4->purgeable.size / 1024, vc4->purgeable.num); > > if (vc4->purgeable.purged_num) > - seq_printf(m, "%30s: %6dkb BOs (%d)\n", "total purged BO", > + seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "total purged BO", > vc4->purgeable.purged_size / 1024, > vc4->purgeable.purged_num); > mutex_unlock(&vc4->purgeable.lock); ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel