Re: [PATCH] drm: Update drm_cache.c to pull in the new drm_cache.h
On Sat, Jan 21, 2017 at 06:05:05PM -0200, Gabriel Krisman Bertazi wrote: > Chris Wilsonwrites: > > > The prototypes were moved to a new header, but the function definitions > > were not updated to pull in the declarations. > > > > drivers/gpu/drm/drm_cache.c:79:1: warning: no previous prototype for > > ‘drm_clflush_pages’ [-Wmissing-prototypes] > > drivers/gpu/drm/drm_cache.c:120:1: warning: no previous prototype for > > ‘drm_clflush_sg’ [-Wmissing-prototypes] > > drivers/gpu/drm/drm_cache.c:152:1: warning: no previous prototype for > > ‘drm_clflush_virt_range’ [-Wmissing-prototypes] > > > > Fixes: f9a87bd7d5b6 ("drm: Move drm_clflush prototypes to drm_cache header > > file") > > Signed-off-by: Chris Wilson > > Cc: Gabriel Krisman Bertazi > > Cc: Alex Deucher > > Cc: Daniel Vetter > > Patch is good, though I'm Embarrassed that I didn't have -Wmissing-prototypes > enabled when testing this. Thanks Chris. > > Reviewed-by: Gabriel Krisman Bertazi Applied to drm-misc, thx. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm: Update drm_cache.c to pull in the new drm_cache.h
Chris Wilsonwrites: > The prototypes were moved to a new header, but the function definitions > were not updated to pull in the declarations. > > drivers/gpu/drm/drm_cache.c:79:1: warning: no previous prototype for > ‘drm_clflush_pages’ [-Wmissing-prototypes] > drivers/gpu/drm/drm_cache.c:120:1: warning: no previous prototype for > ‘drm_clflush_sg’ [-Wmissing-prototypes] > drivers/gpu/drm/drm_cache.c:152:1: warning: no previous prototype for > ‘drm_clflush_virt_range’ [-Wmissing-prototypes] > > Fixes: f9a87bd7d5b6 ("drm: Move drm_clflush prototypes to drm_cache header > file") > Signed-off-by: Chris Wilson > Cc: Gabriel Krisman Bertazi > Cc: Alex Deucher > Cc: Daniel Vetter Patch is good, though I'm Embarrassed that I didn't have -Wmissing-prototypes enabled when testing this. Thanks Chris. Reviewed-by: Gabriel Krisman Bertazi -- Gabriel Krisman Bertazi ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm: Update drm_cache.c to pull in the new drm_cache.h
The prototypes were moved to a new header, but the function definitions were not updated to pull in the declarations. drivers/gpu/drm/drm_cache.c:79:1: warning: no previous prototype for ‘drm_clflush_pages’ [-Wmissing-prototypes] drivers/gpu/drm/drm_cache.c:120:1: warning: no previous prototype for ‘drm_clflush_sg’ [-Wmissing-prototypes] drivers/gpu/drm/drm_cache.c:152:1: warning: no previous prototype for ‘drm_clflush_virt_range’ [-Wmissing-prototypes] Fixes: f9a87bd7d5b6 ("drm: Move drm_clflush prototypes to drm_cache header file") Signed-off-by: Chris WilsonCc: Gabriel Krisman Bertazi Cc: Alex Deucher Cc: Daniel Vetter --- drivers/gpu/drm/drm_cache.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c index 5066638928ec..c3b9aaccdf42 100644 --- a/drivers/gpu/drm/drm_cache.c +++ b/drivers/gpu/drm/drm_cache.c @@ -29,7 +29,9 @@ */ #include -#include +#include + +#include #if defined(CONFIG_X86) #include -- 2.11.0 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel