Re: [PATCH] drm: fix semicolon.cocci warnings
On Tue, May 11, 2021 at 7:17 PM Daniel Vetter wrote:
> On Wed, May 12, 2021 at 12:11:23AM +0800, kernel test robot wrote:
> > From: kernel test robot
> >
> > drivers/gpu/drm/kmb/kmb_dsi.c:284:3-4: Unneeded semicolon
> > drivers/gpu/drm/kmb/kmb_dsi.c:304:3-4: Unneeded semicolon
> > drivers/gpu/drm/kmb/kmb_dsi.c:321:3-4: Unneeded semicolon
> > drivers/gpu/drm/kmb/kmb_dsi.c:340:3-4: Unneeded semicolon
> > drivers/gpu/drm/kmb/kmb_dsi.c:364:2-3: Unneeded semicolon
> >
> >
> > Remove unneeded semicolon.
> >
> > Generated by: scripts/coccinelle/misc/semicolon.cocci
> >
> > Fixes: ade896460e4a ("drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY")
This Fixed-tag is completely bogus. The right one is
Fixes: 98521f4d4b4cb265 ("drm/kmb: Mipi DSI part of the display driver")
> > CC: Geert Uytterhoeven
> > Reported-by: kernel test robot
> > Signed-off-by: kernel test robot
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH] drm: fix semicolon.cocci warnings
On Wed, May 12, 2021 at 12:11:23AM +0800, kernel test robot wrote:
> From: kernel test robot
>
> drivers/gpu/drm/kmb/kmb_dsi.c:284:3-4: Unneeded semicolon
> drivers/gpu/drm/kmb/kmb_dsi.c:304:3-4: Unneeded semicolon
> drivers/gpu/drm/kmb/kmb_dsi.c:321:3-4: Unneeded semicolon
> drivers/gpu/drm/kmb/kmb_dsi.c:340:3-4: Unneeded semicolon
> drivers/gpu/drm/kmb/kmb_dsi.c:364:2-3: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: ade896460e4a ("drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY")
> CC: Geert Uytterhoeven
> Reported-by: kernel test robot
> Signed-off-by: kernel test robot
Applied to drm-misc-next for 5.14, thanks for the patch.
-Daniel
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 1140ab592e2ebf8153d2b322604031a8868ce7a5
> commit: ade896460e4a62f5e4a892a98d254937f6f5b64c drm: DRM_KMB_DISPLAY should
> depend on ARCH_KEEMBAY
> :: branch date: 18 hours ago
> :: commit date: 6 months ago
>
> kmb_dsi.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> --- a/drivers/gpu/drm/kmb/kmb_dsi.c
> +++ b/drivers/gpu/drm/kmb/kmb_dsi.c
> @@ -281,7 +281,7 @@ static u32 mipi_get_datatype_params(u32
> default:
> DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
> return -EINVAL;
> - };
> + }
> break;
> case DSI_LP_DT_PPS_YCBCR422_16B:
> data_type_param.size_constraint_pixels = 2;
> @@ -301,7 +301,7 @@ static u32 mipi_get_datatype_params(u32
> default:
> DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
> return -EINVAL;
> - };
> + }
> break;
> case DSI_LP_DT_LPPS_YCBCR422_20B:
> case DSI_LP_DT_PPS_YCBCR422_24B:
> @@ -318,7 +318,7 @@ static u32 mipi_get_datatype_params(u32
> default:
> DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
> return -EINVAL;
> - };
> + }
> break;
> case DSI_LP_DT_PPS_RGB565_16B:
> data_type_param.size_constraint_pixels = 1;
> @@ -337,7 +337,7 @@ static u32 mipi_get_datatype_params(u32
> default:
> DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
> return -EINVAL;
> - };
> + }
> break;
> case DSI_LP_DT_PPS_RGB666_18B:
> data_type_param.size_constraint_pixels = 4;
> @@ -361,7 +361,7 @@ static u32 mipi_get_datatype_params(u32
> default:
> DRM_ERROR("DSI: Invalid data_type %d\n", data_type);
> return -EINVAL;
> - };
> + }
>
> *params = data_type_param;
> return 0;
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
[PATCH] drm: fix semicolon.cocci warnings
From: kernel test robot
drivers/gpu/drm/kmb/kmb_dsi.c:284:3-4: Unneeded semicolon
drivers/gpu/drm/kmb/kmb_dsi.c:304:3-4: Unneeded semicolon
drivers/gpu/drm/kmb/kmb_dsi.c:321:3-4: Unneeded semicolon
drivers/gpu/drm/kmb/kmb_dsi.c:340:3-4: Unneeded semicolon
drivers/gpu/drm/kmb/kmb_dsi.c:364:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: ade896460e4a ("drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY")
CC: Geert Uytterhoeven
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 1140ab592e2ebf8153d2b322604031a8868ce7a5
commit: ade896460e4a62f5e4a892a98d254937f6f5b64c drm: DRM_KMB_DISPLAY should
depend on ARCH_KEEMBAY
:: branch date: 18 hours ago
:: commit date: 6 months ago
kmb_dsi.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
--- a/drivers/gpu/drm/kmb/kmb_dsi.c
+++ b/drivers/gpu/drm/kmb/kmb_dsi.c
@@ -281,7 +281,7 @@ static u32 mipi_get_datatype_params(u32
default:
DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
return -EINVAL;
- };
+ }
break;
case DSI_LP_DT_PPS_YCBCR422_16B:
data_type_param.size_constraint_pixels = 2;
@@ -301,7 +301,7 @@ static u32 mipi_get_datatype_params(u32
default:
DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
return -EINVAL;
- };
+ }
break;
case DSI_LP_DT_LPPS_YCBCR422_20B:
case DSI_LP_DT_PPS_YCBCR422_24B:
@@ -318,7 +318,7 @@ static u32 mipi_get_datatype_params(u32
default:
DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
return -EINVAL;
- };
+ }
break;
case DSI_LP_DT_PPS_RGB565_16B:
data_type_param.size_constraint_pixels = 1;
@@ -337,7 +337,7 @@ static u32 mipi_get_datatype_params(u32
default:
DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
return -EINVAL;
- };
+ }
break;
case DSI_LP_DT_PPS_RGB666_18B:
data_type_param.size_constraint_pixels = 4;
@@ -361,7 +361,7 @@ static u32 mipi_get_datatype_params(u32
default:
DRM_ERROR("DSI: Invalid data_type %d\n", data_type);
return -EINVAL;
- };
+ }
*params = data_type_param;
return 0;
