Re: [PATCH] drm: mali-dp: Disable planes when their CRTC gets disabled.

[Liviu Dudau]

On Wed, Nov 15, 2017 at 05:25:02PM -0200, Gustavo Padovan wrote:
> Hi Liviu,

Hi Gustavo,

> 
> 2017-11-01 Liviu Dudau :
> 
> > Make sure only the planes on the active CRTCs get committed and
> > that all planes on the disabled CRTCs get turned off.
> > 
> > Reviewed-by: Brian Starkey 
> > Signed-off-by: Liviu Dudau 
> > ---
> >  drivers/gpu/drm/arm/malidp_crtc.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> Reviewed-by: Gustavo Padovan 

Thanks for reviewing both patches!

Best regards,
Liviu

> 
> Gustavo

-- 

| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---
¯\_(ツ)_/¯
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: mali-dp: Disable planes when their CRTC gets disabled.

[Gustavo Padovan]

Hi Liviu,

2017-11-01 Liviu Dudau :

> Make sure only the planes on the active CRTCs get committed and
> that all planes on the disabled CRTCs get turned off.
> 
> Reviewed-by: Brian Starkey 
> Signed-off-by: Liviu Dudau 
> ---
>  drivers/gpu/drm/arm/malidp_crtc.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Gustavo Padovan 

Gustavo
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm: mali-dp: Disable planes when their CRTC gets disabled.

[Liviu Dudau]

Make sure only the planes on the active CRTCs get committed and
that all planes on the disabled CRTCs get turned off.

Reviewed-by: Brian Starkey 
Signed-off-by: Liviu Dudau 
---
 drivers/gpu/drm/arm/malidp_crtc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/arm/malidp_crtc.c 
b/drivers/gpu/drm/arm/malidp_crtc.c
index 153a496706262..904fff80917ba 100644
--- a/drivers/gpu/drm/arm/malidp_crtc.c
+++ b/drivers/gpu/drm/arm/malidp_crtc.c
@@ -77,6 +77,9 @@ static void malidp_crtc_atomic_disable(struct drm_crtc *crtc,
struct malidp_hw_device *hwdev = malidp->dev;
int err;
 
+   /* always disable planes on the CRTC that is being turned off */
+   drm_atomic_helper_disable_planes_on_crtc(old_state, false);
+
drm_crtc_vblank_off(crtc);
hwdev->hw->enter_config_mode(hwdev);
 
-- 
2.14.3

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel