Re: [PATCH] drm/meson: Remove unneeded semicolon
On 24/04/2020 09:49, Zheng Bin wrote: > Fixes coccicheck warning: > > drivers/gpu/drm/meson/meson_plane.c:226:3-4: Unneeded semicolon > > Reported-by: Hulk Robot > Signed-off-by: Zheng Bin > --- > drivers/gpu/drm/meson/meson_plane.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/meson/meson_plane.c > b/drivers/gpu/drm/meson/meson_plane.c > index d5cbc47835bf..35338ed18209 100644 > --- a/drivers/gpu/drm/meson/meson_plane.c > +++ b/drivers/gpu/drm/meson/meson_plane.c > @@ -223,7 +223,7 @@ static void meson_plane_atomic_update(struct drm_plane > *plane, > priv->viu.osd1_blk0_cfg[0] |= OSD_BLK_MODE_16 | > OSD_COLOR_MATRIX_16_RGB565; > break; > - }; > + } > } > > switch (fb->format->format) { > -- > 2.26.0.106.g9fadedd > Applied to drm-misc-next ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/meson: Remove unneeded semicolon
On 24/04/2020 09:49, Zheng Bin wrote: > Fixes coccicheck warning: > > drivers/gpu/drm/meson/meson_plane.c:226:3-4: Unneeded semicolon > > Reported-by: Hulk Robot > Signed-off-by: Zheng Bin > --- > drivers/gpu/drm/meson/meson_plane.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/meson/meson_plane.c > b/drivers/gpu/drm/meson/meson_plane.c > index d5cbc47835bf..35338ed18209 100644 > --- a/drivers/gpu/drm/meson/meson_plane.c > +++ b/drivers/gpu/drm/meson/meson_plane.c > @@ -223,7 +223,7 @@ static void meson_plane_atomic_update(struct drm_plane > *plane, > priv->viu.osd1_blk0_cfg[0] |= OSD_BLK_MODE_16 | > OSD_COLOR_MATRIX_16_RGB565; > break; > - }; > + } > } > > switch (fb->format->format) { > -- > 2.26.0.106.g9fadedd > Reviewed-by: Neil Armstrong ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/meson: Remove unneeded semicolon
Fixes coccicheck warning: drivers/gpu/drm/meson/meson_plane.c:226:3-4: Unneeded semicolon Reported-by: Hulk Robot Signed-off-by: Zheng Bin --- drivers/gpu/drm/meson/meson_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_plane.c b/drivers/gpu/drm/meson/meson_plane.c index d5cbc47835bf..35338ed18209 100644 --- a/drivers/gpu/drm/meson/meson_plane.c +++ b/drivers/gpu/drm/meson/meson_plane.c @@ -223,7 +223,7 @@ static void meson_plane_atomic_update(struct drm_plane *plane, priv->viu.osd1_blk0_cfg[0] |= OSD_BLK_MODE_16 | OSD_COLOR_MATRIX_16_RGB565; break; - }; + } } switch (fb->format->format) { -- 2.26.0.106.g9fadedd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm: meson: Remove unneeded semicolon
On 16/12/2019 04:58, zhengbin wrote: > Fixes coccicheck warning: > > drivers/gpu/drm/meson/meson_crtc.c:360:3-4: Unneeded semicolon > drivers/gpu/drm/meson/meson_plane.c:181:2-3: Unneeded semicolon > > Reported-by: Hulk Robot > Signed-off-by: zhengbin > --- > drivers/gpu/drm/meson/meson_crtc.c | 2 +- > drivers/gpu/drm/meson/meson_plane.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_crtc.c > b/drivers/gpu/drm/meson/meson_crtc.c > index 57ae1c1..eefefc4 100644 > --- a/drivers/gpu/drm/meson/meson_crtc.c > +++ b/drivers/gpu/drm/meson/meson_crtc.c > @@ -357,7 +357,7 @@ void meson_crtc_irq(struct meson_drm *priv) > MESON_CANVAS_WRAP_NONE, > MESON_CANVAS_BLKMODE_LINEAR, > MESON_CANVAS_ENDIAN_SWAP64); > - }; > + } > > writel_relaxed(priv->viu.vd1_if0_gen_reg, > priv->io_base + meson_crtc->viu_offset + > diff --git a/drivers/gpu/drm/meson/meson_plane.c > b/drivers/gpu/drm/meson/meson_plane.c > index ed54322..b96fa43 100644 > --- a/drivers/gpu/drm/meson/meson_plane.c > +++ b/drivers/gpu/drm/meson/meson_plane.c > @@ -178,7 +178,7 @@ static void meson_plane_atomic_update(struct drm_plane > *plane, > priv->viu.osd1_blk0_cfg[0] |= OSD_BLK_MODE_16 | > OSD_COLOR_MATRIX_16_RGB565; > break; > - }; > + } > > /* Default scaler parameters */ > vsc_bot_rcv_num = 0; > -- > 2.7.4 > Reviewed-by: Neil Armstrong and applied to drm-misc-next Thanks, Neil ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm: meson: Remove unneeded semicolon
Fixes coccicheck warning: drivers/gpu/drm/meson/meson_crtc.c:360:3-4: Unneeded semicolon drivers/gpu/drm/meson/meson_plane.c:181:2-3: Unneeded semicolon Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/gpu/drm/meson/meson_crtc.c | 2 +- drivers/gpu/drm/meson/meson_plane.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_crtc.c b/drivers/gpu/drm/meson/meson_crtc.c index 57ae1c1..eefefc4 100644 --- a/drivers/gpu/drm/meson/meson_crtc.c +++ b/drivers/gpu/drm/meson/meson_crtc.c @@ -357,7 +357,7 @@ void meson_crtc_irq(struct meson_drm *priv) MESON_CANVAS_WRAP_NONE, MESON_CANVAS_BLKMODE_LINEAR, MESON_CANVAS_ENDIAN_SWAP64); - }; + } writel_relaxed(priv->viu.vd1_if0_gen_reg, priv->io_base + meson_crtc->viu_offset + diff --git a/drivers/gpu/drm/meson/meson_plane.c b/drivers/gpu/drm/meson/meson_plane.c index ed54322..b96fa43 100644 --- a/drivers/gpu/drm/meson/meson_plane.c +++ b/drivers/gpu/drm/meson/meson_plane.c @@ -178,7 +178,7 @@ static void meson_plane_atomic_update(struct drm_plane *plane, priv->viu.osd1_blk0_cfg[0] |= OSD_BLK_MODE_16 | OSD_COLOR_MATRIX_16_RGB565; break; - }; + } /* Default scaler parameters */ vsc_bot_rcv_num = 0; -- 2.7.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel