Re: [PATCH] dt-bindings: display: Add SPI peripheral schema to SPI based displays

2022-01-19 Thread Rob Herring
On Tue, 21 Dec 2021 08:52:09 -0400, Rob Herring wrote:
> With 'unevaluatedProperties' support enabled, several SPI based display
> binding examples have warnings:
> 
> Documentation/devicetree/bindings/display/panel/samsung,ld9040.example.dt.yaml:
>  lcd@0: Unevaluated properties are not allowed ('#address-cells', 
> '#size-cells', 'spi-max-frequency', 'spi-cpol', 'spi-cpha' were unexpected)
> Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.example.dt.yaml:
>  panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
> 'spi-3wire' were unexpected)
> Documentation/devicetree/bindings/display/panel/ilitek,ili9322.example.dt.yaml:
>  display@0: Unevaluated properties are not allowed ('reg' was unexpected)
> Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.example.dt.yaml:
>  display@0: Unevaluated properties are not allowed ('spi-max-frequency' was 
> unexpected)
> Documentation/devicetree/bindings/display/panel/abt,y030xx067a.example.dt.yaml:
>  panel@0: Unevaluated properties are not allowed ('spi-max-frequency' was 
> unexpected)
> Documentation/devicetree/bindings/display/panel/sony,acx565akm.example.dt.yaml:
>  panel@2: Unevaluated properties are not allowed ('spi-max-frequency', 'reg' 
> were unexpected)
> Documentation/devicetree/bindings/display/panel/tpo,td.example.dt.yaml: 
> panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
> 'spi-cpol', 'spi-cpha' were unexpected)
> Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.example.dt.yaml:
>  panel@0: Unevaluated properties are not allowed ('reg', 'spi-max-frequency', 
> 'spi-cpol', 'spi-cpha' were unexpected)
> Documentation/devicetree/bindings/display/panel/innolux,ej030na.example.dt.yaml:
>  panel@0: Unevaluated properties are not allowed ('spi-max-frequency' was 
> unexpected)
> Documentation/devicetree/bindings/display/panel/sitronix,st7789v.example.dt.yaml:
>  panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
> 'spi-cpol', 'spi-cpha' were unexpected)
> 
> Fix all of these by adding a reference to spi-peripheral-props.yaml.
> With this, the description that the binding must follow
> spi-controller.yaml is both a bit out of date and redundant, so remove
> it.
> 
> Signed-off-by: Rob Herring 
> ---
> This is dependent on spi-peripheral-props.yaml landing in 5.17-rc1.
> ---
>  .../devicetree/bindings/display/panel/abt,y030xx067a.yaml  | 5 +
>  .../devicetree/bindings/display/panel/ilitek,ili9322.yaml  | 4 +---
>  .../devicetree/bindings/display/panel/innolux,ej030na.yaml | 5 +
>  .../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml   | 5 +
>  .../bindings/display/panel/lgphilips,lb035q02.yaml | 5 +
>  .../devicetree/bindings/display/panel/samsung,ld9040.yaml  | 7 +--
>  .../devicetree/bindings/display/panel/samsung,s6e63m0.yaml | 1 +
>  .../bindings/display/panel/sitronix,st7789v.yaml   | 5 +
>  .../devicetree/bindings/display/panel/sony,acx565akm.yaml  | 5 +
>  .../devicetree/bindings/display/panel/tpo,td.yaml  | 5 +
>  10 files changed, 10 insertions(+), 37 deletions(-)
> 

Applied, thanks!


Re: [PATCH] dt-bindings: display: Add SPI peripheral schema to SPI based displays

2021-12-21 Thread Sam Ravnborg
On Tue, Dec 21, 2021 at 08:52:09AM -0400, Rob Herring wrote:
> With 'unevaluatedProperties' support enabled, several SPI based display
> binding examples have warnings:
> 
> Documentation/devicetree/bindings/display/panel/samsung,ld9040.example.dt.yaml:
>  lcd@0: Unevaluated properties are not allowed ('#address-cells', 
> '#size-cells', 'spi-max-frequency', 'spi-cpol', 'spi-cpha' were unexpected)
> Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.example.dt.yaml:
>  panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
> 'spi-3wire' were unexpected)
> Documentation/devicetree/bindings/display/panel/ilitek,ili9322.example.dt.yaml:
>  display@0: Unevaluated properties are not allowed ('reg' was unexpected)
> Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.example.dt.yaml:
>  display@0: Unevaluated properties are not allowed ('spi-max-frequency' was 
> unexpected)
> Documentation/devicetree/bindings/display/panel/abt,y030xx067a.example.dt.yaml:
>  panel@0: Unevaluated properties are not allowed ('spi-max-frequency' was 
> unexpected)
> Documentation/devicetree/bindings/display/panel/sony,acx565akm.example.dt.yaml:
>  panel@2: Unevaluated properties are not allowed ('spi-max-frequency', 'reg' 
> were unexpected)
> Documentation/devicetree/bindings/display/panel/tpo,td.example.dt.yaml: 
> panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
> 'spi-cpol', 'spi-cpha' were unexpected)
> Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.example.dt.yaml:
>  panel@0: Unevaluated properties are not allowed ('reg', 'spi-max-frequency', 
> 'spi-cpol', 'spi-cpha' were unexpected)
> Documentation/devicetree/bindings/display/panel/innolux,ej030na.example.dt.yaml:
>  panel@0: Unevaluated properties are not allowed ('spi-max-frequency' was 
> unexpected)
> Documentation/devicetree/bindings/display/panel/sitronix,st7789v.example.dt.yaml:
>  panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
> 'spi-cpol', 'spi-cpha' were unexpected)
> 
> Fix all of these by adding a reference to spi-peripheral-props.yaml.
> With this, the description that the binding must follow
> spi-controller.yaml is both a bit out of date and redundant, so remove
> it.
> 
> Signed-off-by: Rob Herring 
Acked-by: Sam Ravnborg 


Re: [PATCH] dt-bindings: display: Add SPI peripheral schema to SPI based displays

2021-12-21 Thread Paul Cercueil

Hi Rob,

Le mar., déc. 21 2021 at 08:52:09 -0400, Rob Herring  
a écrit :
With 'unevaluatedProperties' support enabled, several SPI based 
display

binding examples have warnings:

Documentation/devicetree/bindings/display/panel/samsung,ld9040.example.dt.yaml: 
lcd@0: Unevaluated properties are not allowed ('#address-cells', 
'#size-cells', 'spi-max-frequency', 'spi-cpol', 'spi-cpha' were 
unexpected)
Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.example.dt.yaml: 
panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
'spi-3wire' were unexpected)
Documentation/devicetree/bindings/display/panel/ilitek,ili9322.example.dt.yaml: 
display@0: Unevaluated properties are not allowed ('reg' was 
unexpected)
Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.example.dt.yaml: 
display@0: Unevaluated properties are not allowed 
('spi-max-frequency' was unexpected)
Documentation/devicetree/bindings/display/panel/abt,y030xx067a.example.dt.yaml: 
panel@0: Unevaluated properties are not allowed ('spi-max-frequency' 
was unexpected)
Documentation/devicetree/bindings/display/panel/sony,acx565akm.example.dt.yaml: 
panel@2: Unevaluated properties are not allowed ('spi-max-frequency', 
'reg' were unexpected)
Documentation/devicetree/bindings/display/panel/tpo,td.example.dt.yaml: 
panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
'spi-cpol', 'spi-cpha' were unexpected)
Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.example.dt.yaml: 
panel@0: Unevaluated properties are not allowed ('reg', 
'spi-max-frequency', 'spi-cpol', 'spi-cpha' were unexpected)
Documentation/devicetree/bindings/display/panel/innolux,ej030na.example.dt.yaml: 
panel@0: Unevaluated properties are not allowed ('spi-max-frequency' 
was unexpected)
Documentation/devicetree/bindings/display/panel/sitronix,st7789v.example.dt.yaml: 
panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
'spi-cpol', 'spi-cpha' were unexpected)


Fix all of these by adding a reference to spi-peripheral-props.yaml.
With this, the description that the binding must follow
spi-controller.yaml is both a bit out of date and redundant, so remove
it.

Signed-off-by: Rob Herring 


Acked-by: Paul Cercueil 

Cheers,
-Paul




Re: [PATCH] dt-bindings: display: Add SPI peripheral schema to SPI based displays

2021-12-21 Thread Linus Walleij
On Tue, Dec 21, 2021 at 1:52 PM Rob Herring  wrote:

> With 'unevaluatedProperties' support enabled, several SPI based display
> binding examples have warnings:
(...)
> Fix all of these by adding a reference to spi-peripheral-props.yaml.
> With this, the description that the binding must follow
> spi-controller.yaml is both a bit out of date and redundant, so remove
> it.
>
> Signed-off-by: Rob Herring 

Excellent patch.
Reviewed-by: Linus Walleij 

Yours,
Linus Walleij


[PATCH] dt-bindings: display: Add SPI peripheral schema to SPI based displays

2021-12-21 Thread Rob Herring
With 'unevaluatedProperties' support enabled, several SPI based display
binding examples have warnings:

Documentation/devicetree/bindings/display/panel/samsung,ld9040.example.dt.yaml: 
lcd@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 
'spi-max-frequency', 'spi-cpol', 'spi-cpha' were unexpected)
Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.example.dt.yaml:
 panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
'spi-3wire' were unexpected)
Documentation/devicetree/bindings/display/panel/ilitek,ili9322.example.dt.yaml: 
display@0: Unevaluated properties are not allowed ('reg' was unexpected)
Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.example.dt.yaml:
 display@0: Unevaluated properties are not allowed ('spi-max-frequency' was 
unexpected)
Documentation/devicetree/bindings/display/panel/abt,y030xx067a.example.dt.yaml: 
panel@0: Unevaluated properties are not allowed ('spi-max-frequency' was 
unexpected)
Documentation/devicetree/bindings/display/panel/sony,acx565akm.example.dt.yaml: 
panel@2: Unevaluated properties are not allowed ('spi-max-frequency', 'reg' 
were unexpected)
Documentation/devicetree/bindings/display/panel/tpo,td.example.dt.yaml: 
panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
'spi-cpol', 'spi-cpha' were unexpected)
Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.example.dt.yaml:
 panel@0: Unevaluated properties are not allowed ('reg', 'spi-max-frequency', 
'spi-cpol', 'spi-cpha' were unexpected)
Documentation/devicetree/bindings/display/panel/innolux,ej030na.example.dt.yaml:
 panel@0: Unevaluated properties are not allowed ('spi-max-frequency' was 
unexpected)
Documentation/devicetree/bindings/display/panel/sitronix,st7789v.example.dt.yaml:
 panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
'spi-cpol', 'spi-cpha' were unexpected)

Fix all of these by adding a reference to spi-peripheral-props.yaml.
With this, the description that the binding must follow
spi-controller.yaml is both a bit out of date and redundant, so remove
it.

Signed-off-by: Rob Herring 
---
This is dependent on spi-peripheral-props.yaml landing in 5.17-rc1.
---
 .../devicetree/bindings/display/panel/abt,y030xx067a.yaml  | 5 +
 .../devicetree/bindings/display/panel/ilitek,ili9322.yaml  | 4 +---
 .../devicetree/bindings/display/panel/innolux,ej030na.yaml | 5 +
 .../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml   | 5 +
 .../bindings/display/panel/lgphilips,lb035q02.yaml | 5 +
 .../devicetree/bindings/display/panel/samsung,ld9040.yaml  | 7 +--
 .../devicetree/bindings/display/panel/samsung,s6e63m0.yaml | 1 +
 .../bindings/display/panel/sitronix,st7789v.yaml   | 5 +
 .../devicetree/bindings/display/panel/sony,acx565akm.yaml  | 5 +
 .../devicetree/bindings/display/panel/tpo,td.yaml  | 5 +
 10 files changed, 10 insertions(+), 37 deletions(-)

diff --git 
a/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml 
b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
index a108029ecfab..acd2f3faa6b9 100644
--- a/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
+++ b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
@@ -6,15 +6,12 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Asia Better Technology 3.0" (320x480 pixels) 24-bit IPS LCD panel
 
-description: |
-  The panel must obey the rules for a SPI slave device as specified in
-  spi/spi-controller.yaml
-
 maintainers:
   - Paul Cercueil 
 
 allOf:
   - $ref: panel-common.yaml#
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
 
 properties:
   compatible:
diff --git 
a/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml 
b/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml
index e89c1ea62ffa..7d221ef35443 100644
--- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml
@@ -15,11 +15,9 @@ description: |
   960 TFT source driver pins and 240 TFT gate driver pins, VCOM, VCOML and
   VCOMH outputs.
 
-  The panel must obey the rules for a SPI slave device as specified in
-  spi/spi-controller.yaml
-
 allOf:
   - $ref: panel-common.yaml#
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
 
 properties:
   compatible:
diff --git 
a/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml 
b/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml
index cda36c04e85c..72788e3e6c59 100644
--- a/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml
+++ b/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml
@@ -6,15 +6,12 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Innolux EJ030NA 3.0" (320x480 pixels) 24-bit TFT LCD panel
 
-description: |
-  The panel must obey the rules for a SPI slave