Re: [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
Hi, in short: this patch is "CANCELLED" : ) There is no need to add the pixel clock as a mandatory property because now the clock value is ajusted in adjusted_mode. Please have a look to patches: - drm/stm: ltdc: use crtc_mode_fixup to update adjusted_mode clock - drm/bridge/synopsys: dsi: use adjusted_mode in mode_set Hope it is better, comments are welcome Many thanks, Philippe :-) On 01/22/2018 04:38 PM, Philippe Cornu wrote: > Add the DPI/RGB input pixel clock in mandatory properties > because it really offers a better preciseness for timing > computations. > > Signed-off-by: Philippe Cornu > --- > Please apply "dt-bindings: display: stm32: correct clock-names > in dsi panel example" before this patch. > > Changes in v3: remove the note regarding swapped clock names >(now in a separate patch). > Changes in v2: put new clock in last position (Rob Herring) > > Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt > b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt > index 3eb1b48b47dd..942b7237ae87 100644 > --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt > +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt > @@ -29,6 +29,7 @@ Mandatory properties specific to STM32 DSI: > - compatible: "st,stm32-dsi". > - clock-names: > - phy pll reference clock string name, must be "ref". > + - DPI/RGB input pixel clock string name, must be "px_clk". > - resets: see [5]. > - reset-names: see [5]. > > @@ -97,8 +98,9 @@ Example 2: DSI panel > #size-cells = <0>; > compatible = "st,stm32-dsi"; > reg = <0x40016c00 0x800>; > - clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>; > - clock-names = "pclk", "ref"; > + clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>, > + <&rcc 1 CLK_LCD>; > + clock-names = "pclk", "ref", "px_clk"; > resets = <&rcc STM32F4_APB2_RESET(DSI)>; > reset-names = "apb"; > > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
Add the DPI/RGB input pixel clock in mandatory properties because it really offers a better preciseness for timing computations. Signed-off-by: Philippe Cornu --- Please apply "dt-bindings: display: stm32: correct clock-names in dsi panel example" before this patch. Changes in v3: remove the note regarding swapped clock names (now in a separate patch). Changes in v2: put new clock in last position (Rob Herring) Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt index 3eb1b48b47dd..942b7237ae87 100644 --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt @@ -29,6 +29,7 @@ Mandatory properties specific to STM32 DSI: - compatible: "st,stm32-dsi". - clock-names: - phy pll reference clock string name, must be "ref". + - DPI/RGB input pixel clock string name, must be "px_clk". - resets: see [5]. - reset-names: see [5]. @@ -97,8 +98,9 @@ Example 2: DSI panel #size-cells = <0>; compatible = "st,stm32-dsi"; reg = <0x40016c00 0x800>; - clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>; - clock-names = "pclk", "ref"; + clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>, +<&rcc 1 CLK_LCD>; + clock-names = "pclk", "ref", "px_clk"; resets = <&rcc STM32F4_APB2_RESET(DSI)>; reset-names = "apb"; -- 2.15.1 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
Add the DPI/RGB input pixel clock in mandatory properties because it really offers a better preciseness for timing computations. Signed-off-by: Philippe Cornu --- Please apply "dt-bindings: display: stm32: correct clock-names in dsi panel example" before this patch. Changes in v3: remove the note regarding swapped clock names (now in a separate patch). Changes in v2: put new clock in last position (Rob Herring) Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt index 3eb1b48b47dd..942b7237ae87 100644 --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt @@ -29,6 +29,7 @@ Mandatory properties specific to STM32 DSI: - compatible: "st,stm32-dsi". - clock-names: - phy pll reference clock string name, must be "ref". + - DPI/RGB input pixel clock string name, must be "px_clk". - resets: see [5]. - reset-names: see [5]. @@ -97,8 +98,9 @@ Example 2: DSI panel #size-cells = <0>; compatible = "st,stm32-dsi"; reg = <0x40016c00 0x800>; - clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>; - clock-names = "pclk", "ref"; + clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>, +<&rcc 1 CLK_LCD>; + clock-names = "pclk", "ref", "px_clk"; resets = <&rcc STM32F4_APB2_RESET(DSI)>; reset-names = "apb"; -- 2.15.1 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
Hi Rob, On 10/27/2017 04:38 PM, Rob Herring wrote: > On Thu, Oct 26, 2017 at 06:12:36PM +0200, Philippe Cornu wrote: >> Add the DPI/RGB input pixel clock in mandatory properties >> because it really offers a better preciseness for timing >> computations. >> Note: Fix also the DSI panel example where "ref" & "pclk" >> clocks were swapped. >> >> Signed-off-by: Philippe Cornu >> --- >> Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt >> b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt >> index 0292522..99823fb 100644 >> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt >> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt >> @@ -28,6 +28,7 @@ Mandatory properties specific to STM32 DSI: >> - #size-cells: Should be <0>. >> - compatible: "st,stm32-dsi". >> - clock-names: >> + - DPI/RGB input pixel clock string name, must be "px_clk". >> - phy pll reference clock string name, must be "ref". > > Where's pclk? pclk is described in the generic part (Documentation/devicetree/bindings/display/bridge/dw_mipi_dsi.txt) as mandatory. In st,stm32-ltdc.txt (specific part), I have documented that "For all mandatory properties & nodes, please refer to the related documentation in [5]". Do you think it is clear enough? > > The new clock should be last to be backwards compatible. > ok. Many thanks for your review and your support, Philippe :-) >> - resets: see [5]. >> - reset-names: see [5]. >> @@ -97,8 +98,9 @@ Example 2: DSI panel >> #size-cells = <0>; >> compatible = "st,stm32-dsi"; >> reg = <0x40016c00 0x800>; >> -clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>; >> -clock-names = "ref", "pclk"; >> +clocks = <&rcc 1 CLK_F469_DSI>, <&rcc 1 CLK_LCD>, >> + <&clk_hse>; >> +clock-names = "pclk", "px_clk", "ref"; >> resets = <&rcc STM32F4_APB2_RESET(DSI)>; >> reset-names = "apb"; >> >> -- >> 1.9.1 >> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
On Thu, Oct 26, 2017 at 06:12:36PM +0200, Philippe Cornu wrote: > Add the DPI/RGB input pixel clock in mandatory properties > because it really offers a better preciseness for timing > computations. > Note: Fix also the DSI panel example where "ref" & "pclk" > clocks were swapped. > > Signed-off-by: Philippe Cornu > --- > Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt > b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt > index 0292522..99823fb 100644 > --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt > +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt > @@ -28,6 +28,7 @@ Mandatory properties specific to STM32 DSI: > - #size-cells: Should be <0>. > - compatible: "st,stm32-dsi". > - clock-names: > + - DPI/RGB input pixel clock string name, must be "px_clk". >- phy pll reference clock string name, must be "ref". Where's pclk? The new clock should be last to be backwards compatible. > - resets: see [5]. > - reset-names: see [5]. > @@ -97,8 +98,9 @@ Example 2: DSI panel > #size-cells = <0>; > compatible = "st,stm32-dsi"; > reg = <0x40016c00 0x800>; > - clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>; > - clock-names = "ref", "pclk"; > + clocks = <&rcc 1 CLK_F469_DSI>, <&rcc 1 CLK_LCD>, > + <&clk_hse>; > + clock-names = "pclk", "px_clk", "ref"; > resets = <&rcc STM32F4_APB2_RESET(DSI)>; > reset-names = "apb"; > > -- > 1.9.1 > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
Add the DPI/RGB input pixel clock in mandatory properties because it really offers a better preciseness for timing computations. Note: Fix also the DSI panel example where "ref" & "pclk" clocks were swapped. Signed-off-by: Philippe Cornu --- Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt index 0292522..99823fb 100644 --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt @@ -28,6 +28,7 @@ Mandatory properties specific to STM32 DSI: - #size-cells: Should be <0>. - compatible: "st,stm32-dsi". - clock-names: + - DPI/RGB input pixel clock string name, must be "px_clk". - phy pll reference clock string name, must be "ref". - resets: see [5]. - reset-names: see [5]. @@ -97,8 +98,9 @@ Example 2: DSI panel #size-cells = <0>; compatible = "st,stm32-dsi"; reg = <0x40016c00 0x800>; - clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>; - clock-names = "ref", "pclk"; + clocks = <&rcc 1 CLK_F469_DSI>, <&rcc 1 CLK_LCD>, +<&clk_hse>; + clock-names = "pclk", "px_clk", "ref"; resets = <&rcc STM32F4_APB2_RESET(DSI)>; reset-names = "apb"; -- 1.9.1 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
