Re: [PATCH] video: fbdev: don't print error message on platform_get_irq() failure

[Sam Ravnborg]

Hi Tang Bin

On Mon, Apr 06, 2020 at 01:34:50PM +0800, Tang Bin wrote:
> The platform_get_irq() can print error message,so remove the redundant
> dev_err() here.
> 
> Signed-off-by: Tang Bin 
> ---
>  drivers/video/fbdev/atmel_lcdfb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/atmel_lcdfb.c 
> b/drivers/video/fbdev/atmel_lcdfb.c
> index d567f5d56..1e2521925 100644
> --- a/drivers/video/fbdev/atmel_lcdfb.c
> +++ b/drivers/video/fbdev/atmel_lcdfb.c
> @@ -1114,7 +1114,6 @@ static int __init atmel_lcdfb_probe(struct 
> platform_device *pdev)
>  
>   sinfo->irq_base = platform_get_irq(pdev, 0);
>   if (sinfo->irq_base < 0) {
> - dev_err(dev, "unable to get irq\n");
>   ret = sinfo->irq_base;
>   goto stop_clk;
>   }

Thanks, applied to drm-misc-next. The fix will appear in kernel 5.8

Sam
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: fbdev: don't print error message on platform_get_irq() failure

[Nicolas Ferre]

On 06/04/2020 at 07:34, Tang Bin wrote:

The platform_get_irq() can print error message,so remove the redundant
dev_err() here.

Signed-off-by: Tang Bin 


Acked-by: Nicolas Ferre 

---
  drivers/video/fbdev/atmel_lcdfb.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/atmel_lcdfb.c 
b/drivers/video/fbdev/atmel_lcdfb.c
index d567f5d56..1e2521925 100644
--- a/drivers/video/fbdev/atmel_lcdfb.c
+++ b/drivers/video/fbdev/atmel_lcdfb.c
@@ -1114,7 +1114,6 @@ static int __init atmel_lcdfb_probe(struct 
platform_device *pdev)

 sinfo->irq_base = platform_get_irq(pdev, 0);
 if (sinfo->irq_base < 0) {
-   dev_err(dev, "unable to get irq\n");
 ret = sinfo->irq_base;
 goto stop_clk;
 }
--
2.20.1.windows.1






--
Nicolas Ferre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] video: fbdev: don't print error message on platform_get_irq() failure

[Tang Bin]

The platform_get_irq() can print error message,so remove the redundant
dev_err() here.

Signed-off-by: Tang Bin 
---
 drivers/video/fbdev/atmel_lcdfb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/atmel_lcdfb.c 
b/drivers/video/fbdev/atmel_lcdfb.c
index d567f5d56..1e2521925 100644
--- a/drivers/video/fbdev/atmel_lcdfb.c
+++ b/drivers/video/fbdev/atmel_lcdfb.c
@@ -1114,7 +1114,6 @@ static int __init atmel_lcdfb_probe(struct 
platform_device *pdev)
 
sinfo->irq_base = platform_get_irq(pdev, 0);
if (sinfo->irq_base < 0) {
-   dev_err(dev, "unable to get irq\n");
ret = sinfo->irq_base;
goto stop_clk;
}
-- 
2.20.1.windows.1



___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel