Re: [PATCH] video: fbdev: imxfb: fix sparse warnings about using incorrect types

2019-06-21 Thread Bartlomiej Zolnierkiewicz

On 6/14/19 1:53 PM, Bartlomiej Zolnierkiewicz wrote:
> Use ->screen_buffer instead of ->screen_base to fix sparse warnings.
> 
> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base
>   pointer") for details. ]
> 
> Reported-by: kbuild test robot 
> Cc: Shawn Guo 
> Cc: Sascha Hauer 
> Cc: Pengutronix Kernel Team 
> Cc: Fabio Estevam 
> Cc: Uwe Kleine-König 
> Cc: NXP Linux Team 
> Signed-off-by: Bartlomiej Zolnierkiewicz 

I queued the patch for v5.3.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] video: fbdev: imxfb: fix sparse warnings about using incorrect types

2019-06-14 Thread Bartlomiej Zolnierkiewicz
Use ->screen_buffer instead of ->screen_base to fix sparse warnings.

[ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base
  pointer") for details. ]

Reported-by: kbuild test robot 
Cc: Shawn Guo 
Cc: Sascha Hauer 
Cc: Pengutronix Kernel Team 
Cc: Fabio Estevam 
Cc: Uwe Kleine-König 
Cc: NXP Linux Team 
Signed-off-by: Bartlomiej Zolnierkiewicz 
---
 drivers/video/fbdev/imxfb.c |9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

Index: b/drivers/video/fbdev/imxfb.c
===
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -974,9 +974,8 @@ static int imxfb_probe(struct platform_d
}
 
fbi->map_size = PAGE_ALIGN(info->fix.smem_len);
-   info->screen_base = dma_alloc_wc(>dev, fbi->map_size,
->map_dma, GFP_KERNEL);
-
+   info->screen_buffer = dma_alloc_wc(>dev, fbi->map_size,
+  >map_dma, GFP_KERNEL);
if (!info->screen_base) {
dev_err(>dev, "Failed to allocate video RAM: %d\n", ret);
ret = -ENOMEM;
@@ -1046,7 +1045,7 @@ failed_cmap:
if (pdata && pdata->exit)
pdata->exit(fbi->pdev);
 failed_platform_init:
-   dma_free_wc(>dev, fbi->map_size, info->screen_base,
+   dma_free_wc(>dev, fbi->map_size, info->screen_buffer,
fbi->map_dma);
 failed_map:
iounmap(fbi->regs);
@@ -1077,7 +1076,7 @@ static int imxfb_remove(struct platform_
pdata = dev_get_platdata(>dev);
if (pdata && pdata->exit)
pdata->exit(fbi->pdev);
-   dma_free_wc(>dev, fbi->map_size, info->screen_base,
+   dma_free_wc(>dev, fbi->map_size, info->screen_buffer,
fbi->map_dma);
iounmap(fbi->regs);
release_mem_region(res->start, resource_size(res));

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel