Re: [PATCH] video: fbdev: remove dead igafb driver

[Bartlomiej Zolnierkiewicz]

On Wednesday, October 18, 2017 04:45:31 PM Ondrej Zary wrote:
> On Wednesday 18 October 2017, David Miller wrote:
> > From: John Paul Adrian Glaubitz 
> > Date: Wed, 18 Oct 2017 15:14:27 +0200
> >
> > > Hi Bartlomiej!
> > >
> > > On 10/18/2017 02:56 PM, Bartlomiej Zolnierkiewicz wrote:
> > >> igafb driver hasn't compiled since at least kernel v2.6.34 as
> > >> commit 6016a363f6b5 ("of: unify phandle name in struct device_node")
> > >> missed updating igafb.c to use dp->phandle instead of dp->node.
> > >
> > > Would it take a lot of work to port the driver to the new interface?
> > >
> > > I'm not sure which SPARC machines use this particular framebuffer, but
> > > my plans are to fix up all these old framebuffer drivers. I have
> > > already
> > > received several Amiga (Zorro) graphics cards for testing the updated
> > > drivers on Amiga.
> > >
> > > It could be that I actually have this particular SPARC framebuffer in
> > > my hardware collection.
> >
> > Unless you have a 32-bit sparc laptop, you don't have a machine that
> > will use this driver.
> 
> There are also some x86 PCI cards using this chip.

Interesting, the driver has never supported x86 (it has always been
SPARC32 specific). Once somebody has the card we can think about adding
proper DRM driver for it (shouldn't be that hard). In the meantime I've
queued the patch removing dead igafb driver for 4.15.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: fbdev: remove dead igafb driver

[John Paul Adrian Glaubitz]

Hi Bartlomiej!

On 10/18/2017 02:56 PM, Bartlomiej Zolnierkiewicz wrote:

igafb driver hasn't compiled since at least kernel v2.6.34 as
commit 6016a363f6b5 ("of: unify phandle name in struct device_node")
missed updating igafb.c to use dp->phandle instead of dp->node.

Would it take a lot of work to port the driver to the new interface?

I'm not sure which SPARC machines use this particular framebuffer, but
my plans are to fix up all these old framebuffer drivers. I have already
received several Amiga (Zorro) graphics cards for testing the updated
drivers on Amiga.

It could be that I actually have this particular SPARC framebuffer in
my hardware collection.

Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: fbdev: remove dead igafb driver

[Ondrej Zary]

On Wednesday 18 October 2017, David Miller wrote:
> From: John Paul Adrian Glaubitz 
> Date: Wed, 18 Oct 2017 15:14:27 +0200
>
> > Hi Bartlomiej!
> >
> > On 10/18/2017 02:56 PM, Bartlomiej Zolnierkiewicz wrote:
> >> igafb driver hasn't compiled since at least kernel v2.6.34 as
> >> commit 6016a363f6b5 ("of: unify phandle name in struct device_node")
> >> missed updating igafb.c to use dp->phandle instead of dp->node.
> >
> > Would it take a lot of work to port the driver to the new interface?
> >
> > I'm not sure which SPARC machines use this particular framebuffer, but
> > my plans are to fix up all these old framebuffer drivers. I have
> > already
> > received several Amiga (Zorro) graphics cards for testing the updated
> > drivers on Amiga.
> >
> > It could be that I actually have this particular SPARC framebuffer in
> > my hardware collection.
>
> Unless you have a 32-bit sparc laptop, you don't have a machine that
> will use this driver.

There are also some x86 PCI cards using this chip.

-- 
Ondrej Zary
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: fbdev: remove dead igafb driver

[David Miller]

From: John Paul Adrian Glaubitz 
Date: Wed, 18 Oct 2017 15:14:27 +0200

> Hi Bartlomiej!
> 
> On 10/18/2017 02:56 PM, Bartlomiej Zolnierkiewicz wrote:
>> igafb driver hasn't compiled since at least kernel v2.6.34 as
>> commit 6016a363f6b5 ("of: unify phandle name in struct device_node")
>> missed updating igafb.c to use dp->phandle instead of dp->node.
> Would it take a lot of work to port the driver to the new interface?
> 
> I'm not sure which SPARC machines use this particular framebuffer, but
> my plans are to fix up all these old framebuffer drivers. I have
> already
> received several Amiga (Zorro) graphics cards for testing the updated
> drivers on Amiga.
> 
> It could be that I actually have this particular SPARC framebuffer in
> my hardware collection.

Unless you have a 32-bit sparc laptop, you don't have a machine that
will use this driver.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] video: fbdev: remove dead igafb driver

[Bartlomiej Zolnierkiewicz]

igafb driver hasn't compiled since at least kernel v2.6.34 as
commit 6016a363f6b5 ("of: unify phandle name in struct device_node")
missed updating igafb.c to use dp->phandle instead of dp->node.

Cc: "David S. Miller" 
Cc: Bhumika Goyal 
Signed-off-by: Bartlomiej Zolnierkiewicz 
---
 drivers/video/fbdev/Kconfig  |   10 
 drivers/video/fbdev/Makefile |1 
 drivers/video/fbdev/igafb.c  |  579 ---
 include/video/iga.h  |   24 -
 4 files changed, 614 deletions(-)

Index: b/drivers/video/fbdev/Kconfig
===
--- a/drivers/video/fbdev/Kconfig   2017-10-18 14:35:21.927448311 +0200
+++ b/drivers/video/fbdev/Kconfig   2017-10-18 14:39:19.455445309 +0200
@@ -905,16 +905,6 @@ config FB_LEO
  This is the frame buffer device driver for the SBUS-based Sun ZX
  (leo) frame buffer cards.
 
-config FB_IGA
-   bool "IGA 168x display support"
-   depends on (FB = y) && SPARC32
-   select FB_CFB_FILLRECT
-   select FB_CFB_COPYAREA
-   select FB_CFB_IMAGEBLIT
-   help
- This is the framebuffer device for the INTERGRAPHICS 1680 and
- successor frame buffer cards.
-
 config FB_XVR500
bool "Sun XVR-500 3DLABS Wildcat support"
depends on (FB = y) && PCI && SPARC64
Index: b/drivers/video/fbdev/Makefile
===
--- a/drivers/video/fbdev/Makefile  2017-10-18 14:35:21.927448311 +0200
+++ b/drivers/video/fbdev/Makefile  2017-10-18 14:39:30.555445169 +0200
@@ -64,7 +64,6 @@ obj-$(CONFIG_FB_HGA)  += hga
 obj-$(CONFIG_FB_XVR500)   += sunxvr500.o
 obj-$(CONFIG_FB_XVR2500)  += sunxvr2500.o
 obj-$(CONFIG_FB_XVR1000)  += sunxvr1000.o
-obj-$(CONFIG_FB_IGA)  += igafb.o
 obj-$(CONFIG_FB_APOLLO)   += dnfb.o
 obj-$(CONFIG_FB_Q40)  += q40fb.o
 obj-$(CONFIG_FB_TGA)  += tgafb.o
Index: b/drivers/video/fbdev/igafb.c
===
--- a/drivers/video/fbdev/igafb.c   2017-10-18 14:35:22.007448310 +0200
+++ /dev/null   1970-01-01 00:00:00.0 +
@@ -1,579 +0,0 @@
-/*
- *  linux/drivers/video/igafb.c -- Frame buffer device for IGA 1682
- *
- *  Copyright (C) 1998  Vladimir Roganov and Gleb Raiko
- *
- *  This driver is partly based on the Frame buffer device for ATI Mach64
- *  and partially on VESA-related code.
- *
- *  Copyright (C) 1997-1998  Geert Uytterhoeven
- *  Copyright (C) 1998  Bernd Harries
- *  Copyright (C) 1998  Eddie C. Dost  (e...@skynet.be)
- *
- *  This file is subject to the terms and conditions of the GNU General Public
- *  License. See the file COPYING in the main directory of this archive for
- *  more details.
- */
-
-/**
-
-  TODO:
-   Despite of IGA Card has advanced graphic acceleration, 
-   initial version is almost dummy and does not support it.
-   Support for video modes and acceleration must be added
-   together with accelerated X-Windows driver implementation.
-
-   Most important thing at this moment is that we have working
-   JavaEngine1  console & X  with new console interface.
-
-**/
-
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-
-#include 
-
-#ifdef CONFIG_SPARC
-#include 
-#include 
-#endif
-
-#include 
-
-struct pci_mmap_map {
-unsigned long voff;
-unsigned long poff;
-unsigned long size;
-unsigned long prot_flag;
-unsigned long prot_mask;
-};
-
-struct iga_par {
-   struct pci_mmap_map *mmap_map;
-   unsigned long frame_buffer_phys;
-   unsigned long io_base;
-};
-
-struct fb_info fb_info;
-
-struct fb_fix_screeninfo igafb_fix __initdata = {
-.id= "IGA 1682",
-   .type   = FB_TYPE_PACKED_PIXELS,
-   .mmio_len   = 1000
-};
-
-struct fb_var_screeninfo default_var = {
-   /* 640x480, 60 Hz, Non-Interlaced (25.175 MHz dotclock) */
-   .xres   = 640,
-   .yres   = 480,
-   .xres_virtual   = 640,
-   .yres_virtual   = 480,
-   .bits_per_pixel = 8,
-   .red= {0, 8, 0 },
-   .green  = {0, 8, 0 },
-   .blue   = {0, 8, 0 },
-   .height = -1,
-   .width  = -1,
-   .accel_flags= FB_ACCEL_NONE,
-   .pixclock   = 39722,
-   .left_margin= 48,
-   .right_margin   = 16,
-   .upper_margin   = 33,
-   .lower_margin   = 10,
-   .hsync_len  = 96,
-   .vsync_len  = 2,
-   .vmode  = FB_VMODE_NONINTERLACED
-};
-
-#ifdef CONFIG_SPARC
-struct