[PATCH 0/2] Adding rotattion to drm_plane_helper_check_update
On Tuesday 13 January 2015 11:42 PM, Matt Roper wrote: > On Tue, Jan 13, 2015 at 06:03:38PM +0530, Sonika Jindal wrote: >> This adds another parameter rotation to drm_plane_helper_check_update. >> This will enable this function to do to size updations based upon the >> rotation >> if any. >> Updated the calls to this function in i915 and drm. Rockchip driver also >> needs >> to be updated. > It looks like you add the new function parameter in patch 1, but don't > add it to the i915 callsites until patch 2 (and don't add it to the > rockchip driver at all in this series). That means that if someone is > bisecting the kernel and lands on this commit, some of the drivers will > fail to build, which isn't good. > > The callsites need to be updated at the same time that you add the > parameter; fortunately there are only four of them (two in i915, one in > the generic plane helper, and one in rockchip). For simplicity, you can > just pass the DRM_ROTATE_0 bit initially at the updated callsites when > you add the new parameter so that there's no change from the current > behavior for the existing callers. Then you can come back in later in > driver-specific patch(es) and pass the real rotation value the driver is > using and adjust the caller's functionality as appropriate. Sure, I will do this. Sonika > > Matt > >> Sonika Jindal (2): >>drm: Adding rotation to drm_plane_helper_check_update >>drm/i915: Passing rotation to drm_plane_helper_check_update >> >> drivers/gpu/drm/drm_plane_helper.c | 79 >> -- >> drivers/gpu/drm/i915/intel_display.c |6 ++- >> include/drm/drm_plane_helper.h |3 +- >> 3 files changed, 81 insertions(+), 7 deletions(-) >> >> -- >> 1.7.10.4 >>
[PATCH 0/2] Adding rotattion to drm_plane_helper_check_update
This adds another parameter rotation to drm_plane_helper_check_update. This will enable this function to do to size updations based upon the rotation if any. Updated the calls to this function in i915 and drm. Rockchip driver also needs to be updated. Sonika Jindal (2): drm: Adding rotation to drm_plane_helper_check_update drm/i915: Passing rotation to drm_plane_helper_check_update drivers/gpu/drm/drm_plane_helper.c | 79 -- drivers/gpu/drm/i915/intel_display.c |6 ++- include/drm/drm_plane_helper.h |3 +- 3 files changed, 81 insertions(+), 7 deletions(-) -- 1.7.10.4
[PATCH 0/2] Adding rotattion to drm_plane_helper_check_update
On Tue, Jan 13, 2015 at 06:03:38PM +0530, Sonika Jindal wrote: > This adds another parameter rotation to drm_plane_helper_check_update. > This will enable this function to do to size updations based upon the rotation > if any. > Updated the calls to this function in i915 and drm. Rockchip driver also needs > to be updated. It looks like you add the new function parameter in patch 1, but don't add it to the i915 callsites until patch 2 (and don't add it to the rockchip driver at all in this series). That means that if someone is bisecting the kernel and lands on this commit, some of the drivers will fail to build, which isn't good. The callsites need to be updated at the same time that you add the parameter; fortunately there are only four of them (two in i915, one in the generic plane helper, and one in rockchip). For simplicity, you can just pass the DRM_ROTATE_0 bit initially at the updated callsites when you add the new parameter so that there's no change from the current behavior for the existing callers. Then you can come back in later in driver-specific patch(es) and pass the real rotation value the driver is using and adjust the caller's functionality as appropriate. Matt > > Sonika Jindal (2): > drm: Adding rotation to drm_plane_helper_check_update > drm/i915: Passing rotation to drm_plane_helper_check_update > > drivers/gpu/drm/drm_plane_helper.c | 79 > -- > drivers/gpu/drm/i915/intel_display.c |6 ++- > include/drm/drm_plane_helper.h |3 +- > 3 files changed, 81 insertions(+), 7 deletions(-) > > -- > 1.7.10.4 > -- Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795
