Re: [PATCH 0/5] drm/lima: add error debug functionality

2020-03-21 Thread Qiang Yu
Thanks for review and test. Applied patch 1~4 to drm-misc-next.
As patch 5, due to related with non-continuous command stream,
I'd like to apply it when non-continuous command stream has been
implemented which may need a more common VA interface.

Thanks,
Qiang

On Sun, Mar 15, 2020 at 12:32 PM Vasily Khoruzhick  wrote:
>
> On Fri, Feb 21, 2020 at 6:43 PM Qiang Yu  wrote:
> >
> > Save task error state when it fail and export to user by
> > sysfs as a binary file which can be dumped and replayed
> > by lima_dump tool at:
> > https://gitlab.freedesktop.org/lima/lima_dump
>
> With v2 of Patch 3, series is:
>
> Reviewed-by: Vasily Khoruzhick 
>
>
> > Qiang Yu (5):
> >   drm/lima: save process info for debug usage
> >   drm/lima: add max_error_tasks module parameter
> >   drm/lima: save task info dump when task fail
> >   drm/lima: add error sysfs to export error task dump
> >   drm/lima: add LIMA_BO_FLAG_FORCE_VA
> >
> >  drivers/gpu/drm/lima/lima_ctx.c|   3 +
> >  drivers/gpu/drm/lima/lima_ctx.h|   5 ++
> >  drivers/gpu/drm/lima/lima_device.c |  13 +++
> >  drivers/gpu/drm/lima/lima_device.h |   8 ++
> >  drivers/gpu/drm/lima/lima_drv.c| 123 +--
> >  drivers/gpu/drm/lima/lima_drv.h|   1 +
> >  drivers/gpu/drm/lima/lima_dump.h   |  77 +
> >  drivers/gpu/drm/lima/lima_gem.c|   7 +-
> >  drivers/gpu/drm/lima/lima_gem.h|   4 +-
> >  drivers/gpu/drm/lima/lima_sched.c  | 128 +
> >  drivers/gpu/drm/lima/lima_sched.h  |   7 ++
> >  drivers/gpu/drm/lima/lima_vm.c |  13 ++-
> >  include/uapi/drm/lima_drm.h|   9 +-
> >  13 files changed, 385 insertions(+), 13 deletions(-)
> >  create mode 100644 drivers/gpu/drm/lima/lima_dump.h
> >
> > --
> > 2.17.1
> >
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH 0/5] drm/lima: add error debug functionality

2020-03-14 Thread Vasily Khoruzhick
On Fri, Feb 21, 2020 at 6:43 PM Qiang Yu  wrote:
>
> Save task error state when it fail and export to user by
> sysfs as a binary file which can be dumped and replayed
> by lima_dump tool at:
> https://gitlab.freedesktop.org/lima/lima_dump

With v2 of Patch 3, series is:

Reviewed-by: Vasily Khoruzhick 


> Qiang Yu (5):
>   drm/lima: save process info for debug usage
>   drm/lima: add max_error_tasks module parameter
>   drm/lima: save task info dump when task fail
>   drm/lima: add error sysfs to export error task dump
>   drm/lima: add LIMA_BO_FLAG_FORCE_VA
>
>  drivers/gpu/drm/lima/lima_ctx.c|   3 +
>  drivers/gpu/drm/lima/lima_ctx.h|   5 ++
>  drivers/gpu/drm/lima/lima_device.c |  13 +++
>  drivers/gpu/drm/lima/lima_device.h |   8 ++
>  drivers/gpu/drm/lima/lima_drv.c| 123 +--
>  drivers/gpu/drm/lima/lima_drv.h|   1 +
>  drivers/gpu/drm/lima/lima_dump.h   |  77 +
>  drivers/gpu/drm/lima/lima_gem.c|   7 +-
>  drivers/gpu/drm/lima/lima_gem.h|   4 +-
>  drivers/gpu/drm/lima/lima_sched.c  | 128 +
>  drivers/gpu/drm/lima/lima_sched.h  |   7 ++
>  drivers/gpu/drm/lima/lima_vm.c |  13 ++-
>  include/uapi/drm/lima_drm.h|   9 +-
>  13 files changed, 385 insertions(+), 13 deletions(-)
>  create mode 100644 drivers/gpu/drm/lima/lima_dump.h
>
> --
> 2.17.1
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH 0/5] drm/lima: add error debug functionality

2020-03-04 Thread Andreas Baierl
I could successfully use the output with 
https://gitlab.freedesktop.org/lima/lima.dump


So you can add my
Tested-by: Andreas Baierl 


Am 22.02.2020 um 03:42 schrieb Qiang Yu:

Save task error state when it fail and export to user by
sysfs as a binary file which can be dumped and replayed
by lima_dump tool at:
https://gitlab.freedesktop.org/lima/lima_dump

Qiang Yu (5):
   drm/lima: save process info for debug usage
   drm/lima: add max_error_tasks module parameter
   drm/lima: save task info dump when task fail
   drm/lima: add error sysfs to export error task dump
   drm/lima: add LIMA_BO_FLAG_FORCE_VA

  drivers/gpu/drm/lima/lima_ctx.c|   3 +
  drivers/gpu/drm/lima/lima_ctx.h|   5 ++
  drivers/gpu/drm/lima/lima_device.c |  13 +++
  drivers/gpu/drm/lima/lima_device.h |   8 ++
  drivers/gpu/drm/lima/lima_drv.c| 123 +--
  drivers/gpu/drm/lima/lima_drv.h|   1 +
  drivers/gpu/drm/lima/lima_dump.h   |  77 +
  drivers/gpu/drm/lima/lima_gem.c|   7 +-
  drivers/gpu/drm/lima/lima_gem.h|   4 +-
  drivers/gpu/drm/lima/lima_sched.c  | 128 +
  drivers/gpu/drm/lima/lima_sched.h  |   7 ++
  drivers/gpu/drm/lima/lima_vm.c |  13 ++-
  include/uapi/drm/lima_drm.h|   9 +-
  13 files changed, 385 insertions(+), 13 deletions(-)
  create mode 100644 drivers/gpu/drm/lima/lima_dump.h



___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH 0/5] drm/lima: add error debug functionality

2020-02-21 Thread Qiang Yu
Save task error state when it fail and export to user by
sysfs as a binary file which can be dumped and replayed
by lima_dump tool at:
https://gitlab.freedesktop.org/lima/lima_dump

Qiang Yu (5):
  drm/lima: save process info for debug usage
  drm/lima: add max_error_tasks module parameter
  drm/lima: save task info dump when task fail
  drm/lima: add error sysfs to export error task dump
  drm/lima: add LIMA_BO_FLAG_FORCE_VA

 drivers/gpu/drm/lima/lima_ctx.c|   3 +
 drivers/gpu/drm/lima/lima_ctx.h|   5 ++
 drivers/gpu/drm/lima/lima_device.c |  13 +++
 drivers/gpu/drm/lima/lima_device.h |   8 ++
 drivers/gpu/drm/lima/lima_drv.c| 123 +--
 drivers/gpu/drm/lima/lima_drv.h|   1 +
 drivers/gpu/drm/lima/lima_dump.h   |  77 +
 drivers/gpu/drm/lima/lima_gem.c|   7 +-
 drivers/gpu/drm/lima/lima_gem.h|   4 +-
 drivers/gpu/drm/lima/lima_sched.c  | 128 +
 drivers/gpu/drm/lima/lima_sched.h  |   7 ++
 drivers/gpu/drm/lima/lima_vm.c |  13 ++-
 include/uapi/drm/lima_drm.h|   9 +-
 13 files changed, 385 insertions(+), 13 deletions(-)
 create mode 100644 drivers/gpu/drm/lima/lima_dump.h

-- 
2.17.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel