Re: [PATCH 0/8] Cleanup use of ddc i2c buses
On Wed, Jun 1, 2022 at 9:56 PM Thomas Zimmermann wrote: > > Hi Patrik > > Am 01.06.22 um 11:23 schrieb Patrik Jakobsson: > > The various chips have slight differences in how they handle and store > > ddc i2c buses. This series tries to put the main i2c adapter for ddc > > into the drm_connector->ddc pointer. This makes it easier to unify the > > code for the different encoders in upcoming series. Oaktrail HDMI and > > PSB SDVO are not included. > > For the series: > > Acked-by: Thomas Zimmermann > > I recently posted two patches for simplifying EDID handing. The new DRM > helper for .get_modes fetches the EDID from conenctor->ddc. [1] The > helper for .detect_ctx uses .get_modes and the EDID data to poll the > connector status. [2] gma500 is one of the candidates for using these > helpers. If you like the idea, I'd welcome a follow-up patchset. Hi Thomas, thanks for having a look. I'll check to see if it applies to gma500. I have some encoder cleanups coming up for gma500 so I might do that first. Cheers Patrik > > Best regards > Thomas > > [1] > https://lore.kernel.org/dri-devel/20220516134343.6085-4-tzimmerm...@suse.de/ > [2] > https://lore.kernel.org/dri-devel/2022053502.4470-4-tzimmerm...@suse.de/ > > > > > Patrik Jakobsson (8): > >drm/gma500: Use gma_ prefix for our i2c abstraction > >drm/gma500: Make gma_i2c_chan a subclass of i2c_adapter > >drm/gma500: Make cdv lvds use ddc adapter from drm_connector > >drm/gma500: Make cdv hdmi use ddc adapter from drm_connector > >drm/gma500: Make psb lvds use ddc adapter from drm_connector > >drm/gma500: Make cdv crt use ddc adapter from drm_connector > >drm/gma500: Make oaktrail lvds use ddc adapter from drm_connector > >drm/gma500: Read EDID from the correct i2c adapter > > > > drivers/gpu/drm/gma500/cdv_intel_crt.c | 47 ++- > > drivers/gpu/drm/gma500/cdv_intel_hdmi.c| 98 +++--- > > drivers/gpu/drm/gma500/cdv_intel_lvds.c| 80 -- > > drivers/gpu/drm/gma500/intel_i2c.c | 36 > > drivers/gpu/drm/gma500/oaktrail_lvds.c | 50 ++- > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c | 36 > > drivers/gpu/drm/gma500/psb_drv.h | 2 +- > > drivers/gpu/drm/gma500/psb_intel_drv.h | 24 +++--- > > drivers/gpu/drm/gma500/psb_intel_lvds.c| 86 +-- > > 9 files changed, 237 insertions(+), 222 deletions(-) > > > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Ivo Totev
Re: [PATCH 0/8] Cleanup use of ddc i2c buses
Hi Patrik Am 01.06.22 um 11:23 schrieb Patrik Jakobsson: The various chips have slight differences in how they handle and store ddc i2c buses. This series tries to put the main i2c adapter for ddc into the drm_connector->ddc pointer. This makes it easier to unify the code for the different encoders in upcoming series. Oaktrail HDMI and PSB SDVO are not included. For the series: Acked-by: Thomas Zimmermann I recently posted two patches for simplifying EDID handing. The new DRM helper for .get_modes fetches the EDID from conenctor->ddc. [1] The helper for .detect_ctx uses .get_modes and the EDID data to poll the connector status. [2] gma500 is one of the candidates for using these helpers. If you like the idea, I'd welcome a follow-up patchset. Best regards Thomas [1] https://lore.kernel.org/dri-devel/20220516134343.6085-4-tzimmerm...@suse.de/ [2] https://lore.kernel.org/dri-devel/2022053502.4470-4-tzimmerm...@suse.de/ Patrik Jakobsson (8): drm/gma500: Use gma_ prefix for our i2c abstraction drm/gma500: Make gma_i2c_chan a subclass of i2c_adapter drm/gma500: Make cdv lvds use ddc adapter from drm_connector drm/gma500: Make cdv hdmi use ddc adapter from drm_connector drm/gma500: Make psb lvds use ddc adapter from drm_connector drm/gma500: Make cdv crt use ddc adapter from drm_connector drm/gma500: Make oaktrail lvds use ddc adapter from drm_connector drm/gma500: Read EDID from the correct i2c adapter drivers/gpu/drm/gma500/cdv_intel_crt.c | 47 ++- drivers/gpu/drm/gma500/cdv_intel_hdmi.c| 98 +++--- drivers/gpu/drm/gma500/cdv_intel_lvds.c| 80 -- drivers/gpu/drm/gma500/intel_i2c.c | 36 drivers/gpu/drm/gma500/oaktrail_lvds.c | 50 ++- drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c | 36 drivers/gpu/drm/gma500/psb_drv.h | 2 +- drivers/gpu/drm/gma500/psb_intel_drv.h | 24 +++--- drivers/gpu/drm/gma500/psb_intel_lvds.c| 86 +-- 9 files changed, 237 insertions(+), 222 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev OpenPGP_signature Description: OpenPGP digital signature
[PATCH 0/8] Cleanup use of ddc i2c buses
The various chips have slight differences in how they handle and store ddc i2c buses. This series tries to put the main i2c adapter for ddc into the drm_connector->ddc pointer. This makes it easier to unify the code for the different encoders in upcoming series. Oaktrail HDMI and PSB SDVO are not included. Patrik Jakobsson (8): drm/gma500: Use gma_ prefix for our i2c abstraction drm/gma500: Make gma_i2c_chan a subclass of i2c_adapter drm/gma500: Make cdv lvds use ddc adapter from drm_connector drm/gma500: Make cdv hdmi use ddc adapter from drm_connector drm/gma500: Make psb lvds use ddc adapter from drm_connector drm/gma500: Make cdv crt use ddc adapter from drm_connector drm/gma500: Make oaktrail lvds use ddc adapter from drm_connector drm/gma500: Read EDID from the correct i2c adapter drivers/gpu/drm/gma500/cdv_intel_crt.c | 47 ++- drivers/gpu/drm/gma500/cdv_intel_hdmi.c| 98 +++--- drivers/gpu/drm/gma500/cdv_intel_lvds.c| 80 -- drivers/gpu/drm/gma500/intel_i2c.c | 36 drivers/gpu/drm/gma500/oaktrail_lvds.c | 50 ++- drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c | 36 drivers/gpu/drm/gma500/psb_drv.h | 2 +- drivers/gpu/drm/gma500/psb_intel_drv.h | 24 +++--- drivers/gpu/drm/gma500/psb_intel_lvds.c| 86 +-- 9 files changed, 237 insertions(+), 222 deletions(-) -- 2.36.1
