[PATCH 0/8] drm/amdgpu: Fine-tuning for three function implementations

[Alex Deucher]

On Mon, Jul 18, 2016 at 3:41 AM, Christian König
 wrote:
> Am 16.07.2016 um 16:33 schrieb SF Markus Elfring:
>>
>> From: Markus Elfring 
>> Date: Sat, 16 Jul 2016 16:23:21 +0200
>>
>> Further update suggestions were taken into account after patches
>> were applied from static source code analysis.
>
>
> Small coding style nit pick on patch #7:
>>
>> -   }
>> +   } else
>> +   temp_storage = NULL;
>
> When an "if" has "{" and "}" the else should also use them even when it is
> only one line.
>
> With that fixed the whole series is Reviewed-by: Christian König
> , but as Walter Harms pointed out as well there
> are a couple of other things we could make more as well.

Applied the series except patch 2 was which already fixed by an earlier patch.

Thanks!

Alex

>
> Regards,
> Christian.
>
>>
>> Markus Elfring (8):
>>Delete an unnecessary check before
>> drm_gem_object_unreference_unlocked()
>>Delete unnecessary checks before the function call "kfree"
>>One function call less in amdgpu_cgs_acpi_eval_object() after error
>> detection
>>Delete a variable in amdgpu_cgs_acpi_eval_object()
>>Delete an unnecessary variable initialisation in
>> amdgpu_cgs_acpi_eval_object()
>>Change assignment for a variable in amdgpu_cgs_acpi_eval_object()
>>Change assignment for a buffer variable in phm_dispatch_table()
>>Delete an unnecessary variable initialisation in phm_dispatch_table()
>>
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 28
>> ++
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_display.c|  4 +---
>>   .../gpu/drm/amd/powerplay/hwmgr/functiontables.c   | 12 --
>>   3 files changed, 19 insertions(+), 25 deletions(-)
>>
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 0/8] drm/amdgpu: Fine-tuning for three function implementations

[Christian König]

Am 16.07.2016 um 16:33 schrieb SF Markus Elfring:
> From: Markus Elfring 
> Date: Sat, 16 Jul 2016 16:23:21 +0200
>
> Further update suggestions were taken into account after patches
> were applied from static source code analysis.

Small coding style nit pick on patch #7:
> - }
> + } else
> + temp_storage = NULL;
When an "if" has "{" and "}" the else should also use them even when it 
is only one line.

With that fixed the whole series is Reviewed-by: Christian König 
, but as Walter Harms pointed out as well 
there are a couple of other things we could make more as well.

Regards,
Christian.

>
> Markus Elfring (8):
>Delete an unnecessary check before drm_gem_object_unreference_unlocked()
>Delete unnecessary checks before the function call "kfree"
>One function call less in amdgpu_cgs_acpi_eval_object() after error 
> detection
>Delete a variable in amdgpu_cgs_acpi_eval_object()
>Delete an unnecessary variable initialisation in 
> amdgpu_cgs_acpi_eval_object()
>Change assignment for a variable in amdgpu_cgs_acpi_eval_object()
>Change assignment for a buffer variable in phm_dispatch_table()
>Delete an unnecessary variable initialisation in phm_dispatch_table()
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 28 
> ++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_display.c|  4 +---
>   .../gpu/drm/amd/powerplay/hwmgr/functiontables.c   | 12 --
>   3 files changed, 19 insertions(+), 25 deletions(-)
>

[PATCH 0/8] drm/amdgpu: Fine-tuning for three function implementations

[SF Markus Elfring]

From: Markus Elfring 
Date: Sat, 16 Jul 2016 16:23:21 +0200

Further update suggestions were taken into account after patches
were applied from static source code analysis.

Markus Elfring (8):
  Delete an unnecessary check before drm_gem_object_unreference_unlocked()
  Delete unnecessary checks before the function call "kfree"
  One function call less in amdgpu_cgs_acpi_eval_object() after error detection
  Delete a variable in amdgpu_cgs_acpi_eval_object()
  Delete an unnecessary variable initialisation in amdgpu_cgs_acpi_eval_object()
  Change assignment for a variable in amdgpu_cgs_acpi_eval_object()
  Change assignment for a buffer variable in phm_dispatch_table()
  Delete an unnecessary variable initialisation in phm_dispatch_table()

 drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 28 ++
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c|  4 +---
 .../gpu/drm/amd/powerplay/hwmgr/functiontables.c   | 12 --
 3 files changed, 19 insertions(+), 25 deletions(-)

-- 
2.9.1