Re: [PATCH 00/57] Rid W=1 warnings from Staging
On Wed, Apr 14, 2021 at 07:10:32PM +0100, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (57): 44 of these applied to my tree, I'll keep them in my "testing" branch for now until -rc1 comes out. Feel free to rebase your series on that and fix up the remaining ones and resend. Note, the comedi drivers have moved to drivers/comedi/ so those patches need to be sent as a different series, if you still want to make those changes based on the review comments. thanks, greg k-h ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 00/57] Rid W=1 warnings from Staging
On Wed, Apr 14, 2021 at 07:10:32PM +0100, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (57): > staging: r8192U_core: Remove two unused variables 'ret' and > 'reset_status' > staging: android: ashmem: Supply description for 'new_range' > staging: comedi_8254: Fix descriptions for 'i8254' and 'iobase' > staging: r8192U_core: Do not use kernel-doc formatting for !kernel-doc > headers > staging: r819xU_phy: Remove some local variables from the stack > staging: r819xU_cmdpkt: Remove functionless method > 'cmpk_handle_query_config_rx' > staging: wlan-ng: cfg80211: Move large struct onto the heap > staging: rtw_ioctl_set: Move 'channel_table' to the only place it's > used > staging: rtl8188eu: core: rtw_ieee80211: Fix incorrectly documented > function > staging: rtl8723bs: core: rtw_mlme: Remove a bunch of unused variables > staging: rtl8723bs: core: rtw_mlme_ext: Deal with a bunch of unused > variables > staging: rtl8712: rtl871x_mp_ioctl: Remove a bunch of unused tables > staging: rtl8723bs: core: rtw_recv: Mark debug variable as > __maybe_unused > staging: rtl8188eu: core: rtw_security: Fix some formatting and > misdocumentation > staging: rtl8723bs: core: rtw_security: Demote non-conformant > kernel-doc header > staging: rtl8723bs: core: rtw_sta_mgt: Remove unused variable 'psta' > staging: rtl8723bs: core: rtw_sta_mgt: Return error value directly > staging: octeon: ethernet-tx: Fix formatting issue in function header > staging: rtl8723bs: core: rtw_wlan_util: Remove unused variable > 'start_seq' > staging: rtl8712: rtl871x_mp_ioctl: Move a large data struct onto the > heap > staging: iio: frequency: ad9834: Provide missing description for > 'devid' > staging: nvec: Fix a bunch of kernel-doc issues > staging: ks7010: ks_hostif: Remove a bunch of unused variables > staging: fwserial: Demote a whole host of kernel-doc abuses > staging: sm750fb: sm750_accel: Provide description for 'accel' and fix > function naming > staging: most: net: Fix some kernel-doc formatting issues > staging: vt6655: upc: Suppress set but not used warning in macro > staging: rtl8192u: ieee80211_softmac: Move a large data struct onto > the heap > staging: most: dim2: Provide missing descriptions and fix doc-rot > staging: rtl8723bs: core: rtw_ieee80211: Remove seemingly pointless > copy > staging: rtl8723bs: core: rtw_mlme: 'retry' is only used if REJOIN is > set > staging: rtl8723bs: core: rtw_mlme_ext: 'evt_seq' is only used if > CHECK_EVENT_SEQ is set > staging: most: i2c: Fix a little doc-rot > staging: most: dim2: hal: Fix one kernel-doc header and demote two > non-conforming ones > staging: most: dim2: hal: Demote non-conformant kernel-doc headers > staging: axis-fifo: axis-fifo: Fix some formatting issues > staging: rtl8188eu: os_dep: ioctl_linux: Move 2 large data buffers > into the heap > staging: fbtft: fb_ili9320: Remove unused variable 'ret' > staging: rtl8723bs: core: rtw_ieee80211: Fix incorrectly named > function > staging: rtl8723bs: hal: odm_NoiseMonitor: Remove unused variable and > dead code > staging: rtl8188eu: os_dep: mon: Demote non-conforming kernel-doc > headers > staging: rtl8188eu: os_dep: rtw_android: Demote kernel-doc abuse > staging: rtl8723bs: hal: rtl8723b_hal_init: Remove unused variable and > dead code > staging: rtl8723bs: hal: rtl8723b_phycfg: Fix a bunch of misnamed > functions > staging: rtl8723bs: hal: sdio_halinit: 'start' is only used if debug > is enabled > staging: rtl8723bs: hal: sdio_ops: Mark used 'err' as __maybe_unused > and remove another > staging: rtl8723bs: os_dep: ioctl_cfg80211: 'ack' is used when debug > is enabled > staging: comedi: drivers: jr3_pci: Remove set but unused variable > 'min_full_scale' > staging: comedi: drivers: ni_tio: Fix slightly broken kernel-doc and > demote others > staging: comedi: drivers: ni_routes: Demote non-conforming kernel-doc > headers > staging: axis-fifo: axis-fifo: Fix function naming in the > documentation > staging: rtl8723bs: hal: odm_NoiseMonitor: Remove unused variable > 'func_start' > staging: rtl8723bs: core: rtw_mlme_ext: Move very large data buffer > onto the heap > staging: rtl8723bs: hal: rtl8723b_hal_init: Mark a bunch of debug > variables as __maybe_unused > staging: comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to > where it is used > staging: comedi: drivers: comedi_isadma: Fix misspelling of > 'dma_chan1' > staging: rtl8723bs: hal: sdio_halinit: Remove unused variable 'ret' > > drivers/staging/android/ashmem.c | 1 + > drivers/staging/axis-fifo/axis-fifo.c | 18 +-- >
Re: [PATCH 00/57] Rid W=1 warnings from Staging
On Fri, Apr 16, 2021 at 09:27:51AM +0200, Fabio Aiuto wrote: > On Wed, Apr 14, 2021 at 07:10:32PM +0100, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Lee Jones (57): > > staging: r8192U_core: Remove two unused variables 'ret' and > > 'reset_status' > > staging: android: ashmem: Supply description for 'new_range' > > staging: comedi_8254: Fix descriptions for 'i8254' and 'iobase' > > staging: r8192U_core: Do not use kernel-doc formatting for !kernel-doc > > headers > > staging: r819xU_phy: Remove some local variables from the stack > > staging: r819xU_cmdpkt: Remove functionless method > > 'cmpk_handle_query_config_rx' > > staging: wlan-ng: cfg80211: Move large struct onto the heap > > staging: rtw_ioctl_set: Move 'channel_table' to the only place it's > > used > > staging: rtl8188eu: core: rtw_ieee80211: Fix incorrectly documented > > function > > staging: rtl8723bs: core: rtw_mlme: Remove a bunch of unused variables > > staging: rtl8723bs: core: rtw_mlme_ext: Deal with a bunch of unused > > variables > > staging: rtl8712: rtl871x_mp_ioctl: Remove a bunch of unused tables > > staging: rtl8723bs: core: rtw_recv: Mark debug variable as > > __maybe_unused > > staging: rtl8188eu: core: rtw_security: Fix some formatting and > > misdocumentation > > staging: rtl8723bs: core: rtw_security: Demote non-conformant > > kernel-doc header > > staging: rtl8723bs: core: rtw_sta_mgt: Remove unused variable 'psta' > > staging: rtl8723bs: core: rtw_sta_mgt: Return error value directly > > staging: octeon: ethernet-tx: Fix formatting issue in function header > > staging: rtl8723bs: core: rtw_wlan_util: Remove unused variable > > 'start_seq' > > staging: rtl8712: rtl871x_mp_ioctl: Move a large data struct onto the > > heap > > staging: iio: frequency: ad9834: Provide missing description for > > 'devid' > > staging: nvec: Fix a bunch of kernel-doc issues > > staging: ks7010: ks_hostif: Remove a bunch of unused variables > > staging: fwserial: Demote a whole host of kernel-doc abuses > > staging: sm750fb: sm750_accel: Provide description for 'accel' and fix > > function naming > > staging: most: net: Fix some kernel-doc formatting issues > > staging: vt6655: upc: Suppress set but not used warning in macro > > staging: rtl8192u: ieee80211_softmac: Move a large data struct onto > > the heap > > staging: most: dim2: Provide missing descriptions and fix doc-rot > > staging: rtl8723bs: core: rtw_ieee80211: Remove seemingly pointless > > copy > > staging: rtl8723bs: core: rtw_mlme: 'retry' is only used if REJOIN is > > set > > staging: rtl8723bs: core: rtw_mlme_ext: 'evt_seq' is only used if > > CHECK_EVENT_SEQ is set > > staging: most: i2c: Fix a little doc-rot > > staging: most: dim2: hal: Fix one kernel-doc header and demote two > > non-conforming ones > > staging: most: dim2: hal: Demote non-conformant kernel-doc headers > > staging: axis-fifo: axis-fifo: Fix some formatting issues > > staging: rtl8188eu: os_dep: ioctl_linux: Move 2 large data buffers > > into the heap > > staging: fbtft: fb_ili9320: Remove unused variable 'ret' > > staging: rtl8723bs: core: rtw_ieee80211: Fix incorrectly named > > function > > staging: rtl8723bs: hal: odm_NoiseMonitor: Remove unused variable and > > dead code > > staging: rtl8188eu: os_dep: mon: Demote non-conforming kernel-doc > > headers > > staging: rtl8188eu: os_dep: rtw_android: Demote kernel-doc abuse > > staging: rtl8723bs: hal: rtl8723b_hal_init: Remove unused variable and > > dead code > > staging: rtl8723bs: hal: rtl8723b_phycfg: Fix a bunch of misnamed > > functions > > staging: rtl8723bs: hal: sdio_halinit: 'start' is only used if debug > > is enabled > > staging: rtl8723bs: hal: sdio_ops: Mark used 'err' as __maybe_unused > > and remove another > > staging: rtl8723bs: os_dep: ioctl_cfg80211: 'ack' is used when debug > > is enabled > > staging: comedi: drivers: jr3_pci: Remove set but unused variable > > 'min_full_scale' > > staging: comedi: drivers: ni_tio: Fix slightly broken kernel-doc and > > demote others > > staging: comedi: drivers: ni_routes: Demote non-conforming kernel-doc > > headers > > staging: axis-fifo: axis-fifo: Fix function naming in the > > documentation > > staging: rtl8723bs: hal: odm_NoiseMonitor: Remove unused variable > > 'func_start' > > staging: rtl8723bs: core: rtw_mlme_ext: Move very large data buffer > > onto the heap > > staging: rtl8723bs: hal: rtl8723b_hal_init: Mark a bunch of debug > > variables as __maybe_unused > > staging: comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to > > where it is used > > staging: comedi: drivers: comedi_isadma: Fix
[PATCH 00/57] Rid W=1 warnings from Staging
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (57): staging: r8192U_core: Remove two unused variables 'ret' and 'reset_status' staging: android: ashmem: Supply description for 'new_range' staging: comedi_8254: Fix descriptions for 'i8254' and 'iobase' staging: r8192U_core: Do not use kernel-doc formatting for !kernel-doc headers staging: r819xU_phy: Remove some local variables from the stack staging: r819xU_cmdpkt: Remove functionless method 'cmpk_handle_query_config_rx' staging: wlan-ng: cfg80211: Move large struct onto the heap staging: rtw_ioctl_set: Move 'channel_table' to the only place it's used staging: rtl8188eu: core: rtw_ieee80211: Fix incorrectly documented function staging: rtl8723bs: core: rtw_mlme: Remove a bunch of unused variables staging: rtl8723bs: core: rtw_mlme_ext: Deal with a bunch of unused variables staging: rtl8712: rtl871x_mp_ioctl: Remove a bunch of unused tables staging: rtl8723bs: core: rtw_recv: Mark debug variable as __maybe_unused staging: rtl8188eu: core: rtw_security: Fix some formatting and misdocumentation staging: rtl8723bs: core: rtw_security: Demote non-conformant kernel-doc header staging: rtl8723bs: core: rtw_sta_mgt: Remove unused variable 'psta' staging: rtl8723bs: core: rtw_sta_mgt: Return error value directly staging: octeon: ethernet-tx: Fix formatting issue in function header staging: rtl8723bs: core: rtw_wlan_util: Remove unused variable 'start_seq' staging: rtl8712: rtl871x_mp_ioctl: Move a large data struct onto the heap staging: iio: frequency: ad9834: Provide missing description for 'devid' staging: nvec: Fix a bunch of kernel-doc issues staging: ks7010: ks_hostif: Remove a bunch of unused variables staging: fwserial: Demote a whole host of kernel-doc abuses staging: sm750fb: sm750_accel: Provide description for 'accel' and fix function naming staging: most: net: Fix some kernel-doc formatting issues staging: vt6655: upc: Suppress set but not used warning in macro staging: rtl8192u: ieee80211_softmac: Move a large data struct onto the heap staging: most: dim2: Provide missing descriptions and fix doc-rot staging: rtl8723bs: core: rtw_ieee80211: Remove seemingly pointless copy staging: rtl8723bs: core: rtw_mlme: 'retry' is only used if REJOIN is set staging: rtl8723bs: core: rtw_mlme_ext: 'evt_seq' is only used if CHECK_EVENT_SEQ is set staging: most: i2c: Fix a little doc-rot staging: most: dim2: hal: Fix one kernel-doc header and demote two non-conforming ones staging: most: dim2: hal: Demote non-conformant kernel-doc headers staging: axis-fifo: axis-fifo: Fix some formatting issues staging: rtl8188eu: os_dep: ioctl_linux: Move 2 large data buffers into the heap staging: fbtft: fb_ili9320: Remove unused variable 'ret' staging: rtl8723bs: core: rtw_ieee80211: Fix incorrectly named function staging: rtl8723bs: hal: odm_NoiseMonitor: Remove unused variable and dead code staging: rtl8188eu: os_dep: mon: Demote non-conforming kernel-doc headers staging: rtl8188eu: os_dep: rtw_android: Demote kernel-doc abuse staging: rtl8723bs: hal: rtl8723b_hal_init: Remove unused variable and dead code staging: rtl8723bs: hal: rtl8723b_phycfg: Fix a bunch of misnamed functions staging: rtl8723bs: hal: sdio_halinit: 'start' is only used if debug is enabled staging: rtl8723bs: hal: sdio_ops: Mark used 'err' as __maybe_unused and remove another staging: rtl8723bs: os_dep: ioctl_cfg80211: 'ack' is used when debug is enabled staging: comedi: drivers: jr3_pci: Remove set but unused variable 'min_full_scale' staging: comedi: drivers: ni_tio: Fix slightly broken kernel-doc and demote others staging: comedi: drivers: ni_routes: Demote non-conforming kernel-doc headers staging: axis-fifo: axis-fifo: Fix function naming in the documentation staging: rtl8723bs: hal: odm_NoiseMonitor: Remove unused variable 'func_start' staging: rtl8723bs: core: rtw_mlme_ext: Move very large data buffer onto the heap staging: rtl8723bs: hal: rtl8723b_hal_init: Mark a bunch of debug variables as __maybe_unused staging: comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to where it is used staging: comedi: drivers: comedi_isadma: Fix misspelling of 'dma_chan1' staging: rtl8723bs: hal: sdio_halinit: Remove unused variable 'ret' drivers/staging/android/ashmem.c | 1 + drivers/staging/axis-fifo/axis-fifo.c | 18 +-- drivers/staging/comedi/drivers/comedi_8254.c | 3 +- .../staging/comedi/drivers/comedi_isadma.c| 2 +- drivers/staging/comedi/drivers/jr3_pci.c | 3 +- .../staging/comedi/drivers/ni_mio_common.c| 9 -- drivers/staging/comedi/drivers/ni_routes.c| 6 +-
