Hi, Yongqiang:
I would like you to add 'dt-bindings' in title.
On Mon, 2018-12-24 at 16:08 +0800, Yongqiang Niu wrote:
> Update device tree binding documention for the display subsystem for
> Mediatek MT8183 SOCs
>
> Signed-off-by: Yongqiang Niu
> ---
> .../devicetree/bindings/display/mediatek/mediatek,disp.txt| 11
> ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index 8469de5..1c66f39 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -28,9 +28,12 @@
> Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt.
> Required properties (all function blocks):
> - compatible: "mediatek,-disp-", one of
> "mediatek,-disp-ovl" - overlay (4 layers, blending, csc)
> + "mediatek,-disp-ovl-2l" - overlay (2 layers, blending, csc)
Other '-' is aliened, so do this one.
> "mediatek,-disp-rdma" - read DMA / line buffer
> "mediatek,-disp-wdma" - write DMA
> + "mediatek,-disp-ccorr" - color correction
> "mediatek,-disp-color" - color processor
> + "mediatek,-disp-dither" - dither
Ditto.
> "mediatek,-disp-aal" - adaptive ambient light controller
> "mediatek,-disp-gamma" - gamma correction
> "mediatek,-disp-merge" - merge streams from two RDMA sources
> @@ -40,7 +43,7 @@ Required properties (all function blocks):
> "mediatek,-dpi"- DPI controller, see mediatek,dpi.txt
> "mediatek,-disp-mutex" - display mutex
> "mediatek,-disp-od"- overdrive
> - the supported chips are mt2701, mt2712 and mt8173.
> + the supported chips are mt2701, mt2712, mt8173 and mt8183.
> - reg: Physical base address and length of the function block register space
> - interrupts: The interrupt signal from the function block (required, except
> for
>merge and split function blocks).
> @@ -71,6 +74,12 @@ mmsys: clock-controller@1400 {
> #clock-cells = <1>;
> };
>
> +display_components: dispsys@1400 {
> + compatible = "mediatek,mt8183-display";
"mediatek,mt8183-display" is undefined. I think this should be
"mediatek,mt8183-mmsys" and you have met the same problem in [1]. You
may depend on that series to develop your patches.
[1]
http://lists.infradead.org/pipermail/linux-mediatek/2018-November/015860.html
Regards,
CK
> + reg = <0 0x1400 0 0x1000>;
> + power-domains = < MT8183_POWER_DOMAIN_DISP>;
> +};
> +
> ovl0: ovl@1400c000 {
> compatible = "mediatek,mt8173-disp-ovl";
> reg = <0 0x1400c000 0 0x1000>;
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
