Re: [PATCH 02/12] dt-bindings: display: msm: Add reg bus and rotator interconnects

2023-11-26 Thread Krzysztof Kozlowski 
On 25/11/2023 15:17, Konrad Dybcio wrote:
> Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there are
> other connection paths:
> - a path that connects rotator block to the DDR.
> - a path that needs to be handled to ensure MDSS register access
>   functions properly, namely the "reg bus", a.k.a the CPU-MDSS CFG
>   interconnect.
> 
> Describe these paths bindings to allow using them in device trees and in
> the driver
> 
> Signed-off-by: Dmitry Baryshkov 
> [Konrad: rework for one vs two MDP paths]
> Signed-off-by: Konrad Dybcio 
> ---

Reviewed-by: Krzysztof Kozlowski 

Best regards,
Krzysztof

[PATCH 02/12] dt-bindings: display: msm: Add reg bus and rotator interconnects

2023-11-25 Thread Konrad Dybcio 
Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there are
other connection paths:
- a path that connects rotator block to the DDR.
- a path that needs to be handled to ensure MDSS register access
  functions properly, namely the "reg bus", a.k.a the CPU-MDSS CFG
  interconnect.

Describe these paths bindings to allow using them in device trees and in
the driver

Signed-off-by: Dmitry Baryshkov 
[Konrad: rework for one vs two MDP paths]
Signed-off-by: Konrad Dybcio 
---
 .../devicetree/bindings/display/msm/mdss-common.yaml   | 18 ++
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml 
b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
index f69196e4cc76..c6305a6e0334 100644
--- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
+++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
@@ -61,17 +61,27 @@ properties:
 
   ranges: true
 
+  # This is not a perfect description, but it's impossible to discern and match
+  # the entries like we do with interconnect-names
   interconnects:
 minItems: 1
 items:
   - description: Interconnect path from mdp0 (or a single mdp) port to the 
data bus
   - description: Interconnect path from mdp1 port to the data bus
+  - description: Interconnect path from CPU to the reg bus
 
   interconnect-names:
-minItems: 1
-items:
-  - const: mdp0-mem
-  - const: mdp1-mem
+oneOf:
+  - minItems: 1
+items:
+  - const: mdp0-mem
+  - const: cpu-cfg
+
+  - minItems: 2
+items:
+  - const: mdp0-mem
+  - const: mdp1-mem
+  - const: cpu-cfg
 
   resets:
 items:

-- 
2.43.0