Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro
On Thu, 2019-07-25 at 02:52 +, Joel Stanley wrote: > On Thu, 25 Jul 2019 at 01:18, Joe Perches wrote: > > On Thu, 2019-07-25 at 10:40 +0930, Andrew Jeffery wrote: > > > On Thu, 25 Jul 2019, at 02:46, Joe Perches wrote: > > > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > > > Arguments are supposed to be ordered high then low. > > > > > > > > > > Signed-off-by: Joe Perches > > > > > --- > > > > > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > > b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > > index a10358bb61ec..095ea03e5833 100644 > > > > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > > @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device > > > > > *drm); > > > > > /* CTRL2 */ > > > > > #define CRT_CTRL_DAC_EN BIT(0) > > > > > #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & > > > > > CRT_CTRL_VBLANK_LINE_MASK) > > > > > -#define CRT_CTRL_VBLANK_LINE_MASKGENMASK(20, 31) > > > > > +#define CRT_CTRL_VBLANK_LINE_MASKGENMASK(31, 20) > > > > > > Reviewed-by: Andrew Jeffery > > > > This hardly needs a review, it needs to be applied. > > There's a nominal git tree for aspeed here: > > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git > > > > But who's going to do apply this? > > This is a DRM patch, so it goes through the DRM tree. I am a > co-maintainer there and can apply it once I remember how to drive the > tools. > > (FYI, this macro is not used by the current driver). Then perhaps CRT_CTRL_VBLANK and _MASK defines should be removed instead. cheers, Joe ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro
On Thu, 25 Jul 2019 at 01:18, Joe Perches wrote: > > On Thu, 2019-07-25 at 10:40 +0930, Andrew Jeffery wrote: > > > > On Thu, 25 Jul 2019, at 02:46, Joe Perches wrote: > > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > > Arguments are supposed to be ordered high then low. > > > > > > > > Signed-off-by: Joe Perches > > > > --- > > > > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > index a10358bb61ec..095ea03e5833 100644 > > > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm); > > > > /* CTRL2 */ > > > > #define CRT_CTRL_DAC_EN BIT(0) > > > > #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & > > > > CRT_CTRL_VBLANK_LINE_MASK) > > > > -#define CRT_CTRL_VBLANK_LINE_MASKGENMASK(20, 31) > > > > +#define CRT_CTRL_VBLANK_LINE_MASKGENMASK(31, 20) > > > > Reviewed-by: Andrew Jeffery > > This hardly needs a review, it needs to be applied. > There's a nominal git tree for aspeed here: > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git > > But who's going to do apply this? This is a DRM patch, so it goes through the DRM tree. I am a co-maintainer there and can apply it once I remember how to drive the tools. (FYI, this macro is not used by the current driver). Cheers, Joel ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro
On Thu, 2019-07-25 at 10:40 +0930, Andrew Jeffery wrote: > > On Thu, 25 Jul 2019, at 02:46, Joe Perches wrote: > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > Arguments are supposed to be ordered high then low. > > > > > > Signed-off-by: Joe Perches > > > --- > > > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > index a10358bb61ec..095ea03e5833 100644 > > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm); > > > /* CTRL2 */ > > > #define CRT_CTRL_DAC_EN BIT(0) > > > #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & > > > CRT_CTRL_VBLANK_LINE_MASK) > > > -#define CRT_CTRL_VBLANK_LINE_MASKGENMASK(20, 31) > > > +#define CRT_CTRL_VBLANK_LINE_MASKGENMASK(31, 20) > > Reviewed-by: Andrew Jeffery This hardly needs a review, it needs to be applied. There's a nominal git tree for aspeed here: T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git But who's going to do apply this?
Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro
On Thu, 25 Jul 2019, at 02:46, Joe Perches wrote: > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > Arguments are supposed to be ordered high then low. > > > > Signed-off-by: Joe Perches > > --- > > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h > > b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > index a10358bb61ec..095ea03e5833 100644 > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm); > > /* CTRL2 */ > > #define CRT_CTRL_DAC_ENBIT(0) > > #define CRT_CTRL_VBLANK_LINE(x)(((x) << 20) & > > CRT_CTRL_VBLANK_LINE_MASK) > > -#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(20, 31) > > +#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(31, 20) Reviewed-by: Andrew Jeffery > > ping? > > >
Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro
On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches > --- > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h > b/drivers/gpu/drm/aspeed/aspeed_gfx.h > index a10358bb61ec..095ea03e5833 100644 > --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm); > /* CTRL2 */ > #define CRT_CTRL_DAC_EN BIT(0) > #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & > CRT_CTRL_VBLANK_LINE_MASK) > -#define CRT_CTRL_VBLANK_LINE_MASKGENMASK(20, 31) > +#define CRT_CTRL_VBLANK_LINE_MASKGENMASK(31, 20) ping? ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/drivers/gpu/drm/aspeed/aspeed_gfx.h index a10358bb61ec..095ea03e5833 100644 --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm); /* CTRL2 */ #define CRT_CTRL_DAC_ENBIT(0) #define CRT_CTRL_VBLANK_LINE(x)(((x) << 20) & CRT_CTRL_VBLANK_LINE_MASK) -#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(20, 31) +#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(31, 20) /* CRT_HORIZ0 */ #define CRT_H_TOTAL(x) (x) -- 2.15.0 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
