Re: [PATCH 04/10] drm/vkms: Move format arrays to vkms_plane.c
On 06/07, Daniel Vetter wrote: > No need to have them multiple times. > > Signed-off-by: Daniel Vetter > Cc: Rodrigo Siqueira > Cc: Haneen Mohammed > Cc: Daniel Vetter > --- > drivers/gpu/drm/vkms/vkms_drv.h | 8 > drivers/gpu/drm/vkms/vkms_plane.c | 8 > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > index 43d3f98289fe..2a35299bfb89 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.h > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > @@ -20,14 +20,6 @@ > > extern bool enable_cursor; > > -static const u32 vkms_formats[] = { > - DRM_FORMAT_XRGB, > -}; > - > -static const u32 vkms_cursor_formats[] = { > - DRM_FORMAT_ARGB, > -}; > - > struct vkms_crc_data { > struct drm_framebuffer fb; > struct drm_rect src, dst; > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c > b/drivers/gpu/drm/vkms/vkms_plane.c > index 0e67d2d42f0c..0fceb6258422 100644 > --- a/drivers/gpu/drm/vkms/vkms_plane.c > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > @@ -6,6 +6,14 @@ > #include > #include > > +static const u32 vkms_formats[] = { > + DRM_FORMAT_XRGB, > +}; > + > +static const u32 vkms_cursor_formats[] = { > + DRM_FORMAT_ARGB, > +}; > + > static struct drm_plane_state * > vkms_plane_duplicate_state(struct drm_plane *plane) > { > -- > 2.20.1 > Applied to the drm-misc-next branch. Thanks. -- Rodrigo Siqueira https://siqueira.tech signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 04/10] drm/vkms: Move format arrays to vkms_plane.c
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote: > > No need to have them multiple times. > > Signed-off-by: Daniel Vetter > Cc: Rodrigo Siqueira > Cc: Haneen Mohammed > Cc: Daniel Vetter > --- > drivers/gpu/drm/vkms/vkms_drv.h | 8 > drivers/gpu/drm/vkms/vkms_plane.c | 8 > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > index 43d3f98289fe..2a35299bfb89 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.h > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > @@ -20,14 +20,6 @@ > > extern bool enable_cursor; > > -static const u32 vkms_formats[] = { > - DRM_FORMAT_XRGB, > -}; > - > -static const u32 vkms_cursor_formats[] = { > - DRM_FORMAT_ARGB, > -}; > - > struct vkms_crc_data { > struct drm_framebuffer fb; > struct drm_rect src, dst; > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c > b/drivers/gpu/drm/vkms/vkms_plane.c > index 0e67d2d42f0c..0fceb6258422 100644 > --- a/drivers/gpu/drm/vkms/vkms_plane.c > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > @@ -6,6 +6,14 @@ > #include > #include > > +static const u32 vkms_formats[] = { > + DRM_FORMAT_XRGB, > +}; > + > +static const u32 vkms_cursor_formats[] = { > + DRM_FORMAT_ARGB, > +}; > + > static struct drm_plane_state * > vkms_plane_duplicate_state(struct drm_plane *plane) > { > -- > 2.20.1 > Reviewed-by: Rodrigo Siqueira Tested-by: Rodrigo Siqueira -- Rodrigo Siqueira https://siqueira.tech ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 04/10] drm/vkms: Move format arrays to vkms_plane.c
No need to have them multiple times. Signed-off-by: Daniel Vetter Cc: Rodrigo Siqueira Cc: Haneen Mohammed Cc: Daniel Vetter --- drivers/gpu/drm/vkms/vkms_drv.h | 8 drivers/gpu/drm/vkms/vkms_plane.c | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h index 43d3f98289fe..2a35299bfb89 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.h +++ b/drivers/gpu/drm/vkms/vkms_drv.h @@ -20,14 +20,6 @@ extern bool enable_cursor; -static const u32 vkms_formats[] = { - DRM_FORMAT_XRGB, -}; - -static const u32 vkms_cursor_formats[] = { - DRM_FORMAT_ARGB, -}; - struct vkms_crc_data { struct drm_framebuffer fb; struct drm_rect src, dst; diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c index 0e67d2d42f0c..0fceb6258422 100644 --- a/drivers/gpu/drm/vkms/vkms_plane.c +++ b/drivers/gpu/drm/vkms/vkms_plane.c @@ -6,6 +6,14 @@ #include #include +static const u32 vkms_formats[] = { + DRM_FORMAT_XRGB, +}; + +static const u32 vkms_cursor_formats[] = { + DRM_FORMAT_ARGB, +}; + static struct drm_plane_state * vkms_plane_duplicate_state(struct drm_plane *plane) { -- 2.20.1 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel