Re: [PATCH 05/13] drm/omap: sdi: remove legacy set_datapairs

[Laurent Pinchart]

Hi Tomi,

Thank you for the patch.

On Friday 12 May 2017 13:41:34 Tomi Valkeinen wrote:
> Non-DT booting is no longer supported, so remove legacy code.
> 
> Signed-off-by: Tomi Valkeinen 

Reviewed-by: Laurent Pinchart 

> ---
>  drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 --
>  drivers/gpu/drm/omapdrm/dss/sdi.c | 7 ---
>  2 files changed, 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> b/drivers/gpu/drm/omapdrm/dss/omapdss.h index 8396036e210c..1ce53b072b16
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -490,8 +490,6 @@ struct omapdss_sdi_ops {
>   struct videomode *vm);
>   void (*get_timings)(struct omap_dss_device *dssdev,
>   struct videomode *vm);
> -
> - void (*set_datapairs)(struct omap_dss_device *dssdev, int datapairs);
>  };
> 
>  struct omapdss_dvi_ops {
> @@ -642,10 +640,6 @@ struct omap_dss_device {
>   } rfbi;
> 
>   struct {
> - u8 datapairs;
> - } sdi;
> -
> - struct {
>   int module;
>   } dsi;
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/sdi.c
> b/drivers/gpu/drm/omapdrm/dss/sdi.c index f2f8aed53a7b..d18ad58c5a19 100644
> --- a/drivers/gpu/drm/omapdrm/dss/sdi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/sdi.c
> @@ -252,11 +252,6 @@ static int sdi_check_timings(struct omap_dss_device
> *dssdev, return 0;
>  }
> 
> -static void sdi_set_datapairs(struct omap_dss_device *dssdev, int
> datapairs) -{
> - sdi.datapairs = datapairs;
> -}
> -
>  static int sdi_init_regulator(void)
>  {
>   struct regulator *vdds_sdi;
> @@ -326,8 +321,6 @@ static const struct omapdss_sdi_ops sdi_ops = {
>   .check_timings = sdi_check_timings,
>   .set_timings = sdi_set_timings,
>   .get_timings = sdi_get_timings,
> -
> - .set_datapairs = sdi_set_datapairs,
>  };
> 
>  static void sdi_init_output(struct platform_device *pdev)

-- 
Regards,

Laurent Pinchart

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 05/13] drm/omap: sdi: remove legacy set_datapairs

[Tomi Valkeinen]

Non-DT booting is no longer supported, so remove legacy code.

Signed-off-by: Tomi Valkeinen 
---
 drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 --
 drivers/gpu/drm/omapdrm/dss/sdi.c | 7 ---
 2 files changed, 13 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h 
b/drivers/gpu/drm/omapdrm/dss/omapdss.h
index 8396036e210c..1ce53b072b16 100644
--- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
+++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
@@ -490,8 +490,6 @@ struct omapdss_sdi_ops {
struct videomode *vm);
void (*get_timings)(struct omap_dss_device *dssdev,
struct videomode *vm);
-
-   void (*set_datapairs)(struct omap_dss_device *dssdev, int datapairs);
 };
 
 struct omapdss_dvi_ops {
@@ -642,10 +640,6 @@ struct omap_dss_device {
} rfbi;
 
struct {
-   u8 datapairs;
-   } sdi;
-
-   struct {
int module;
} dsi;
 
diff --git a/drivers/gpu/drm/omapdrm/dss/sdi.c 
b/drivers/gpu/drm/omapdrm/dss/sdi.c
index f2f8aed53a7b..d18ad58c5a19 100644
--- a/drivers/gpu/drm/omapdrm/dss/sdi.c
+++ b/drivers/gpu/drm/omapdrm/dss/sdi.c
@@ -252,11 +252,6 @@ static int sdi_check_timings(struct omap_dss_device 
*dssdev,
return 0;
 }
 
-static void sdi_set_datapairs(struct omap_dss_device *dssdev, int datapairs)
-{
-   sdi.datapairs = datapairs;
-}
-
 static int sdi_init_regulator(void)
 {
struct regulator *vdds_sdi;
@@ -326,8 +321,6 @@ static const struct omapdss_sdi_ops sdi_ops = {
.check_timings = sdi_check_timings,
.set_timings = sdi_set_timings,
.get_timings = sdi_get_timings,
-
-   .set_datapairs = sdi_set_datapairs,
 };
 
 static void sdi_init_output(struct platform_device *pdev)
-- 
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel